Google Git
Sign in
dawn / dawn / cebd6052eddd474ddf2d34aa5b883bda436073e7
commitcebd6052eddd474ddf2d34aa5b883bda436073e7[log] [tgz]
authorBrandon Jones <bajones@chromium.org>Wed Oct 25 01:41:59 2023 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 25 01:41:59 2023 +0000
treef97f2d81eacb025385165206913162efb37a43b2
parente542c349d58a443b323ac97843739c8264030df3 [diff]
Move state tracking for command buffer splits

The VulkanSplitCommandBufferOnComputePassAfterRenderPass workaround
tracks when a known buggy case occurs on Qualcomm devices and splits
the commands buffer in two while recording to force a needed
synchronization. However, Dawn combines separate command buffers sent
as part of the same submit as an optimization, and the necessary state
was not tracked across those combined command buffers.

By moving the state up to the CommandRecordingContext we ensure that
command buffers can be split up appropriately even when the commands
that trigger that condition occured in separate Dawn-level command
buffers.

Bug: 1896
Change-Id: Ifed5ecaa91b6d683cd4332cc534af10aecd217a1
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/157921
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Brandon Jones <bajones@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
3 files changed
tree: f97f2d81eacb025385165206913162efb37a43b2
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. scripts/
  8. src/
  9. test/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. build
  14. buildtools
  15. testing
  16. .bazelrc
  17. .clang-format
  18. .clang-tidy
  19. .gitattributes
  20. .gitignore
  21. .gitmodules
  22. .gn
  23. AUTHORS
  24. BUILD.bazel
  25. BUILD.gn
  26. CMakeLists.txt
  27. CMakeSettings.json
  28. CODE_OF_CONDUCT.md
  29. codereview.settings
  30. CONTRIBUTING.md
  31. CPPLINT.cfg
  32. dawn.json
  33. dawn_wire.json
  34. DEPS
  35. DIR_METADATA
  36. Doxyfile
  37. go.mod
  38. go.sum
  39. go_presubmit_support.py
  40. LICENSE
  41. OWNERS
  42. PRESUBMIT.py
  43. README.chromium
  44. README.md
  45. WORKSPACE.bazel
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.