commit cfbc4225a50be12b03627aabcac8d3580a527350
author Yunchao He <yunchao.he@intel.com> Fri Jul 16 20:12:27 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 16 20:12:27 2021 +0000
tree 4148e99ad9093aa23a54803f86109ae3a7fe591d
parent 83241616ae237e06b5d1b139783d88fce08d8231

Texture::GetTextureViewDescriptorWithDefaults: fix incorrect UNREACHABLE()

Bug: chromium:1230062

Change-Id: I3ff2638724d09079106ed048464d2640e206512e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/58500
Commit-Queue: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

src/dawn_native/Texture.cpp

diff --git a/src/dawn_native/Texture.cpp b/src/dawn_native/Texture.cpp
index 8d6bc55..ebbabb7 100644
--- a/src/dawn_native/Texture.cpp
+++ b/src/dawn_native/Texture.cpp
@@ -390,7 +390,9 @@
                     desc.arrayLayerCount = texture->GetArrayLayers() - desc.baseArrayLayer;
                     break;
                 default:
-                    UNREACHABLE();
+                    // We don't put UNREACHABLE() here because we validate enums only after this
+                    // function sets default values. Otherwise, the UNREACHABLE() will be hit.
+                    break;
             }
         }
         if (desc.mipLevelCount == 0) {