Google Git
Sign in
dawn / dawn / d07a2002494ccc6ece8bbeb13814d3d98e4ab75c
commitd07a2002494ccc6ece8bbeb13814d3d98e4ab75c[log] [tgz]
authorJames Price <jrprice@google.com>Wed Apr 24 21:15:09 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 24 21:15:09 2024 +0000
tree11c532c7e531306aa0d51586c617e187ed508d1a
parent4f491bf8c370e4975672b3f5abd0f1de4a95f12e [diff]
[spirv] Fix dynamic indexes into constant arrays

When a constant array was dynamically indexed from multiple functions,
the VarForDynamicIndex transform was adding a function-scope copy of
the array to one function and then trying to use it from the other
functions. This CL changes the transform to use module-scope variables
for constant array indexing instead.

A similar problem exists for non-constant arrays that are indexed from
multiple blocks. This is fixed here by moving the function-scope
declaration to the earliest point that is immediately after the
definition of the array value. A new helper is added to the IR builder
to determine the correct insertion point depending on the kind of
value we are inserting after (instruction result, function parameter,
or block parameter).

Fixed: tint:2237
Change-Id: Ib7d9c3ae7f83939c0270c8da6ce6c29994b88de5
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/185525
Commit-Queue: James Price <jrprice@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
11 files changed
tree: 11c532c7e531306aa0d51586c617e187ed508d1a
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.