Implement RenderPassEncoder::SetViewport: add end2end tests
The main aim of this CL is to add tests for SetViewport. But it
also implements the feature on Vulkan backend to verify the tests.
BUG=dawn:53
TEST=dawn_end2end_tests
Change-Id: I9578b2d9650cb952ce67cf91f79e9682c9932ee3
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/8820
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Yunchao He <yunchao.he@intel.com>
diff --git a/BUILD.gn b/BUILD.gn
index b96ea37..2e31a90 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -687,6 +687,7 @@
"src/tests/end2end/VertexFormatTests.cpp",
"src/tests/end2end/VertexInputTests.cpp",
"src/tests/end2end/ViewportOrientationTests.cpp",
+ "src/tests/end2end/ViewportTests.cpp",
]
libs = []
diff --git a/src/dawn_native/vulkan/CommandBufferVk.cpp b/src/dawn_native/vulkan/CommandBufferVk.cpp
index 0513363..8f1afa3 100644
--- a/src/dawn_native/vulkan/CommandBufferVk.cpp
+++ b/src/dawn_native/vulkan/CommandBufferVk.cpp
@@ -743,6 +743,19 @@
cmd->reference);
} break;
+ case Command::SetViewport: {
+ SetViewportCmd* cmd = mCommands.NextCommand<SetViewportCmd>();
+ VkViewport viewport;
+ viewport.x = cmd->x;
+ viewport.y = cmd->y;
+ viewport.width = cmd->width;
+ viewport.height = cmd->height;
+ viewport.minDepth = cmd->minDepth;
+ viewport.maxDepth = cmd->maxDepth;
+
+ device->fn.CmdSetViewport(commands, 0, 1, &viewport);
+ } break;
+
case Command::SetScissorRect: {
SetScissorRectCmd* cmd = mCommands.NextCommand<SetScissorRectCmd>();
VkRect2D rect;
diff --git a/src/tests/end2end/ViewportTests.cpp b/src/tests/end2end/ViewportTests.cpp
new file mode 100644
index 0000000..3860f95
--- /dev/null
+++ b/src/tests/end2end/ViewportTests.cpp
@@ -0,0 +1,328 @@
+// Copyright 2019 The Dawn Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "tests/DawnTest.h"
+
+#include "utils/ComboRenderPipelineDescriptor.h"
+#include "utils/DawnHelpers.h"
+
+class ViewportTest : public DawnTest {
+ protected:
+ dawn::RenderPipeline CreatePipelineForTest() {
+ utils::ComboRenderPipelineDescriptor pipelineDescriptor(device);
+
+ // Draw two triangles:
+ // 1. The top-left triangle is red. Its depth values are >= 0.5. After viewport is applied,
+ // the depth might be >= 0.25 if minDepth is 0 and maxDepth is 0.5.
+ // 2. The bottom-right triangle is green. Its depth values are <= 0.5. After viewport is
+ // applied, the depth might be <= 0.25 if minDepth is 0 and maxDepth is 0.5.
+ const char* vs =
+ R"(#version 450
+ layout(location = 0) out vec4 color;
+ const vec3 pos[6] = vec3[6](vec3(-1.0f, -1.0f, 1.0f),
+ vec3(-1.0f, 1.0f, 0.5f),
+ vec3( 1.0f, -1.0f, 0.5f),
+ vec3( 1.0f, -1.0f, 0.5f),
+ vec3(-1.0f, 1.0f, 0.5f),
+ vec3( 1.0f, 1.0f, 0.0f));
+ void main() {
+ gl_Position = vec4(pos[gl_VertexIndex], 1.0);
+ if (gl_VertexIndex < 3) {
+ color = vec4(1.0, 0.0, 0.0, 1.0);
+ } else {
+ color = vec4(0.0, 1.0, 0.0, 1.0);
+ }
+ })";
+ pipelineDescriptor.cVertexStage.module =
+ utils::CreateShaderModule(device, utils::ShaderStage::Vertex, vs);
+
+ const char* fs =
+ R"(#version 450
+ layout(location = 0) in vec4 color;
+ layout(location = 0) out vec4 fragColor;
+ void main() {
+ fragColor = color;
+ })";
+ pipelineDescriptor.cFragmentStage.module =
+ utils::CreateShaderModule(device, utils::ShaderStage::Fragment, fs);
+
+ pipelineDescriptor.cDepthStencilState.depthCompare = dawn::CompareFunction::Less;
+ pipelineDescriptor.depthStencilState = &pipelineDescriptor.cDepthStencilState;
+
+ return device.CreateRenderPipeline(&pipelineDescriptor);
+ }
+
+ dawn::Texture Create2DTextureForTest(dawn::TextureFormat format) {
+ dawn::TextureDescriptor textureDescriptor;
+ textureDescriptor.dimension = dawn::TextureDimension::e2D;
+ textureDescriptor.format = format;
+ textureDescriptor.usage =
+ dawn::TextureUsageBit::OutputAttachment | dawn::TextureUsageBit::CopySrc;
+ textureDescriptor.arrayLayerCount = 1;
+ textureDescriptor.mipLevelCount = 1;
+ textureDescriptor.sampleCount = 1;
+ textureDescriptor.size = {kSize, kSize, 1};
+ return device.CreateTexture(&textureDescriptor);
+ }
+
+ enum ColorType {
+ TopLeftTriangleColor,
+ BottomRightTriangleColor,
+ BackgroundColor,
+
+ ColorTypeCount,
+ };
+
+ struct ViewportParams {
+ float x, y, width, height, minDepth, maxDepth;
+ };
+
+ struct TestInfo {
+ ViewportParams viewport;
+ ColorType topLeftPoint;
+ ColorType bottomRightPoint;
+ float clearDepth = 1.0f;
+ bool setViewport = true;
+ };
+
+ void DoTest(const TestInfo& info) {
+ dawn::Texture colorTexture = Create2DTextureForTest(dawn::TextureFormat::RGBA8Unorm);
+ dawn::Texture depthStencilTexture =
+ Create2DTextureForTest(dawn::TextureFormat::Depth24PlusStencil8);
+
+ utils::ComboRenderPassDescriptor renderPassDescriptor(
+ {colorTexture.CreateDefaultView()}, depthStencilTexture.CreateDefaultView());
+ renderPassDescriptor.cColorAttachmentsInfoPtr[0]->clearColor = {0.0, 0.0, 1.0, 1.0};
+ renderPassDescriptor.cColorAttachmentsInfoPtr[0]->loadOp = dawn::LoadOp::Clear;
+
+ renderPassDescriptor.cDepthStencilAttachmentInfo.clearDepth = info.clearDepth;
+ renderPassDescriptor.cDepthStencilAttachmentInfo.depthLoadOp = dawn::LoadOp::Clear;
+
+ dawn::CommandEncoder commandEncoder = device.CreateCommandEncoder();
+ dawn::RenderPassEncoder renderPass = commandEncoder.BeginRenderPass(&renderPassDescriptor);
+ renderPass.SetPipeline(CreatePipelineForTest());
+ if (info.setViewport) {
+ ViewportParams viewport = info.viewport;
+ renderPass.SetViewport(viewport.x, viewport.y, viewport.width, viewport.height,
+ viewport.minDepth, viewport.maxDepth);
+ }
+ renderPass.Draw(6, 1, 0, 0);
+ renderPass.EndPass();
+ dawn::CommandBuffer commandBuffer = commandEncoder.Finish();
+ dawn::Queue queue = device.CreateQueue();
+ queue.Submit(1, &commandBuffer);
+
+ constexpr RGBA8 kColor[ColorTypeCount] = {
+ RGBA8(255, 0, 0, 255), // top-left triangle is red
+ RGBA8(0, 255, 0, 255), // bottom-right triangle is green
+ RGBA8(0, 0, 255, 255), // background is blue
+ };
+
+ EXPECT_PIXEL_RGBA8_EQ(kColor[info.topLeftPoint], colorTexture, 0, 0);
+
+ EXPECT_PIXEL_RGBA8_EQ(kColor[info.bottomRightPoint], colorTexture, kSize - 1, kSize - 1);
+ }
+
+ static constexpr uint32_t kSize = 4;
+};
+
+// The viewport is the same size as the backbuffer if it is not explicitly specified. And minDepth
+// and maxDepth are 0.0 and 1.0 respectively. The viewport parameters below are not really used.
+// Point(0, 0) is covered by the top-left triangle. Likewise, point(3, 3) is covered by the
+// bottom-right triangle.
+TEST_P(ViewportTest, Default) {
+ ViewportParams viewport = {0.0, 0.0, 0.0, 0.0, 0.0, 0.0};
+ TestInfo info = {viewport, TopLeftTriangleColor, BottomRightTriangleColor, 1.0, false};
+ DoTest(info);
+}
+
+// Explicitly specify the viewport as its default value. The result is the same as it is in the test
+// above.
+TEST_P(ViewportTest, Basic) {
+ ViewportParams viewport = {0.0, 0.0, 4.0, 4.0, 0.0, 1.0};
+ TestInfo info = {viewport, TopLeftTriangleColor, BottomRightTriangleColor};
+ DoTest(info);
+}
+
+// Shift the viewport toward top-left by (2, 2). So the top-left triangle is outside of the back
+// buffer. We can't see it. And point(0, 0) is covered by the bottom-right triangle now. Point(3, 3)
+// is not covered by any triangles.
+TEST_P(ViewportTest, ShiftToTopLeft) {
+ ViewportParams viewport = {-2.0, -2.0, 4.0, 4.0, 0.0, 1.0};
+ TestInfo info = {viewport, BottomRightTriangleColor, BackgroundColor};
+ DoTest(info);
+}
+
+// Shift the viewport toward bottom-right by (2, 2). So Point(0, 0) is not covered by any triangles.
+// The top-left triangle is moved to the bottom-right of back buffer. Point(3, 3) is covered by it.
+// While the bottom-right triangle is moved outside of back buffer now.
+TEST_P(ViewportTest, ShiftToBottomRight) {
+ ViewportParams viewport = {2.0, 2.0, 4.0, 4.0, 0.0, 1.0};
+ TestInfo info = {viewport, BackgroundColor, TopLeftTriangleColor};
+ DoTest(info);
+}
+
+// After applying the minDepth/maxDepth value in viewport and projecting to framebuffer coordinate,
+// depth values of the top-left triangle are >= 0.25. They are greater than the depth values in
+// depth buffer, so it is not drawn at all. As a result, point(0, 0) is not covered by any
+// triangles. But the bottom-right triangle is drawn as usual.
+TEST_P(ViewportTest, ApplyDepth) {
+ ViewportParams viewport = {0.0, 0.0, 4.0, 4.0, 0.0, 0.5};
+ TestInfo info = {viewport, BackgroundColor, BottomRightTriangleColor, 0.25};
+ DoTest(info);
+}
+
+// Shift the viewport toward top-left by (2, 2). So the top-left triangle is outside of the back
+// buffer. We can't see it. And point(0, 0) is covered by the bottom-right triangle now. Its depth
+// value is < 0.25. So it is drawn as usual. Point(3, 3) is not covered by any triangles.
+TEST_P(ViewportTest, ShiftToTopLeftAndApplyDepth) {
+ // Test failing on Linux Vulkan Intel.
+ // See https://bugs.chromium.org/p/dawn/issues/detail?id=187
+ DAWN_SKIP_TEST_IF(IsLinux() && IsVulkan() && IsIntel());
+
+ ViewportParams viewport = {-2.0, -2.0, 4.0, 4.0, 0.0, 0.5};
+ TestInfo info = {viewport, BottomRightTriangleColor, BackgroundColor, 0.25};
+ DoTest(info);
+}
+
+// Shift the viewport toward bottom-right by (2, 2). So point(0, 0) is not covered by any triangles.
+// The top-left triangle is moved to the bottom-right of back buffer. However, depth values of the
+// top-left triangle are >= 0.25. They are greater than the depth values in depth buffer, so it is
+// not drawn at all. So point(3, 3) is not covered by any triangle, either.
+TEST_P(ViewportTest, ShiftToBottomRightAndApplyDepth) {
+ ViewportParams viewport = {2.0, 2.0, 4.0, 4.0, 0.0, 0.5};
+ TestInfo info = {viewport, BackgroundColor, BackgroundColor, 0.25};
+ DoTest(info);
+}
+
+// Enlarge the viewport by 2 times. So the entire back buffer is covered by the top-left triangle.
+TEST_P(ViewportTest, EnlargeViewport) {
+ ViewportParams viewport = {0.0, 0.0, 8.0, 8.0, 0.0, 1.0};
+ TestInfo info = {viewport, TopLeftTriangleColor, TopLeftTriangleColor};
+ DoTest(info);
+}
+
+// Enlarge the viewport by 2 times and shift toward top-left by (2, 2). back buffer sits exactly
+// at the center of the whole viewport. So, point(0, 0) is covered by the top-left triangle, and
+// point(3, 3) is covered by the bottom-right triangle.
+TEST_P(ViewportTest, EnlargeViewportAndShiftToTopLeft) {
+ ViewportParams viewport = {-2.0, -2.0, 8.0, 8.0, 0.0, 1.0};
+ TestInfo info = {viewport, TopLeftTriangleColor, BottomRightTriangleColor};
+ DoTest(info);
+}
+
+// Enlarge the viewport by 2 times and shift toward bottom-right by (2, 2). Point(0, 0) is not
+// covered by any triangle. Point(3, 3) is covered by the top-left triangle.
+TEST_P(ViewportTest, EnlargeViewportAndShiftToBottomRight) {
+ ViewportParams viewport = {2.0, 2.0, 8.0, 8.0, 0.0, 1.0};
+ TestInfo info = {viewport, BackgroundColor, TopLeftTriangleColor};
+ DoTest(info);
+}
+
+// Enlarge the viewport by 2 times. So the entire back buffer tend to be covered by the top-left
+// triangle. However, depth values of the top-left triangle are >= 0.25. They are greater than the
+// depth values in depth buffer, so the top-left triangle is not drawn at all. As a result, neither
+// point(0, 0) nor point(3, 3) is covered by any triangles.
+TEST_P(ViewportTest, EnlargeViewportAndApplyDepth) {
+ ViewportParams viewport = {0.0, 0.0, 8.0, 8.0, 0.0, 0.5};
+ TestInfo info = {viewport, BackgroundColor, BackgroundColor, 0.25};
+ DoTest(info);
+}
+
+// Enlarge the viewport by 2 times and shift toward top-left by (2, 2). The back buffer sits exactly
+// at the center of the whole viewport. However, depth values of the top-left triangle are >= 0.25.
+// They are greater than the depth values in depth buffer, so the top-left triangle is not drawn at
+// all. As a result, point(0, 0) is not covered by it. The bottom-right triangle is drawn because
+// its depth values are < 0.25. So point(3, 3) is covered by it as usual.
+TEST_P(ViewportTest, EnlargeViewportAndShiftToTopLeftAndApplyDepth) {
+ // Test failing on Linux Vulkan Intel.
+ // See https://bugs.chromium.org/p/dawn/issues/detail?id=187
+ DAWN_SKIP_TEST_IF(IsLinux() && IsVulkan() && IsIntel());
+
+ ViewportParams viewport = {-2.0, -2.0, 8.0, 8.0, 0.0, 0.5};
+ TestInfo info = {viewport, BackgroundColor, BottomRightTriangleColor, 0.25};
+ DoTest(info);
+}
+
+// Enlarge the viewport by 2 times and shift toward bottom-right by (2, 2). Point(0, 0) is not
+// covered by any triangle. The point(3, 3) tend to be covered by the top-left triangle. However,
+// depth values of the top-left triangle are >= 0.25. They are greater than the depth values in
+// depth buffer, so the top-left triangle is not drawn at all. As a result, point(3, 3) is not
+// covered by any triangle, either.
+TEST_P(ViewportTest, EnlargeViewportAndShiftToBottomRightAndApplyDepth) {
+ ViewportParams viewport = {2.0, 2.0, 8.0, 8.0, 0.0, 0.5};
+ TestInfo info = {viewport, BackgroundColor, BackgroundColor, 0.25};
+ DoTest(info);
+}
+
+// Shrink the viewport to its half. So point(0, 0) is covered by the top-left triangle, while
+// point(3, 3) is not covered by any triangles because the drawing area is too small to cover the
+// entire back buffer.
+TEST_P(ViewportTest, ShrinkViewport) {
+ ViewportParams viewport = {0.0, 0.0, 2.0, 2.0, 0.0, 1.0};
+ TestInfo info = {viewport, TopLeftTriangleColor, BackgroundColor};
+ DoTest(info);
+}
+
+// Shrink the viewport to its half and move toward top-left by (1, 1), So point(0, 0) is covered by
+// bottom-right triangle, while point(3, 3) is not covered by any triangles.
+TEST_P(ViewportTest, ShrinkViewportAndShiftToTopLeft) {
+ ViewportParams viewport = {-1.0, -1.0, 2.0, 2.0, 0.0, 1.0};
+ TestInfo info = {viewport, BottomRightTriangleColor, BackgroundColor};
+ DoTest(info);
+}
+
+// Shrink the viewport to its half and move toward bottom-right by (3, 3), So point(0, 0) is not
+// covered by any triangles, and point(3, 3) is covered by the bottom-right triangle.
+TEST_P(ViewportTest, ShrinkViewportAndShiftToBottomRight) {
+ ViewportParams viewport = {3.0, 3.0, 2.0, 2.0, 0.0, 1.0};
+ TestInfo info = {viewport, BackgroundColor, TopLeftTriangleColor};
+ DoTest(info);
+}
+
+// Shrink the viewport to its half. So point(0, 0) is tend to be covered by top-left triangle.
+// However, depth values of the top-left triangle are >= 0.25. They are greater than the depth
+// values in depth buffer, so the top-left triangle is not drawn at all. As a result, point(0, 0)
+// is not covered by any triangle. Point(3, 3) is not covered by any triangles, either. Because the
+// drawing area is too small to cover the entire back buffer.
+TEST_P(ViewportTest, ShrinkViewportAndApplyDepth) {
+ ViewportParams viewport = {0.0, 0.0, 2.0, 2.0, 0.0, 0.5};
+ TestInfo info = {viewport, BackgroundColor, BackgroundColor, 0.25};
+ DoTest(info);
+}
+
+// Shrink the viewport to its half and move toward top-left by (1, 1), So point(0, 0) is covered by
+// the bottom-right triangle, while point(3, 3) is not covered by any triangles.
+TEST_P(ViewportTest, ShrinkViewportAndShiftToTopLeftAndApplyDepth) {
+ // Test failing on Linux Vulkan Intel.
+ // See https://bugs.chromium.org/p/dawn/issues/detail?id=187
+ DAWN_SKIP_TEST_IF(IsLinux() && IsVulkan() && IsIntel());
+
+ ViewportParams viewport = {-1.0, -1.0, 2.0, 2.0, 0.0, 0.5};
+ TestInfo info = {viewport, BottomRightTriangleColor, BackgroundColor, 0.25};
+ DoTest(info);
+}
+
+// Shrink the viewport to its half and move toward bottom-right by (3, 3), So point(0, 0) is not
+// covered by any triangle. Point(3, 3) is tend to be covered by the top-left triangle. However,
+// depth values of the top-left triangle are >= 0.25. They are greater than the depth values in
+// depth buffer, so the top-left triangle is not drawn at all. As a result, point(3, 3) is not
+// covered by any triangle, either.
+TEST_P(ViewportTest, ShrinkViewportAndShiftToBottomRightAndApplyDepth) {
+ ViewportParams viewport = {3.0, 3.0, 2.0, 2.0, 0.0, 0.5};
+ TestInfo info = {viewport, BackgroundColor, BackgroundColor, 0.25};
+ DoTest(info);
+}
+
+DAWN_INSTANTIATE_TEST(ViewportTest, VulkanBackend);
