Google Git
Sign in
dawn / dawn / d75d28323145cab6a495ddf0becb7078bb75d050
commitd75d28323145cab6a495ddf0becb7078bb75d050[log] [tgz]
authorBen Clayton <bclayton@google.com>Fri Feb 02 15:00:55 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 02 15:00:55 2024 +0000
tree74e71e22e002607b29658d87b50bf8b9e3d744ca
parenta8d384efca6fdf1d7b542e9e30900fe3a12346f5 [diff]
[tools][cts] Fix tree root calculations

addNewExpectations() attempts to find all the 'root nodes' across
all the variants. These are the points for each variant where we'd put
an expectation. We collect all these root nodes across all the variants,
before building the new expectations.

The logic to do this used the query.Tree.Split() method, documented as:
"Split adds a new data to the tree, clearing any ancestor node's data."

This is not the right method for building the root tree. Consider:

Variant A has failing cases 'a:b,c:d:x,*' and 'a:b,c:d:y,*'
Variant B has failing cases 'a:b,c:d:x,*' ('a:b,c:d:y,*' pass)

Variant A adds the root node:      'a:b,c:d:*'
Variant B then adds the root node: 'a:b,c:d:x,*'

'a:b,c:d:x,*' is a descendant of 'a:b,c:d:*', so the root node for
variant A gets removed, and we don't end up emitting the expectations for Variant A's 'a:b,c:d:y,*'.

To fix this, use query.Tree.Add(). This results in the root node tree
potentially having multiple nodes along a query, but overlaps are
already handled with expectationsForRoot(), so this is fine.

Fixed: tint:2384
Change-Id: Ibeb244940885faa4b093b9039fa466681a5aa560
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/172840
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Ben Clayton <bclayton@google.com>
3 files changed
tree: 74e71e22e002607b29658d87b50bf8b9e3d744ca
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. Doxyfile
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.