commit db368f1b9c310873f1194a18deac890f44de81b3
author Ben Clayton <bclayton@google.com> Tue Oct 11 18:26:18 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Oct 11 18:26:18 2022 +0000
tree 71ddcf9e5dc86d9ed0506d1a8a8590c08304a5cd
parent ae832a2c6ae769593321ae5f8368c948f4727376

tools/tint/intrinsic: Sort enum values lexicographically

Reorders the output of the CanonicalizeEntryPointIO transform, but
otherwise is a no-op.

This will help with diagnostics that print the enum values.

Bug: tint:1629
Change-Id: Iff517d88836d2a8cd42ce3cfde6363c1973df0dd
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/105321
Commit-Queue: Ben Clayton <bclayton@chromium.org>
Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
Kokoro: Kokoro <noreply+kokoro@google.com>

src/tint/ast/builtin_value_test.cc

diff --git a/src/tint/ast/builtin_value_test.cc b/src/tint/ast/builtin_value_test.cc
index a29810a..55f8e4d 100644
--- a/src/tint/ast/builtin_value_test.cc
+++ b/src/tint/ast/builtin_value_test.cc
@@ -42,57 +42,57 @@
 }
 
 static constexpr Case kValidCases[] = {
-    {"position", BuiltinValue::kPosition},
-    {"vertex_index", BuiltinValue::kVertexIndex},
-    {"instance_index", BuiltinValue::kInstanceIndex},
-    {"front_facing", BuiltinValue::kFrontFacing},
     {"frag_depth", BuiltinValue::kFragDepth},
+    {"front_facing", BuiltinValue::kFrontFacing},
+    {"global_invocation_id", BuiltinValue::kGlobalInvocationId},
+    {"instance_index", BuiltinValue::kInstanceIndex},
     {"local_invocation_id", BuiltinValue::kLocalInvocationId},
     {"local_invocation_index", BuiltinValue::kLocalInvocationIndex},
-    {"global_invocation_id", BuiltinValue::kGlobalInvocationId},
-    {"workgroup_id", BuiltinValue::kWorkgroupId},
     {"num_workgroups", BuiltinValue::kNumWorkgroups},
+    {"position", BuiltinValue::kPosition},
     {"sample_index", BuiltinValue::kSampleIndex},
     {"sample_mask", BuiltinValue::kSampleMask},
+    {"vertex_index", BuiltinValue::kVertexIndex},
+    {"workgroup_id", BuiltinValue::kWorkgroupId},
 };
 
 static constexpr Case kInvalidCases[] = {
-    {"pccsitin", BuiltinValue::kInvalid},
-    {"oiti3", BuiltinValue::kInvalid},
-    {"positVon", BuiltinValue::kInvalid},
-    {"1ertex_index", BuiltinValue::kInvalid},
-    {"vertex_Jnqex", BuiltinValue::kInvalid},
-    {"velltex_inde77", BuiltinValue::kInvalid},
-    {"inpptanceqHHindx", BuiltinValue::kInvalid},
-    {"cnsanvendex", BuiltinValue::kInvalid},
-    {"istancG_index", BuiltinValue::kInvalid},
-    {"front_facvnii", BuiltinValue::kInvalid},
-    {"frWWnt_faci8g", BuiltinValue::kInvalid},
-    {"fxxonM_facig", BuiltinValue::kInvalid},
-    {"fXag_detgg", BuiltinValue::kInvalid},
-    {"fag_XuVh", BuiltinValue::kInvalid},
-    {"frag_dept3", BuiltinValue::kInvalid},
-    {"local_Envocation_id", BuiltinValue::kInvalid},
-    {"localiPPvocatioTT_id", BuiltinValue::kInvalid},
-    {"localxxnvocationddid", BuiltinValue::kInvalid},
-    {"loca44_invocation_index", BuiltinValue::kInvalid},
-    {"local_invocSStionVVindex", BuiltinValue::kInvalid},
-    {"locRR_invocat22n_index", BuiltinValue::kInvalid},
-    {"globalFinvoction_id", BuiltinValue::kInvalid},
-    {"gloal_invocation_id", BuiltinValue::kInvalid},
-    {"RRlHOOaV_invoction_id", BuiltinValue::kInvalid},
-    {"workgyoup_i", BuiltinValue::kInvalid},
-    {"wnrrrkg77loup_Gd", BuiltinValue::kInvalid},
-    {"00orkgr4up_id", BuiltinValue::kInvalid},
-    {"numwroogrops", BuiltinValue::kInvalid},
-    {"nzm_wokgroups", BuiltinValue::kInvalid},
-    {"uippworkgro11ps", BuiltinValue::kInvalid},
-    {"sample_iXXdex", BuiltinValue::kInvalid},
-    {"5nnample_99IIdex", BuiltinValue::kInvalid},
-    {"samYlaaHHrrndeSS", BuiltinValue::kInvalid},
-    {"aHkk_mask", BuiltinValue::kInvalid},
-    {"jRRmpl_gsk", BuiltinValue::kInvalid},
-    {"smple_mbk", BuiltinValue::kInvalid},
+    {"fragdeccth", BuiltinValue::kInvalid},
+    {"flaget3", BuiltinValue::kInvalid},
+    {"fVag_depth", BuiltinValue::kInvalid},
+    {"1ront_facing", BuiltinValue::kInvalid},
+    {"front_fJcqng", BuiltinValue::kInvalid},
+    {"frllnt_facin77", BuiltinValue::kInvalid},
+    {"global_invoqqtionppHid", BuiltinValue::kInvalid},
+    {"clvbal_inocaionid", BuiltinValue::kInvalid},
+    {"global_Gvocation_id", BuiltinValue::kInvalid},
+    {"invtance_iniiex", BuiltinValue::kInvalid},
+    {"8nstanceWWindex", BuiltinValue::kInvalid},
+    {"insxxanceindex", BuiltinValue::kInvalid},
+    {"lXcal_invoation_igg", BuiltinValue::kInvalid},
+    {"Xocal_nvocatin_Vd", BuiltinValue::kInvalid},
+    {"local_invoca3ion_id", BuiltinValue::kInvalid},
+    {"local_invocation_indeE", BuiltinValue::kInvalid},
+    {"loTTal_invPPcatin_index", BuiltinValue::kInvalid},
+    {"loal_invocadxxion_index", BuiltinValue::kInvalid},
+    {"num_work44roups", BuiltinValue::kInvalid},
+    {"num_wVVrkgSSoups", BuiltinValue::kInvalid},
+    {"Rum_wokgrou2Rs", BuiltinValue::kInvalid},
+    {"oFi9ion", BuiltinValue::kInvalid},
+    {"postion", BuiltinValue::kInvalid},
+    {"ROOoHiiVn", BuiltinValue::kInvalid},
+    {"samply_inde", BuiltinValue::kInvalid},
+    {"snrrmpl77l_indGx", BuiltinValue::kInvalid},
+    {"00ample4index", BuiltinValue::kInvalid},
+    {"smoo_mask", BuiltinValue::kInvalid},
+    {"sampzemask", BuiltinValue::kInvalid},
+    {"ppaplii1_mas", BuiltinValue::kInvalid},
+    {"vertex_iXXdex", BuiltinValue::kInvalid},
+    {"5nnertex_99IIdex", BuiltinValue::kInvalid},
+    {"verYeaaHHrrndeSS", BuiltinValue::kInvalid},
+    {"workkgHo_i", BuiltinValue::kInvalid},
+    {"worRgoupjid", BuiltinValue::kInvalid},
+    {"wrkgrupbid", BuiltinValue::kInvalid},
 };
 
 using BuiltinValueParseTest = testing::TestWithParam<Case>;