Google Git
Sign in
dawn / dawn / e249898ed9834b88f54202fcbf1c0cbe0835f76d
commite249898ed9834b88f54202fcbf1c0cbe0835f76d[log] [tgz]
authorKyle Charbonneau <kylechar@google.com>Thu Oct 31 17:48:45 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 31 17:48:45 2024 +0000
tree5b50d28f35ee1f7cc3f2efaf30ecd634d9d6d9d3
parentefed88f512126582b9df364ff0301c1088782276 [diff]
Give DescriptorSetAllocator a mutex

There are memory corruption crashes inside DescriptorSetAllocator with
Android Graphite/Dawn/Vulkan. The class is accessed with MutexProtected
from BindGroupLayoutVk but not from DeviceVk so concurrent access to
member variables on different threads seems possible. Since the class is
reference counted move the mutex inside the class so that calling a
method on any reference is thread safe.

Bug: 368362677
Change-Id: I7ca400555261c75995431d4a4023a571747961ee
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/212774
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@google.com>
3 files changed
tree: 5b50d28f35ee1f7cc3f2efaf30ecd634d9d6d9d3
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.