Track error command encoders on the device in Dawn.

- Currently, attachment states are not directly destroyed by
  Device::Destroy, and are instead assumed to be cleaned up when we
  destroy all other device tracked objects. This was a problem because
  error command encoders are NOT tracked by the device, but can hold
  references to attachment states (since they pretend to work). That
  means that when the last reference to a device was dropped before
  the last reference of the error command encoder, any attachment state
  help by the encoder cannot uncache itself from the device frontend
  cache before the device was gone.

Bug: chromium:1487788
Change-Id: I713d1b8d17464250231f8eb83181e5c71d34c4f2
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/155981
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Loko Kung <lokokung@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
2 files changed
tree: 565a52a08c27d32d737c4eb38e3dcc72bf35cbea
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. scripts/
  8. src/
  9. test/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. .bazelrc
  14. .clang-format
  15. .clang-tidy
  16. .gitattributes
  17. .gitignore
  18. .gitmodules
  19. .gn
  20. AUTHORS
  21. BUILD.bazel
  22. BUILD.gn
  23. CMakeLists.txt
  24. CMakeSettings.json
  25. CODE_OF_CONDUCT.md
  26. codereview.settings
  27. CONTRIBUTING.md
  28. CPPLINT.cfg
  29. dawn.json
  30. dawn_wire.json
  31. DEPS
  32. DIR_METADATA
  33. Doxyfile
  34. go.mod
  35. go.sum
  36. go_presubmit_support.py
  37. LICENSE
  38. OWNERS
  39. PRESUBMIT.py
  40. README.chromium
  41. README.md
  42. WORKSPACE.bazel
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

Apache 2.0 Public License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.