| // Copyright 2022 The Dawn & Tint Authors |
| // |
| // Redistribution and use in source and binary forms, with or without |
| // modification, are permitted provided that the following conditions are met: |
| // |
| // 1. Redistributions of source code must retain the above copyright notice, this |
| // list of conditions and the following disclaimer. |
| // |
| // 2. Redistributions in binary form must reproduce the above copyright notice, |
| // this list of conditions and the following disclaimer in the documentation |
| // and/or other materials provided with the distribution. |
| // |
| // 3. Neither the name of the copyright holder nor the names of its |
| // contributors may be used to endorse or promote products derived from |
| // this software without specific prior written permission. |
| // |
| // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" |
| // AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE |
| // IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE |
| // DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE |
| // FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL |
| // DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR |
| // SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER |
| // CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, |
| // OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| |
| // GEN_BUILD:CONDITION(tint_build_wgsl_reader) |
| |
| #include <memory> |
| #include <string> |
| #include <tuple> |
| #include <utility> |
| |
| #include "src/tint/lang/wgsl/program/program_builder.h" |
| #include "src/tint/lang/wgsl/reader/reader.h" |
| #include "src/tint/lang/wgsl/resolver/resolve.h" |
| #include "src/tint/lang/wgsl/resolver/uniformity.h" |
| #include "src/tint/utils/text/string_stream.h" |
| |
| #include "gmock/gmock.h" |
| #include "gtest/gtest.h" |
| |
| namespace tint::resolver { |
| namespace { |
| |
| using namespace tint::core::fluent_types; // NOLINT |
| using namespace tint::core::number_suffixes; // NOLINT |
| |
| class UniformityAnalysisTestBase { |
| protected: |
| /// Build and resolve a program from a ProgramBuilder object. |
| /// @param program the program |
| /// @param should_pass true if `builder` program should pass the analysis, otherwise false |
| void RunTest(Program&& program, bool should_pass) { |
| error_ = program.Diagnostics().str(); |
| |
| bool valid = program.IsValid(); |
| if (should_pass) { |
| EXPECT_TRUE(valid) << error_; |
| EXPECT_FALSE(program.Diagnostics().contains_errors()); |
| } else { |
| if (kUniformityFailuresAsError) { |
| EXPECT_FALSE(valid); |
| } else { |
| EXPECT_TRUE(valid) << error_; |
| } |
| } |
| } |
| |
| /// Parse and resolve a WGSL shader. |
| /// @param src the WGSL source code |
| /// @param should_pass true if `src` should pass the analysis, otherwise false |
| void RunTest(std::string src, bool should_pass) { |
| wgsl::reader::Options options; |
| options.allowed_features = wgsl::AllowedFeatures::Everything(); |
| auto file = std::make_unique<Source::File>("test", src); |
| auto program = wgsl::reader::Parse(file.get(), options); |
| return RunTest(std::move(program), should_pass); |
| } |
| |
| /// Build and resolve a program from a ProgramBuilder object. |
| /// @param builder the program builder |
| /// @param should_pass true if `builder` program should pass the analysis, otherwise false |
| void RunTest(ProgramBuilder&& builder, bool should_pass) { |
| auto program = resolver::Resolve(builder); |
| return RunTest(std::move(program), should_pass); |
| } |
| |
| /// The error message from the parser or resolver, if any. |
| std::string error_; |
| }; |
| |
| class UniformityAnalysisTest : public UniformityAnalysisTestBase, public ::testing::Test {}; |
| |
| class BasicTest : public UniformityAnalysisTestBase, |
| public ::testing::TestWithParam<std::tuple<int, int>> { |
| public: |
| /// Enum for the if-statement condition guarding a function call. |
| enum Condition { |
| // Uniform conditions: |
| kTrue, |
| kFalse, |
| kLiteral, |
| kModuleConst, |
| kPipelineOverridable, |
| kFuncLetUniformRhs, |
| kFuncVarUniform, |
| kFuncUniformRetVal, |
| kUniformBuffer, |
| kROStorageBuffer, |
| kLastUniformCondition = kROStorageBuffer, |
| // MayBeNonUniform conditions: |
| kFuncLetNonUniformRhs, |
| kFuncVarNonUniform, |
| kFuncNonUniformRetVal, |
| kRWStorageBuffer, |
| // End of range marker: |
| kEndOfConditionRange, |
| }; |
| |
| /// Enum for the function call statement. |
| enum Function { |
| // NoRestrictionFunctions: |
| kUserNoRestriction, |
| kMin, |
| kTextureSampleLevel, |
| kLastNoRestrictionFunction = kTextureSampleLevel, |
| // RequiredToBeUniform functions: |
| kUserRequiredToBeUniform, |
| kWorkgroupBarrier, |
| kStorageBarrier, |
| kTextureBarrier, |
| kWorkgroupUniformLoad, |
| kTextureSample, |
| kTextureSampleBias, |
| kTextureSampleCompare, |
| kDpdx, |
| kDpdxCoarse, |
| kDpdxFine, |
| kDpdy, |
| kDpdyCoarse, |
| kDpdyFine, |
| kFwidth, |
| kFwidthCoarse, |
| kFwidthFine, |
| // End of range marker: |
| kEndOfFunctionRange, |
| }; |
| |
| /// Convert a condition to its string representation. |
| static std::string ConditionToStr(Condition c) { |
| switch (c) { |
| case kTrue: |
| return "true"; |
| case kFalse: |
| return "false"; |
| case kLiteral: |
| return "7 == 7"; |
| case kModuleConst: |
| return "module_const == 0"; |
| case kPipelineOverridable: |
| return "pipeline_overridable == 0"; |
| case kFuncLetUniformRhs: |
| return "let_uniform_rhs == 0"; |
| case kFuncVarUniform: |
| return "func_uniform == 0"; |
| case kFuncUniformRetVal: |
| return "func_uniform_retval() == 0"; |
| case kUniformBuffer: |
| return "u == 0"; |
| case kROStorageBuffer: |
| return "ro == 0"; |
| case kFuncLetNonUniformRhs: |
| return "let_nonuniform_rhs == 0"; |
| case kFuncVarNonUniform: |
| return "func_non_uniform == 0"; |
| case kFuncNonUniformRetVal: |
| return "func_nonuniform_retval() == 0"; |
| case kRWStorageBuffer: |
| return "rw == 0"; |
| case kEndOfConditionRange: |
| return "<invalid>"; |
| } |
| return "<invalid>"; |
| } |
| |
| /// Convert a function call to its string representation. |
| static std::string FunctionCallToStr(Function f) { |
| switch (f) { |
| case kUserNoRestriction: |
| return "user_no_restriction()"; |
| case kMin: |
| return "_ = min(1, 1)"; |
| case kTextureSampleLevel: |
| return "_ = textureSampleLevel(t, s, vec2(0.5, 0.5), 0.0)"; |
| case kUserRequiredToBeUniform: |
| return "user_required_to_be_uniform()"; |
| case kWorkgroupBarrier: |
| return "workgroupBarrier()"; |
| case kStorageBarrier: |
| return "storageBarrier()"; |
| case kTextureBarrier: |
| return "textureBarrier()"; |
| case kWorkgroupUniformLoad: |
| return "_ = workgroupUniformLoad(&w)"; |
| case kTextureSample: |
| return "_ = textureSample(t, s, vec2(0.5, 0.5))"; |
| case kTextureSampleBias: |
| return "_ = textureSampleBias(t, s, vec2(0.5, 0.5), 2.0)"; |
| case kTextureSampleCompare: |
| return "_ = textureSampleCompare(td, sc, vec2(0.5, 0.5), 0.5)"; |
| case kDpdx: |
| return "_ = dpdx(1.0)"; |
| case kDpdxCoarse: |
| return "_ = dpdxCoarse(1.0)"; |
| case kDpdxFine: |
| return "_ = dpdxFine(1.0)"; |
| case kDpdy: |
| return "_ = dpdy(1.0)"; |
| case kDpdyCoarse: |
| return "_ = dpdyCoarse(1.0)"; |
| case kDpdyFine: |
| return "_ = dpdyFine(1.0)"; |
| case kFwidth: |
| return "_ = fwidth(1.0)"; |
| case kFwidthCoarse: |
| return "_ = fwidthCoarse(1.0)"; |
| case kFwidthFine: |
| return "_ = fwidthFine(1.0)"; |
| case kEndOfFunctionRange: |
| return "<invalid>"; |
| } |
| return "<invalid>"; |
| } |
| |
| /// @returns true if `c` is a condition that may be non-uniform. |
| static bool MayBeNonUniform(Condition c) { return c > kLastUniformCondition; } |
| |
| /// @returns true if `f` is a function call that is required to be uniform. |
| static bool RequiredToBeUniform(Function f) { return f > kLastNoRestrictionFunction; } |
| |
| /// Convert a test parameter pair of condition+function to a string that can be used as part of |
| /// a test name. |
| static std::string ParamsToName(::testing::TestParamInfo<ParamType> params) { |
| Condition c = static_cast<Condition>(std::get<0>(params.param)); |
| Function f = static_cast<Function>(std::get<1>(params.param)); |
| std::string name; |
| #define CASE(c) \ |
| case c: \ |
| name += #c; \ |
| break |
| |
| switch (c) { |
| CASE(kTrue); |
| CASE(kFalse); |
| CASE(kLiteral); |
| CASE(kModuleConst); |
| CASE(kPipelineOverridable); |
| CASE(kFuncLetUniformRhs); |
| CASE(kFuncVarUniform); |
| CASE(kFuncUniformRetVal); |
| CASE(kUniformBuffer); |
| CASE(kROStorageBuffer); |
| CASE(kFuncLetNonUniformRhs); |
| CASE(kFuncVarNonUniform); |
| CASE(kFuncNonUniformRetVal); |
| CASE(kRWStorageBuffer); |
| case kEndOfConditionRange: |
| break; |
| } |
| name += "_"; |
| switch (f) { |
| CASE(kUserNoRestriction); |
| CASE(kMin); |
| CASE(kTextureSampleLevel); |
| CASE(kUserRequiredToBeUniform); |
| CASE(kWorkgroupBarrier); |
| CASE(kStorageBarrier); |
| CASE(kTextureBarrier); |
| CASE(kWorkgroupUniformLoad); |
| CASE(kTextureSample); |
| CASE(kTextureSampleBias); |
| CASE(kTextureSampleCompare); |
| CASE(kDpdx); |
| CASE(kDpdxCoarse); |
| CASE(kDpdxFine); |
| CASE(kDpdy); |
| CASE(kDpdyCoarse); |
| CASE(kDpdyFine); |
| CASE(kFwidth); |
| CASE(kFwidthCoarse); |
| CASE(kFwidthFine); |
| case kEndOfFunctionRange: |
| break; |
| } |
| #undef CASE |
| |
| return name; |
| } |
| }; |
| |
| // Test the uniformity constraints for a function call inside a conditional statement. |
| TEST_P(BasicTest, ConditionalFunctionCall) { |
| auto condition = static_cast<Condition>(std::get<0>(GetParam())); |
| auto function = static_cast<Function>(std::get<1>(GetParam())); |
| std::string src = R"( |
| enable chromium_experimental_read_write_storage_texture; |
| |
| var<private> p : i32; |
| var<workgroup> w : i32; |
| @group(0) @binding(0) var<uniform> u : i32; |
| @group(0) @binding(0) var<storage, read> ro : i32; |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| @group(1) @binding(0) var t : texture_2d<f32>; |
| @group(1) @binding(1) var td : texture_depth_2d; |
| @group(1) @binding(2) var s : sampler; |
| @group(1) @binding(3) var sc : sampler_comparison; |
| |
| const module_const : i32 = 42; |
| @id(42) override pipeline_overridable : i32; |
| |
| fn user_no_restriction() {} |
| fn user_required_to_be_uniform() { workgroupBarrier(); } |
| |
| fn func_uniform_retval() -> i32 { return u; } |
| fn func_nonuniform_retval() -> i32 { return rw; } |
| |
| fn foo() { |
| let let_uniform_rhs = 7; |
| let let_nonuniform_rhs = rw; |
| |
| var func_uniform = 7; |
| var func_non_uniform = 7; |
| func_non_uniform = rw; |
| |
| if ()" + ConditionToStr(condition) + |
| R"() { |
| )" + FunctionCallToStr(function) + |
| R"(; |
| } |
| } |
| )"; |
| |
| bool should_pass = !(MayBeNonUniform(condition) && RequiredToBeUniform(function)); |
| RunTest(src, should_pass); |
| if (!should_pass) { |
| EXPECT_THAT(error_, ::testing::HasSubstr("must only be called from uniform control flow")); |
| } |
| } |
| |
| INSTANTIATE_TEST_SUITE_P( |
| UniformityAnalysisTest, |
| BasicTest, |
| ::testing::Combine(::testing::Range<int>(0, BasicTest::kEndOfConditionRange), |
| ::testing::Range<int>(0, BasicTest::kEndOfFunctionRange)), |
| BasicTest::ParamsToName); |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// Test specific function and parameter tags that are not tested above. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| TEST_F(UniformityAnalysisTest, ParameterNoRestriction_Pass) { |
| // Pass a non-uniform value as an argument, and then try to use the return value for |
| // control-flow guarding a barrier. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| var<private> p : i32; |
| |
| fn foo(i : i32) -> i32 { |
| if (i == 0) { |
| // This assignment is non-uniform, but shouldn't affect the return value. |
| p = 42; |
| } |
| return 7; |
| } |
| |
| fn bar() { |
| let x = foo(rw); |
| if (x == 7) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ParameterRequiredToBeUniform_Pass) { |
| // Pass a uniform value as an argument to a function that uses that parameter for control-flow |
| // guarding a barrier. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> ro : i32; |
| |
| fn foo(i : i32) { |
| if (i == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn bar() { |
| foo(ro); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ParameterRequiredToBeUniform_Fail) { |
| // Pass a non-uniform value as an argument to a function that uses that parameter for |
| // control-flow guarding a barrier. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo(i : i32) { |
| if (i == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn bar() { |
| foo(rw); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (i == 0) { |
| ^^ |
| |
| test:5:7 note: parameter 'i' of 'foo' may be non-uniform |
| if (i == 0) { |
| ^ |
| |
| test:11:7 note: possibly non-uniform value passed here |
| foo(rw); |
| ^^ |
| |
| test:11:7 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| foo(rw); |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ParameterRequiredToBeUniformForReturnValue_Pass) { |
| // Pass a uniform value as an argument to a function that uses that parameter to produce the |
| // return value, and then use the return value for control-flow guarding a barrier. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> ro : i32; |
| |
| fn foo(i : i32) -> i32 { |
| return 1 + i; |
| } |
| |
| fn bar() { |
| if (foo(ro) == 7) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ParameterRequiredToBeUniformForReturnValue_Fail) { |
| // Pass a non-uniform value as an argument to a function that uses that parameter to produce the |
| // return value, and then use the return value for control-flow guarding a barrier. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo(i : i32) -> i32 { |
| return 1 + i; |
| } |
| |
| fn bar() { |
| if (foo(rw) == 7) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (foo(rw) == 7) { |
| ^^ |
| |
| test:9:11 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| if (foo(rw) == 7) { |
| ^^ |
| )"); |
| } |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// Test shader IO attributes. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| struct BuiltinEntry { |
| std::string name; |
| std::string type; |
| bool uniform; |
| BuiltinEntry(std::string n, std::string t, bool u) : name(n), type(t), uniform(u) {} |
| }; |
| |
| class ComputeBuiltin : public UniformityAnalysisTestBase, |
| public ::testing::TestWithParam<BuiltinEntry> {}; |
| TEST_P(ComputeBuiltin, AsParam) { |
| std::string src = R"( |
| @compute @workgroup_size(64) |
| fn main(@builtin()" + GetParam().name + |
| R"() b : )" + GetParam().type + R"() { |
| if (all(vec3(b) == vec3(0u))) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| bool should_pass = GetParam().uniform; |
| RunTest(src, should_pass); |
| if (!should_pass) { |
| EXPECT_EQ( |
| error_, |
| R"(test:5:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:4:3 note: control flow depends on possibly non-uniform value |
| if (all(vec3(b) == vec3(0u))) { |
| ^^ |
| |
| test:4:16 note: builtin 'b' of 'main' may be non-uniform |
| if (all(vec3(b) == vec3(0u))) { |
| ^ |
| )"); |
| } |
| } |
| |
| TEST_P(ComputeBuiltin, InStruct) { |
| std::string src = R"( |
| struct S { |
| @builtin()" + GetParam().name + |
| R"() b : )" + GetParam().type + R"( |
| } |
| |
| @compute @workgroup_size(64) |
| fn main(s : S) { |
| if (all(vec3(s.b) == vec3(0u))) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| bool should_pass = GetParam().uniform; |
| RunTest(src, should_pass); |
| if (!should_pass) { |
| EXPECT_EQ( |
| error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (all(vec3(s.b) == vec3(0u))) { |
| ^^ |
| |
| test:8:16 note: parameter 's' of 'main' may be non-uniform |
| if (all(vec3(s.b) == vec3(0u))) { |
| ^ |
| )"); |
| } |
| } |
| |
| INSTANTIATE_TEST_SUITE_P(UniformityAnalysisTest, |
| ComputeBuiltin, |
| ::testing::Values(BuiltinEntry{"local_invocation_id", "vec3<u32>", false}, |
| BuiltinEntry{"local_invocation_index", "u32", false}, |
| BuiltinEntry{"global_invocation_id", "vec3<u32>", false}, |
| BuiltinEntry{"workgroup_id", "vec3<u32>", true}, |
| BuiltinEntry{"num_workgroups", "vec3<u32>", true}), |
| [](const ::testing::TestParamInfo<ComputeBuiltin::ParamType>& p) { |
| return p.param.name; |
| }); |
| |
| TEST_F(UniformityAnalysisTest, ComputeBuiltin_MixedAttributesInStruct) { |
| // Mix both non-uniform and uniform shader IO attributes in the same structure. Even accessing |
| // just uniform member causes non-uniformity in this case. |
| std::string src = R"( |
| struct S { |
| @builtin(num_workgroups) num_groups : vec3<u32>, |
| @builtin(local_invocation_index) idx : u32, |
| } |
| |
| @compute @workgroup_size(64) |
| fn main(s : S) { |
| if (s.num_groups.x == 0u) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (s.num_groups.x == 0u) { |
| ^^ |
| |
| test:9:7 note: parameter 's' of 'main' may be non-uniform |
| if (s.num_groups.x == 0u) { |
| ^ |
| )"); |
| } |
| |
| class FragmentBuiltin : public UniformityAnalysisTestBase, |
| public ::testing::TestWithParam<BuiltinEntry> {}; |
| TEST_P(FragmentBuiltin, AsParam) { |
| std::string src = R"( |
| @fragment |
| fn main(@builtin()" + GetParam().name + |
| R"() b : )" + GetParam().type + R"() { |
| if (u32(vec4(b).x) == 0u) { |
| _ = dpdx(0.5); |
| } |
| } |
| )"; |
| |
| bool should_pass = GetParam().uniform; |
| RunTest(src, should_pass); |
| if (!should_pass) { |
| EXPECT_EQ(error_, |
| R"(test:5:9 error: 'dpdx' must only be called from uniform control flow |
| _ = dpdx(0.5); |
| ^^^^^^^^^ |
| |
| test:4:3 note: control flow depends on possibly non-uniform value |
| if (u32(vec4(b).x) == 0u) { |
| ^^ |
| |
| test:4:16 note: builtin 'b' of 'main' may be non-uniform |
| if (u32(vec4(b).x) == 0u) { |
| ^ |
| )"); |
| } |
| } |
| |
| TEST_P(FragmentBuiltin, InStruct) { |
| std::string src = R"( |
| struct S { |
| @builtin()" + GetParam().name + |
| R"() b : )" + GetParam().type + R"( |
| } |
| |
| @fragment |
| fn main(s : S) { |
| if (u32(vec4(s.b).x) == 0u) { |
| _ = dpdx(0.5); |
| } |
| } |
| )"; |
| |
| bool should_pass = GetParam().uniform; |
| RunTest(src, should_pass); |
| if (!should_pass) { |
| EXPECT_EQ(error_, |
| R"(test:9:9 error: 'dpdx' must only be called from uniform control flow |
| _ = dpdx(0.5); |
| ^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (u32(vec4(s.b).x) == 0u) { |
| ^^ |
| |
| test:8:16 note: parameter 's' of 'main' may be non-uniform |
| if (u32(vec4(s.b).x) == 0u) { |
| ^ |
| )"); |
| } |
| } |
| |
| INSTANTIATE_TEST_SUITE_P(UniformityAnalysisTest, |
| FragmentBuiltin, |
| ::testing::Values(BuiltinEntry{"position", "vec4<f32>", false}, |
| BuiltinEntry{"front_facing", "bool", false}, |
| BuiltinEntry{"sample_index", "u32", false}, |
| BuiltinEntry{"sample_mask", "u32", false}), |
| [](const ::testing::TestParamInfo<FragmentBuiltin::ParamType>& p) { |
| return p.param.name; |
| }); |
| |
| TEST_F(UniformityAnalysisTest, FragmentLocation) { |
| std::string src = R"( |
| @fragment |
| fn main(@location(0) l : f32) { |
| if (l == 0.0) { |
| _ = dpdx(0.5); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:5:9 error: 'dpdx' must only be called from uniform control flow |
| _ = dpdx(0.5); |
| ^^^^^^^^^ |
| |
| test:4:3 note: control flow depends on possibly non-uniform value |
| if (l == 0.0) { |
| ^^ |
| |
| test:4:7 note: user-defined input 'l' of 'main' may be non-uniform |
| if (l == 0.0) { |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, FragmentLocation_InStruct) { |
| std::string src = R"( |
| struct S { |
| @location(0) l : f32 |
| } |
| |
| @fragment |
| fn main(s : S) { |
| if (s.l == 0.0) { |
| _ = dpdx(0.5); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:9 error: 'dpdx' must only be called from uniform control flow |
| _ = dpdx(0.5); |
| ^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (s.l == 0.0) { |
| ^^ |
| |
| test:8:7 note: parameter 's' of 'main' may be non-uniform |
| if (s.l == 0.0) { |
| ^ |
| )"); |
| } |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// Test loop conditions and conditional break/continue statements. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| namespace LoopTest { |
| |
| enum ControlFlowInterrupt { |
| kBreak, |
| kContinue, |
| kReturn, |
| }; |
| enum Condition { |
| kNone, |
| kUniform, |
| kNonUniform, |
| }; |
| |
| using LoopTestParams = std::tuple<int, int>; |
| |
| static std::string ToStr(ControlFlowInterrupt interrupt) { |
| switch (interrupt) { |
| case kBreak: |
| return "break"; |
| case kContinue: |
| return "continue"; |
| case kReturn: |
| return "return"; |
| } |
| return ""; |
| } |
| |
| static std::string ToStr(Condition condition) { |
| switch (condition) { |
| case kNone: |
| return "uncondtiional"; |
| case kUniform: |
| return "uniform"; |
| case kNonUniform: |
| return "nonuniform"; |
| } |
| return ""; |
| } |
| |
| class LoopTest : public UniformityAnalysisTestBase, |
| public ::testing::TestWithParam<LoopTestParams> { |
| protected: |
| std::string MakeInterrupt(ControlFlowInterrupt interrupt, Condition condition) { |
| switch (condition) { |
| case kNone: |
| return ToStr(interrupt); |
| case kUniform: |
| return "if (uniform_var == 42) { " + ToStr(interrupt) + "; }"; |
| case kNonUniform: |
| return "if (nonuniform_var == 42) { " + ToStr(interrupt) + "; }"; |
| } |
| return "<invalid>"; |
| } |
| }; |
| |
| INSTANTIATE_TEST_SUITE_P(UniformityAnalysisTest, |
| LoopTest, |
| ::testing::Combine(::testing::Range<int>(0, kReturn + 1), |
| ::testing::Range<int>(0, kNonUniform + 1)), |
| [](const ::testing::TestParamInfo<LoopTestParams>& p) { |
| ControlFlowInterrupt interrupt = |
| static_cast<ControlFlowInterrupt>(std::get<0>(p.param)); |
| auto condition = static_cast<Condition>(std::get<1>(p.param)); |
| return ToStr(interrupt) + "_" + ToStr(condition); |
| }); |
| |
| TEST_P(LoopTest, CallInBody_InterruptAfter) { |
| // Test control-flow interrupt in a loop after a function call that requires uniform control |
| // flow. |
| auto interrupt = static_cast<ControlFlowInterrupt>(std::get<0>(GetParam())); |
| auto condition = static_cast<Condition>(std::get<1>(GetParam())); |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> uniform_var : i32; |
| @group(0) @binding(0) var<storage, read_write> nonuniform_var : i32; |
| |
| fn foo() { |
| loop { |
| // Pretend that this isn't an infinite loop, in case the interrupt is a |
| // continue statement. |
| if (false) { |
| break; |
| } |
| |
| workgroupBarrier(); |
| )" + MakeInterrupt(interrupt, condition) + |
| R"(; |
| } |
| } |
| )"; |
| |
| if (condition == kNonUniform) { |
| RunTest(src, false); |
| EXPECT_THAT( |
| error_, |
| ::testing::StartsWith( |
| R"(test:13:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier();)")); |
| EXPECT_THAT(error_, |
| ::testing::HasSubstr("test:14:9 note: reading from read_write storage buffer " |
| "'nonuniform_var' may result in a non-uniform value")); |
| } else { |
| RunTest(src, true); |
| } |
| } |
| |
| TEST_P(LoopTest, CallInBody_InterruptBefore) { |
| // Test control-flow interrupt in a loop before a function call that requires uniform control |
| // flow. |
| auto interrupt = static_cast<ControlFlowInterrupt>(std::get<0>(GetParam())); |
| auto condition = static_cast<Condition>(std::get<1>(GetParam())); |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> uniform_var : i32; |
| @group(0) @binding(0) var<storage, read_write> nonuniform_var : i32; |
| |
| fn foo() { |
| loop { |
| // Pretend that this isn't an infinite loop, in case the interrupt is a |
| // continue statement. |
| if (false) { |
| break; |
| } |
| |
| )" + MakeInterrupt(interrupt, condition) + |
| R"(; |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| if (condition == kNonUniform) { |
| RunTest(src, false); |
| |
| EXPECT_THAT( |
| error_, |
| ::testing::StartsWith( |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier();)")); |
| EXPECT_THAT(error_, |
| ::testing::HasSubstr("test:13:9 note: reading from read_write storage buffer " |
| "'nonuniform_var' may result in a non-uniform value")); |
| } else { |
| RunTest(src, true); |
| } |
| } |
| |
| TEST_P(LoopTest, CallInContinuing_InterruptInBody) { |
| // Test control-flow interrupt in a loop with a function call that requires uniform control flow |
| // in the continuing statement. |
| auto interrupt = static_cast<ControlFlowInterrupt>(std::get<0>(GetParam())); |
| auto condition = static_cast<Condition>(std::get<1>(GetParam())); |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> uniform_var : i32; |
| @group(0) @binding(0) var<storage, read_write> nonuniform_var : i32; |
| |
| fn foo() { |
| loop { |
| // Pretend that this isn't an infinite loop, in case the interrupt is a |
| // continue statement. |
| if (false) { |
| break; |
| } |
| |
| )" + MakeInterrupt(interrupt, condition) + |
| R"(; |
| continuing { |
| workgroupBarrier(); |
| } |
| } |
| } |
| )"; |
| |
| if (condition == kNonUniform) { |
| RunTest(src, false); |
| EXPECT_THAT( |
| error_, |
| ::testing::StartsWith( |
| R"(test:15:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier();)")); |
| EXPECT_THAT(error_, |
| ::testing::HasSubstr("test:13:9 note: reading from read_write storage buffer " |
| "'nonuniform_var' may result in a non-uniform value")); |
| } else { |
| RunTest(src, true); |
| } |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_CallInBody_UniformBreakInContinuing) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> n : i32; |
| |
| fn foo() { |
| var i = 0; |
| loop { |
| workgroupBarrier(); |
| continuing { |
| i = i + 1; |
| break if (i == n); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_CallInBody_NonUniformBreakInContinuing) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| var i = 0; |
| loop { |
| workgroupBarrier(); |
| continuing { |
| i = i + 1; |
| break if (i == n); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:10:7 note: control flow depends on possibly non-uniform value |
| break if (i == n); |
| ^^^^^ |
| |
| test:10:22 note: reading from read_write storage buffer 'n' may result in a non-uniform value |
| break if (i == n); |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_CallInContinuing_UniformBreakInContinuing) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> n : i32; |
| |
| fn foo() { |
| var i = 0; |
| loop { |
| continuing { |
| workgroupBarrier(); |
| i = i + 1; |
| break if (i == n); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_CallInContinuing_NonUniformBreakInContinuing) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| var i = 0; |
| loop { |
| continuing { |
| workgroupBarrier(); |
| i = i + 1; |
| break if (i == n); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:10:7 note: control flow depends on possibly non-uniform value |
| break if (i == n); |
| ^^^^^ |
| |
| test:10:22 note: reading from read_write storage buffer 'n' may result in a non-uniform value |
| break if (i == n); |
| ^ |
| )"); |
| } |
| |
| class LoopDeadCodeTest : public UniformityAnalysisTestBase, public ::testing::TestWithParam<int> {}; |
| |
| INSTANTIATE_TEST_SUITE_P(UniformityAnalysisTest, |
| LoopDeadCodeTest, |
| ::testing::Range<int>(0, kReturn + 1), |
| [](const ::testing::TestParamInfo<LoopDeadCodeTest::ParamType>& p) { |
| return ToStr(static_cast<ControlFlowInterrupt>(p.param)); |
| }); |
| |
| TEST_P(LoopDeadCodeTest, AfterInterrupt) { |
| // Dead code after a control-flow interrupt in a loop shouldn't cause uniformity errors. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| loop { |
| )" + ToStr(static_cast<ControlFlowInterrupt>(GetParam())) + |
| R"(; |
| if (n == 42) { |
| workgroupBarrier(); |
| } |
| continuing { |
| // Pretend that this isn't an infinite loop, in case the interrupt is a |
| // continue statement. |
| break if (false); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_VarBecomesNonUniformInLoopAfterBarrier) { |
| // Use a variable for a conditional barrier in a loop, and then assign a non-uniform value to |
| // that variable later in that loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:12:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_VarBecomesNonUniformInLoopAfterBarrier_BreakAtEnd) { |
| // Use a variable for a conditional barrier in a loop, and then assign a non-uniform value to |
| // that variable later in that loop. End the loop with a break statement to prevent the |
| // non-uniform value from causing an issue. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| |
| v = non_uniform; |
| break; |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_ConditionalAssignNonUniformWithBreak_BarrierInLoop) { |
| // In a conditional block, assign a non-uniform value and then break, then use a variable for a |
| // conditional barrier later in the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (true) { |
| v = non_uniform; |
| break; |
| } |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_ConditionalAssignNonUniformWithConditionalBreak_BarrierInLoop) { |
| // In a conditional block, assign a non-uniform value and then conditionally break, then use a |
| // variable for a conditional barrier later in the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (true) { |
| v = non_uniform; |
| if (true) { |
| break; |
| } |
| } |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:8:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_ConditionalAssignNonUniformWithBreak_BarrierAfterLoop) { |
| // In a conditional block, assign a non-uniform value and then break, then use a variable for a |
| // conditional barrier after the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (true) { |
| v = non_uniform; |
| break; |
| } |
| v = 5; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:15:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:14:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:8:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_VarBecomesUniformBeforeSomeExits_BarrierAfterLoop) { |
| // Assign a non-uniform value, have two exit points only one of which assigns a uniform value, |
| // then use a variable for a conditional barrier after the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (true) { |
| break; |
| } |
| |
| v = non_uniform; |
| |
| if (false) { |
| v = 6; |
| break; |
| } |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:20:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:19:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:11:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_VarBecomesUniformBeforeAllExits_BarrierAfterLoop) { |
| // Assign a non-uniform value, have two exit points both of which assigns a uniform value, |
| // then use a variable for a conditional barrier after the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (true) { |
| v = 5; |
| break; |
| } |
| |
| v = non_uniform; |
| |
| if (false) { |
| v = 6; |
| break; |
| } |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_AssignNonUniformBeforeConditionalBreak_BarrierAfterLoop) { |
| // Assign a non-uniform value and then break in a conditional block, then use a variable for a |
| // conditional barrier after the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| v = non_uniform; |
| if (true) { |
| if (false) { |
| v = 5; |
| } else { |
| break; |
| } |
| v = 5; |
| } |
| v = 5; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:20:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:19:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:7:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_VarBecomesNonUniformBeforeConditionalContinue_BarrierAtStart) { |
| // Use a variable for a conditional barrier in a loop, assign a non-uniform value to |
| // that variable later in that loop, then perform a conditional continue before assigning a |
| // uniform value to that variable. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| if (true) { |
| continue; |
| } |
| |
| v = 5; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:12:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| Loop_VarBecomesUniformBeforeConditionalContinue_BarrierInContinuing) { |
| // Use a variable for a conditional barrier in the continuing statement of a loop, assign a |
| // non-uniform value to that variable later in that loop, then conditionally assign a uniform |
| // value before continuing. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| v = non_uniform; |
| |
| if (false) { |
| v = 5; |
| continue; |
| } |
| |
| continuing { |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| break if (true); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:16:9 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:15:7 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:7:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_VarBecomesNonUniformBeforeConditionalContinue) { |
| // Use a variable for a conditional barrier in a loop, assign a non-uniform value to |
| // that variable later in that loop, then perform a conditional continue before assigning a |
| // uniform value to that variable. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| if (true) { |
| continue; |
| } |
| |
| v = 5; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:12:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_VarBecomesNonUniformInNestedLoopWithBreak_BarrierInLoop) { |
| // Use a variable for a conditional barrier in a loop, then conditionally assign a non-uniform |
| // value to that variable followed by a break in a nested loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| loop { |
| if (true) { |
| v = non_uniform; |
| break; |
| } |
| v = 5; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:14:13 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| Loop_VarBecomesNonUniformInNestedLoopWithBreak_BecomesUniformAgain_BarrierAfterLoop) { |
| // Conditionally assign a non-uniform value followed by a break in a nested loop, assign a |
| // uniform value in the outer loop, and then use a variable for a conditional barrier after the |
| // loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| loop { |
| if (false) { |
| break; |
| } |
| |
| loop { |
| if (true) { |
| v = non_uniform; |
| break; |
| } |
| } |
| v = 5; |
| } |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_NonUniformValueNeverReachesContinuing) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| loop { |
| var v = non_uniform; |
| return; |
| |
| continuing { |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_NonUniformValueDeclaredInBody_UnreachableContinuing) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var condition = true; |
| loop { |
| var v = non_uniform; |
| if (condition) { |
| break; |
| } else { |
| break; |
| } |
| |
| continuing { |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_NonUniformValueDeclaredInBody_MaybeReachesContinuing) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var condition = true; |
| loop { |
| var v = non_uniform; |
| if (condition) { |
| continue; |
| } else { |
| break; |
| } |
| |
| continuing { |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:16:9 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:15:7 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:7:13 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Loop_NonUniformBreakInBody_Reconverge) { |
| // Loops reconverge at exit, so test that we can call workgroupBarrier() after a loop that |
| // contains a non-uniform conditional break. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| var i = 0; |
| loop { |
| if (i == n) { |
| break; |
| } |
| i = i + 1; |
| } |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_CallInside_UniformCondition) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> n : i32; |
| |
| fn foo() { |
| for (var i = 0; i < n; i = i + 1) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_CallInside_NonUniformCondition) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| for (var i = 0; i < n; i = i + 1) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| for (var i = 0; i < n; i = i + 1) { |
| ^^^ |
| |
| test:5:23 note: reading from read_write storage buffer 'n' may result in a non-uniform value |
| for (var i = 0; i < n; i = i + 1) { |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_VarBecomesNonUniformInContinuing_BarrierInLoop) { |
| // Use a variable for a conditional barrier in a loop, and then assign a non-uniform value to |
| // that variable in the continuing statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; v = non_uniform) { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:6:31 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| for (var i = 0; i < 10; v = non_uniform) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_VarBecomesUniformInContinuing_BarrierInLoop) { |
| // Use a variable for a conditional barrier in a loop, and then assign a uniform value to that |
| // variable in the continuing statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; v = 5) { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_VarBecomesNonUniformInContinuing_BarrierAfterLoop) { |
| // Use a variable for a conditional barrier after a loop, and assign a non-uniform value to |
| // that variable in the continuing statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; v = non_uniform) { |
| v = 5; |
| } |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:6:31 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| for (var i = 0; i < 10; v = non_uniform) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_VarBecomesUniformInContinuing_BarrierAfterLoop) { |
| // Use a variable for a conditional barrier after a loop, and assign a uniform value to that |
| // variable in the continuing statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; v = 5) { |
| v = non_uniform; |
| } |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_VarBecomesNonUniformInLoopAfterBarrier) { |
| // Use a variable for a conditional barrier in a loop, and then assign a non-uniform value to |
| // that variable later in that loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; i++) { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:12:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_ConditionalAssignNonUniformWithBreak_BarrierInLoop) { |
| // In a conditional block, assign a non-uniform value and then break, then use a variable for a |
| // conditional barrier later in the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; i++) { |
| if (true) { |
| v = non_uniform; |
| break; |
| } |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_ConditionalAssignNonUniformWithBreak_BarrierAfterLoop) { |
| // In a conditional block, assign a non-uniform value and then break, then use a variable for a |
| // conditional barrier after the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; i++) { |
| if (true) { |
| v = non_uniform; |
| break; |
| } |
| v = 5; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:15:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:14:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:8:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_VarRemainsNonUniformAtLoopEnd_BarrierAfterLoop) { |
| // Assign a non-uniform value, assign a uniform value before all explicit break points but leave |
| // the value non-uniform at loop exit, then use a variable for a conditional barrier after the |
| // loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; i++) { |
| if (true) { |
| v = 5; |
| break; |
| } |
| |
| v = non_uniform; |
| |
| if (true) { |
| v = 6; |
| break; |
| } |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:21:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:20:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:12:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| ForLoop_VarBecomesNonUniformBeforeConditionalContinue_BarrierAtStart) { |
| // Use a variable for a conditional barrier in a loop, assign a non-uniform value to |
| // that variable later in that loop, then perform a conditional continue before assigning a |
| // uniform value to that variable. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; i++) { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| if (true) { |
| continue; |
| } |
| |
| v = 5; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:12:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_VarBecomesNonUniformBeforeConditionalContinue) { |
| // Use a variable for a conditional barrier in a loop, assign a non-uniform value to |
| // that variable later in that loop, then perform a conditional continue before assigning a |
| // uniform value to that variable. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| for (var i = 0; i < 10; i++) { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| if (true) { |
| continue; |
| } |
| |
| v = 5; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:12:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| ForLoop_InitializerVarBecomesNonUniformBeforeConditionalContinue_BarrierAtStart) { |
| // Use a variable declared in a for-loop initializer for a conditional barrier in a loop, assign |
| // a non-uniform value to that variable later in that loop and then execute a continue. |
| // Tests that variables declared in the for-loop initializer are properly tracked. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| for (var i = 0; i < 10; i++) { |
| if (i < 5) { |
| workgroupBarrier(); |
| } |
| if (true) { |
| i = non_uniform; |
| continue; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| for (var i = 0; i < 10; i++) { |
| ^^^ |
| |
| test:10:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| i = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_NonUniformCondition_Reconverge) { |
| // Loops reconverge at exit, so test that we can call workgroupBarrier() after a loop that has a |
| // non-uniform condition. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| for (var i = 0; i < n; i = i + 1) { |
| } |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_VarDeclaredInBody) { |
| // Make sure that we can declare a variable inside the loop body without causing issues for |
| // tracking local variables across iterations. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| var outer : i32; |
| for (var i = 0; i < n; i = i + 1) { |
| var inner : i32; |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ForLoop_InitializerScope) { |
| // Make sure that variables declared in a for-loop initializer are properly removed from the |
| // local variable list, otherwise a parent control-flow statement will try to add edges to nodes |
| // that no longer exist. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| if (n == 5) { |
| for (var i = 0; i < n; i = i + 1) { |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, While_CallInside_UniformCondition) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> n : i32; |
| |
| fn foo() { |
| var i = 0; |
| while (i < n) { |
| workgroupBarrier(); |
| i = i + 1; |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, While_CallInside_NonUniformCondition) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| var i = 0; |
| while (i < n) { |
| workgroupBarrier(); |
| i = i + 1; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:6:3 note: control flow depends on possibly non-uniform value |
| while (i < n) { |
| ^^^^^ |
| |
| test:6:14 note: reading from read_write storage buffer 'n' may result in a non-uniform value |
| while (i < n) { |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, While_VarBecomesNonUniformInLoopAfterBarrier) { |
| // Use a variable for a conditional barrier in a loop, and then assign a non-uniform value to |
| // that variable later in that loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| var i = 0; |
| while (i < 10) { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| i++; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:13:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, While_ConditionalAssignNonUniformWithBreak_BarrierInLoop) { |
| // In a conditional block, assign a non-uniform value and then break, then use a variable for a |
| // conditional barrier later in the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| var i = 0; |
| while (i < 10) { |
| if (true) { |
| v = non_uniform; |
| break; |
| } |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| i++; |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, While_ConditionalAssignNonUniformWithBreak_BarrierAfterLoop) { |
| // In a conditional block, assign a non-uniform value and then break, then use a variable for a |
| // conditional barrier after the loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| var i = 0; |
| while (i < 10) { |
| if (true) { |
| v = non_uniform; |
| break; |
| } |
| v = 5; |
| i++; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:17:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:16:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:9:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, While_VarRemainsNonUniformAtLoopEnd_BarrierAfterLoop) { |
| // Assign a non-uniform value, assign a uniform value before all explicit break points but leave |
| // the value non-uniform at loop exit, then use a variable for a conditional barrier after the |
| // loop. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| var i = 0; |
| while (i < 10) { |
| if (true) { |
| v = 5; |
| break; |
| } |
| |
| v = non_uniform; |
| |
| if (true) { |
| v = 6; |
| break; |
| } |
| i++; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:23:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:22:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:13:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, While_VarBecomesNonUniformBeforeConditionalContinue_BarrierAtStart) { |
| // Use a variable for a conditional barrier in a loop, assign a non-uniform value to |
| // that variable later in that loop, then perform a conditional continue before assigning a |
| // uniform value to that variable. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| var i = 0; |
| while (i < 10) { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| if (true) { |
| continue; |
| } |
| |
| v = 5; |
| i++; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:13:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, While_VarBecomesNonUniformBeforeConditionalContinue) { |
| // Use a variable for a conditional barrier in a loop, assign a non-uniform value to |
| // that variable later in that loop, then perform a conditional continue before assigning a |
| // uniform value to that variable. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| var i = 0; |
| while (i < 10) { |
| if (v == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| v = non_uniform; |
| if (true) { |
| continue; |
| } |
| |
| v = 5; |
| i++; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:5 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:13:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, While_NonUniformCondition_Reconverge) { |
| // Loops reconverge at exit, so test that we can call workgroupBarrier() after a loop that has a |
| // non-uniform condition. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> n : i32; |
| |
| fn foo() { |
| var i = 0; |
| while (i < n) { |
| } |
| workgroupBarrier(); |
| i = i + 1; |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| } // namespace LoopTest |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// If-else statement tests. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| TEST_F(UniformityAnalysisTest, IfElse_UniformCondition_BarrierInTrueBlock) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> uniform_global : i32; |
| |
| fn foo() { |
| if (uniform_global == 42) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_UniformCondition_BarrierInElseBlock) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> uniform_global : i32; |
| |
| fn foo() { |
| if (uniform_global == 42) { |
| } else { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_UniformCondition_BarrierInElseIfBlock) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> uniform_global : i32; |
| |
| fn foo() { |
| if (uniform_global == 42) { |
| } else if (true) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_NonUniformCondition_BarrierInTrueBlock) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:5:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_NonUniformCondition_BarrierInElseBlock) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| } else { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:5:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_ShortCircuitingCondition_NonUniformLHS_And) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| var<private> p : i32; |
| |
| fn main() { |
| if ((non_uniform_global == 42) && false) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:34 note: control flow depends on possibly non-uniform value |
| if ((non_uniform_global == 42) && false) { |
| ^^ |
| |
| test:7:8 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if ((non_uniform_global == 42) && false) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_ShortCircuitingCondition_NonUniformRHS_And) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| var<private> p : i32; |
| |
| fn main() { |
| if (false && (non_uniform_global == 42)) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (false && (non_uniform_global == 42)) { |
| ^^ |
| |
| test:7:17 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if (false && (non_uniform_global == 42)) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_ShortCircuitingCondition_NonUniformLHS_Or) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| var<private> p : i32; |
| |
| fn main() { |
| if ((non_uniform_global == 42) || true) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:34 note: control flow depends on possibly non-uniform value |
| if ((non_uniform_global == 42) || true) { |
| ^^ |
| |
| test:7:8 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if ((non_uniform_global == 42) || true) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_ShortCircuitingCondition_NonUniformRHS_Or) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| var<private> p : i32; |
| |
| fn main() { |
| if (true || (non_uniform_global == 42)) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (true || (non_uniform_global == 42)) { |
| ^^ |
| |
| test:7:16 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if (true || (non_uniform_global == 42)) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_NonUniformCondition_BarrierInElseIfBlock) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| } else if (true) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:5:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_VarBecomesNonUniform_BeforeCondition) { |
| // Use a function-scope variable for control-flow guarding a barrier, and then assign to that |
| // variable before checking the condition. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v = 0; |
| v = rw; |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:6:7 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| v = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_VarBecomesNonUniform_AfterCondition) { |
| // Use a function-scope variable for control-flow guarding a barrier, and then assign to that |
| // variable after checking the condition. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v = 0; |
| if (v == 0) { |
| v = rw; |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_VarBecomesNonUniformInIf_BarrierInElse) { |
| // Assign a non-uniform value to a variable in an if-block, and then use that variable for a |
| // conditional barrier in the else block. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| if (true) { |
| v = non_uniform; |
| } else { |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_AssignNonUniformInIf_AssignUniformInElse) { |
| // Assign a non-uniform value to a variable in an if-block and a uniform value in the else |
| // block, and then use that variable for a conditional barrier after the if-else statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| if (true) { |
| if (true) { |
| v = non_uniform; |
| } else { |
| v = 5; |
| } |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:15:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:14:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:8:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_AssignNonUniformInIfWithReturn) { |
| // Assign a non-uniform value to a variable in an if-block followed by a return, and then use |
| // that variable for a conditional barrier after the if-else statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| if (true) { |
| v = non_uniform; |
| return; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_AssignNonUniformBeforeIf_BothBranchesAssignUniform) { |
| // Assign a non-uniform value to a variable before and if-else statement, assign uniform values |
| // in both branch of the if-else, and then use that variable for a conditional barrier after |
| // the if-else statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| v = non_uniform; |
| if (true) { |
| v = 5; |
| } else { |
| v = 6; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_AssignNonUniformBeforeIf_OnlyTrueBranchAssignsUniform) { |
| // Assign a non-uniform value to a variable before and if-else statement, assign a uniform value |
| // in the true branch of the if-else, and then use that variable for a conditional barrier after |
| // the if-else statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| v = non_uniform; |
| if (true) { |
| v = 5; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:12:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:6:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_AssignNonUniformBeforeIf_OnlyFalseBranchAssignsUniform) { |
| // Assign a non-uniform value to a variable before and if-else statement, assign a uniform value |
| // in the false branch of the if-else, and then use that variable for a conditional barrier |
| // after the if-else statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| v = non_uniform; |
| if (true) { |
| } else { |
| v = 5; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:13:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:12:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:6:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| IfElse_AssignNonUniformBeforeIf_OnlyTrueBranchAssignsUniform_FalseBranchReturns) { |
| // Assign a non-uniform value to a variable before and if-else statement, assign a uniform value |
| // in the true branch of the if-else, leave the variable untouched in the false branch and just |
| // return, and then use that variable for a conditional barrier after the if-else statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| v = non_uniform; |
| if (true) { |
| v = 5; |
| } else { |
| return; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| IfElse_AssignNonUniformBeforeIf_OnlyFalseBranchAssignsUniform_TrueBranchReturns) { |
| // Assign a non-uniform value to a variable before and if-else statement, assign a uniform value |
| // in the false branch of the if-else, leave the variable untouched in the true branch and just |
| // return, and then use that variable for a conditional barrier after the if-else statement. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| v = non_uniform; |
| if (true) { |
| return; |
| } else { |
| v = 5; |
| } |
| |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_NonUniformCondition_Reconverge) { |
| // If statements reconverge at exit, so test that we can call workgroupBarrier() after an if |
| // statement with a non-uniform condition. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| } else { |
| } |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_ShortCircuitingNonUniformConditionLHS_Reconverge) { |
| // If statements reconverge at exit, so test that we can call workgroupBarrier() after an if |
| // statement with a non-uniform condition that uses short-circuiting. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| if (non_uniform == 42 || true) { |
| } |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_ShortCircuitingNonUniformConditionRHS_Reconverge) { |
| // If statements reconverge at exit, so test that we can call workgroupBarrier() after an if |
| // statement with a non-uniform condition that uses short-circuiting. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| if (false && non_uniform == 42) { |
| } |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_NonUniformFunctionCall_Reconverge) { |
| // If statements reconverge at exit, so test that we can call workgroupBarrier() after an if |
| // statement with a non-uniform condition. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar() { |
| if (non_uniform == 42) { |
| return; |
| } else { |
| return; |
| } |
| } |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| bar(); |
| } else { |
| } |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IfElse_NonUniformReturn_NoReconverge) { |
| // If statements should not reconverge after non-uniform returns. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| return; |
| } else { |
| } |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:3 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:5:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// Switch statement tests. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| TEST_F(UniformityAnalysisTest, Switch_NonUniformCondition_BarrierInCase) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| switch (non_uniform) { |
| case 42: { |
| workgroupBarrier(); |
| break; |
| } |
| default: { |
| break; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| switch (non_uniform) { |
| ^^^^^^ |
| |
| test:5:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| switch (non_uniform) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_NonUniformCondition_BarrierInDefault) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| switch (non_uniform) { |
| default: { |
| workgroupBarrier(); |
| break; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| switch (non_uniform) { |
| ^^^^^^ |
| |
| test:5:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| switch (non_uniform) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_NonUniformBreak) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| switch (condition) { |
| case 42: { |
| if (non_uniform == 42) { |
| break; |
| } |
| workgroupBarrier(); |
| } |
| default: { |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:11:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:7 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:8:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_NonUniformBreakInDifferentCase) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| switch (condition) { |
| case 0: { |
| if (non_uniform == 42) { |
| break; |
| } |
| } |
| case 42: { |
| workgroupBarrier(); |
| } |
| default: { |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_VarBecomesNonUniformInDifferentCase_WithBreak) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| var x = 0; |
| switch (condition) { |
| case 0: { |
| x = non_uniform; |
| break; |
| } |
| case 42: { |
| if (x == 0) { |
| workgroupBarrier(); |
| } |
| } |
| default: { |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_VarBecomesUniformInDifferentCase_WithBreak) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| var x = non_uniform; |
| switch (condition) { |
| case 0: { |
| x = 5; |
| break; |
| } |
| case 42: { |
| if (x == 0) { |
| workgroupBarrier(); |
| } |
| } |
| default: { |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:9 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:7 note: control flow depends on possibly non-uniform value |
| if (x == 0) { |
| ^^ |
| |
| test:6:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var x = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_VarBecomesNonUniformInCase_BarrierAfter) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| var x = 0; |
| switch (condition) { |
| case 0: { |
| x = non_uniform; |
| } |
| case 42: { |
| x = 5; |
| } |
| default: { |
| x = 6; |
| } |
| } |
| if (x == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:19:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:18:3 note: control flow depends on possibly non-uniform value |
| if (x == 0) { |
| ^^ |
| |
| test:9:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| x = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_VarBecomesUniformInAllCases_BarrierAfter) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| var x = non_uniform; |
| switch (condition) { |
| case 0: { |
| x = 4; |
| } |
| case 42: { |
| x = 5; |
| } |
| default: { |
| x = 6; |
| } |
| } |
| if (x == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_VarBecomesUniformInSomeCases_BarrierAfter) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| var x = non_uniform; |
| switch (condition) { |
| case 0: { |
| x = 4; |
| } |
| case 42: { |
| } |
| default: { |
| x = 6; |
| } |
| } |
| if (x == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:18:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:17:3 note: control flow depends on possibly non-uniform value |
| if (x == 0) { |
| ^^ |
| |
| test:6:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var x = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_VarBecomesUniformInCasesThatDontReturn_BarrierAfter) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| var x = non_uniform; |
| switch (condition) { |
| case 0: { |
| x = 4; |
| } |
| case 42: { |
| return; |
| } |
| default: { |
| x = 6; |
| } |
| } |
| if (x == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_VarBecomesUniformAfterConditionalBreak_BarrierAfter) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| var x = non_uniform; |
| switch (condition) { |
| case 0: { |
| x = 4; |
| } |
| case 42: { |
| } |
| default: { |
| if (false) { |
| break; |
| } |
| x = 6; |
| } |
| } |
| if (x == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:21:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:20:3 note: control flow depends on possibly non-uniform value |
| if (x == 0) { |
| ^^ |
| |
| test:6:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var x = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_NestedInLoop_VarBecomesNonUniformWithBreak_BarrierInLoop) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| var x = 0; |
| loop { |
| if (x == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| switch (condition) { |
| case 0: { |
| x = non_uniform; |
| break; |
| } |
| default: { |
| x = 6; |
| } |
| } |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:5 note: control flow depends on possibly non-uniform value |
| if (x == 0) { |
| ^^ |
| |
| test:15:13 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| x = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_NestedInLoop_VarBecomesNonUniformWithBreak_BarrierAfterLoop) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(0) var<uniform> condition : i32; |
| |
| fn foo() { |
| var x = 0; |
| loop { |
| if (false) { |
| break; |
| } |
| switch (condition) { |
| case 0: { |
| x = non_uniform; |
| break; |
| } |
| default: { |
| x = 6; |
| } |
| } |
| x = 5; |
| } |
| if (x == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_NonUniformCondition_Reconverge) { |
| // Switch statements reconverge at exit, so test that we can call workgroupBarrier() after a |
| // switch statement that contains a non-uniform conditional break. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| switch (non_uniform) { |
| default: { |
| break; |
| } |
| } |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Switch_NonUniformBreak_Reconverge) { |
| // Switch statements reconverge at exit, so test that we can call workgroupBarrier() after a |
| // switch statement that contains a non-uniform conditional break. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| switch (42) { |
| default: { |
| if (non_uniform == 0) { |
| break; |
| } |
| break; |
| } |
| } |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// Pointer tests. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| TEST_F(UniformityAnalysisTest, AssignNonUniformThroughPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| *&v = non_uniform; |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:6:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| *&v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignNonUniformThroughCapturedPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| let pv = &v; |
| *pv = non_uniform; |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:7:9 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| *pv = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignUniformThroughPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = non_uniform; |
| *&v = 42; |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignUniformThroughCapturedPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = non_uniform; |
| let pv = &v; |
| *pv = 42; |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignUniformThroughCapturedPointer_InNonUniformControlFlow) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| let pv = &v; |
| if (non_uniform == 0) { |
| *pv = 42; |
| } |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:11:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 0) { |
| ^^ |
| |
| test:7:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 0) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformThroughPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = non_uniform; |
| if (*&v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:6:3 note: control flow depends on possibly non-uniform value |
| if (*&v == 0) { |
| ^^ |
| |
| test:5:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformLocalThroughCapturedPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = non_uniform; |
| let pv = &v; |
| if (*pv == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (*pv == 0) { |
| ^^ |
| |
| test:5:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformLocalThroughPointerParameter) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| bar(&v); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:5:8 note: parameter 'p' of 'bar' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:12:7 note: possibly non-uniform value passed via pointer here |
| bar(&v); |
| ^ |
| |
| test:11:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformGlobalThroughCapturedPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| let pv = &non_uniform; |
| if (*pv == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:6:3 note: control flow depends on possibly non-uniform value |
| if (*pv == 0) { |
| ^^ |
| |
| test:6:8 note: reading from 'pv' may result in a non-uniform value |
| if (*pv == 0) { |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformGlobalThroughPointerParameter) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<storage, i32, read_write>) { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn foo() { |
| bar(&non_uniform); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:7:8 note: parameter 'p' of 'bar' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:13:7 note: possibly non-uniform value passed via pointer here |
| bar(&non_uniform); |
| ^ |
| |
| test:4:48 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformGlobalThroughPointerParameter_ViaReturnValue) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<storage, i32, read_write>) -> i32 { |
| return *p; |
| } |
| |
| fn foo() { |
| if (0 == bar(&non_uniform)) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:12:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (0 == bar(&non_uniform)) { |
| ^^ |
| |
| test:4:48 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformThroughPointerParameter_BecomesUniformAfterUse) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| *p = 0; |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| bar(&v); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:5:8 note: parameter 'p' of 'bar' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:13:7 note: possibly non-uniform value passed via pointer here |
| bar(&v); |
| ^ |
| |
| test:12:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformThroughPointerParameter_BecomesUniformAfterCall) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| bar(&v); |
| v = 0; |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:5:8 note: parameter 'p' of 'bar' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:12:7 note: possibly non-uniform value passed via pointer here |
| bar(&v); |
| ^ |
| |
| test:11:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadUniformThroughPointer) { |
| std::string src = R"( |
| fn foo() { |
| var v = 42; |
| if (*&v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadUniformThroughCapturedPointer) { |
| std::string src = R"( |
| fn foo() { |
| var v = 42; |
| let pv = &v; |
| if (*pv == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadUniformThroughPointerParameter) { |
| std::string src = R"( |
| fn bar(p : ptr<function, i32>) { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn foo() { |
| var v = 42; |
| bar(&v); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadUniformThroughNonUniformPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| // The contents of `v` are uniform. |
| var v = array<i32, 4>(); |
| // The pointer `p` is non-uniform. |
| let p = &v[non_uniform]; |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:8:14 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| let p = &v[non_uniform]; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadUniformThroughNonUniformPointer_ViaParameter) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, array<i32, 4>>) { |
| // The pointer `p` is non-uniform. |
| let local_p = &(*p)[non_uniform]; |
| if (*local_p == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn foo() { |
| // The contents of `v` are uniform. |
| var v = array<i32, 4>(); |
| let p = &v; |
| bar(p); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (*local_p == 0) { |
| ^^ |
| |
| test:8:23 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| let local_p = &(*p)[non_uniform]; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadUniformThroughNonUniformPointer_ViaParameterChain) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn zoo(p : ptr<function, i32>) { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn bar(p : ptr<function, i32>) { |
| zoo(p); |
| } |
| |
| fn foo() { |
| // The contents of `v` are uniform. |
| var v = array<i32, 4>(); |
| // The pointer `p` is non-uniform. |
| let p = &v[non_uniform]; |
| bar(p); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:7:8 note: parameter 'p' of 'zoo' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:13:7 note: possibly non-uniform value passed via pointer here |
| zoo(p); |
| ^ |
| |
| test:12:8 note: reading from 'p' may result in a non-uniform value |
| fn bar(p : ptr<function, i32>) { |
| ^ |
| |
| test:21:7 note: possibly non-uniform value passed via pointer here |
| bar(p); |
| ^ |
| |
| test:20:14 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| let p = &v[non_uniform]; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformThroughUniformPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var<storage, read> uniform_idx : i32; |
| |
| fn foo() { |
| // The contents of `v` are non-uniform. |
| var v = array<i32, 4>(0, 0, 0, non_uniform); |
| // The pointer `p` is uniform. |
| let p = &v[uniform_idx]; |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:11:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:10:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:7:34 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = array<i32, 4>(0, 0, 0, non_uniform); |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformThroughUniformPointer_ViaParameter) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var<storage, read> uniform_idx : i32; |
| |
| fn zoo(p : ptr<function, i32>) { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn bar(p : ptr<function, i32>) { |
| zoo(p); |
| } |
| |
| fn foo() { |
| // The contents of `v` are non-uniform. |
| var v = array<i32, 4>(0, 0, 0, non_uniform); |
| // The pointer `p` is uniform. |
| let p = &v[uniform_idx]; |
| bar(p); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:8:8 note: parameter 'p' of 'zoo' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:14:7 note: possibly non-uniform value passed via pointer here |
| zoo(p); |
| ^ |
| |
| test:13:8 note: reading from 'p' may result in a non-uniform value |
| fn bar(p : ptr<function, i32>) { |
| ^ |
| |
| test:22:7 note: possibly non-uniform value passed via pointer here |
| bar(p); |
| ^ |
| |
| test:19:34 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = array<i32, 4>(0, 0, 0, non_uniform); |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StoreNonUniformAfterCapturingPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| let pv = &v; |
| v = non_uniform; |
| if (*pv == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (*pv == 0) { |
| ^^ |
| |
| test:7:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StoreUniformAfterCapturingPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = non_uniform; |
| let pv = &v; |
| v = 42; |
| if (*pv == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignNonUniformThroughLongChainOfPointers) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| let pv1 = &*&v; |
| let pv2 = &*&*pv1; |
| *&*&*pv2 = non_uniform; |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:8:14 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| *&*&*pv2 = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, LoadNonUniformThroughLongChainOfPointers) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = non_uniform; |
| let pv1 = &*&v; |
| let pv2 = &*&*pv1; |
| if (*&*&*pv2 == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (*&*&*pv2 == 0) { |
| ^^ |
| |
| test:5:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignUniformThenNonUniformThroughDifferentPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| let pv1 = &v; |
| let pv2 = &v; |
| *pv1 = 42; |
| *pv2 = non_uniform; |
| if (*pv1 == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:11:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:10:3 note: control flow depends on possibly non-uniform value |
| if (*pv1 == 0) { |
| ^^ |
| |
| test:9:10 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| *pv2 = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignNonUniformThenUniformThroughDifferentPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| var v = 0; |
| let pv1 = &v; |
| let pv2 = &v; |
| *pv1 = non_uniform; |
| *pv2 = 42; |
| if (*pv1 == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, UnmodifiedPointerParameterNonUniform) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:11:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:10:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:8:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, UnmodifiedPointerParameterUniform) { |
| std::string src = R"( |
| fn bar(p : ptr<function, i32>) { |
| } |
| |
| fn foo() { |
| var v = 42; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignNonUniformThroughPointerInFunctionCall) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| *p = non_uniform; |
| } |
| |
| fn foo() { |
| var v = 0; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:12:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:10:7 note: contents of pointer may become non-uniform after calling 'bar' |
| bar(&v); |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignUniformThroughPointerInFunctionCall) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| *p = 42; |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignNonUniformThroughPointerInFunctionCallViaArg) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>, a : i32) { |
| *p = a; |
| } |
| |
| fn foo() { |
| var v = 0; |
| bar(&v, non_uniform); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:12:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:10:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| bar(&v, non_uniform); |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignNonUniformThroughPointerInFunctionCallViaPointerArg) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>, a : ptr<function, i32>) { |
| *p = *a; |
| } |
| |
| fn foo() { |
| var v = 0; |
| var a = non_uniform; |
| bar(&v, &a); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:13:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:12:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:10:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var a = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignUniformThroughPointerInFunctionCallViaArg) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>, a : i32) { |
| *p = a; |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| bar(&v, 42); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignUniformThroughPointerInFunctionCallViaPointerArg) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>, a : ptr<function, i32>) { |
| *p = *a; |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| var a = 42; |
| bar(&v, &a); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignNonUniformThroughPointerInFunctionCallChain) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn f3(p : ptr<function, i32>, a : ptr<function, i32>) { |
| *p = *a; |
| } |
| |
| fn f2(p : ptr<function, i32>, a : ptr<function, i32>) { |
| f3(p, a); |
| } |
| |
| fn f1(p : ptr<function, i32>, a : ptr<function, i32>) { |
| f2(p, a); |
| } |
| |
| fn foo() { |
| var v = 0; |
| var a = non_uniform; |
| f1(&v, &a); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:21:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:20:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:18:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var a = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignUniformThroughPointerInFunctionCallChain) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn f3(p : ptr<function, i32>, a : ptr<function, i32>) { |
| *p = *a; |
| } |
| |
| fn f2(p : ptr<function, i32>, a : ptr<function, i32>) { |
| f3(p, a); |
| } |
| |
| fn f1(p : ptr<function, i32>, a : ptr<function, i32>) { |
| f2(p, a); |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| var a = 42; |
| f1(&v, &a); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MakePointerParamUniformInReturnExpression) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn zoo(p : ptr<function, i32>) -> i32 { |
| *p = 5; |
| return 6; |
| } |
| |
| fn bar(p : ptr<function, i32>) -> i32 { |
| *p = non_uniform; |
| return zoo(p); |
| } |
| |
| fn foo() { |
| var v = 0; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MakePointerParamNonUniformInReturnExpression) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn zoo(p : ptr<function, i32>) -> i32 { |
| *p = non_uniform; |
| return 6; |
| } |
| |
| fn bar(p : ptr<function, i32>) -> i32 { |
| *p = 5; |
| return zoo(p); |
| } |
| |
| fn foo() { |
| var v = 0; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:18:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:17:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:16:7 note: contents of pointer may become non-uniform after calling 'bar' |
| bar(&v); |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, PointerParamAssignNonUniformInTrueAndUniformInFalse) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| if (true) { |
| *p = non_uniform; |
| } else { |
| *p = 5; |
| } |
| } |
| |
| fn foo() { |
| var v = 0; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:16:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:15:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:14:7 note: contents of pointer may become non-uniform after calling 'bar' |
| bar(&v); |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ConditionalAssignNonUniformToPointerParamAndReturn) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| if (true) { |
| *p = non_uniform; |
| return; |
| } |
| *p = 5; |
| } |
| |
| fn foo() { |
| var v = 0; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:16:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:15:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:14:7 note: contents of pointer may become non-uniform after calling 'bar' |
| bar(&v); |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ConditionalAssignNonUniformToPointerParamAndBreakFromSwitch) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var<uniform> condition : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| switch (condition) { |
| case 0 { |
| if (true) { |
| *p = non_uniform; |
| break; |
| } |
| *p = 5; |
| } |
| default { |
| *p = 6; |
| } |
| } |
| } |
| |
| fn foo() { |
| var v = 0; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:24:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:23:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:22:7 note: contents of pointer may become non-uniform after calling 'bar' |
| bar(&v); |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ConditionalAssignNonUniformToPointerParamAndBreakFromLoop) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| loop { |
| if (true) { |
| *p = non_uniform; |
| break; |
| } |
| *p = 5; |
| } |
| } |
| |
| fn foo() { |
| var v = 0; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:18:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:17:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:16:7 note: contents of pointer may become non-uniform after calling 'bar' |
| bar(&v); |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ConditionalAssignNonUniformToPointerParamAndContinue) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo(p : ptr<function, i32>) { |
| loop { |
| if (*p == 0) { |
| workgroupBarrier(); |
| break; |
| } |
| |
| if (true) { |
| *p = non_uniform; |
| continue; |
| } |
| *p = 5; |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:7:7 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:6:5 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:12:12 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| *p = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, PointerParamMaybeBecomesUniform) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| if (true) { |
| *p = 5; |
| return; |
| } |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| bar(&v); |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:15:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:14:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:12:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, PointerParamModifiedInNonUniformControlFlow) { |
| std::string src = R"( |
| @binding(0) @group(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn foo(p : ptr<function, i32>) { |
| *p = 42; |
| } |
| |
| @compute @workgroup_size(64) |
| fn main() { |
| var a : i32; |
| if (non_uniform_global == 0) { |
| foo(&a); |
| } |
| |
| if (a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:16:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform_global == 0) { |
| ^^ |
| |
| test:11:7 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if (non_uniform_global == 0) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, PointerParamAssumedModifiedInNonUniformControlFlow) { |
| std::string src = R"( |
| @binding(0) @group(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn foo(p : ptr<function, i32>) { |
| // Do not modify 'p', uniformity analysis presently assumes it will be. |
| } |
| |
| @compute @workgroup_size(64) |
| fn main() { |
| var a : i32; |
| if (non_uniform_global == 0) { |
| foo(&a); |
| } |
| |
| if (a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:16:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform_global == 0) { |
| ^^ |
| |
| test:11:7 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if (non_uniform_global == 0) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, PointerParamModifiedInNonUniformControlFlow_NestedCall) { |
| std::string src = R"( |
| @binding(0) @group(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn foo2(p : ptr<function, i32>) { |
| *p = 42; |
| } |
| |
| fn foo(p : ptr<function, i32>) { |
| foo2(p); |
| } |
| |
| @compute @workgroup_size(64) |
| fn main() { |
| var a : i32; |
| if (non_uniform_global == 0) { |
| foo(&a); |
| } |
| |
| if (a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:20:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:15:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform_global == 0) { |
| ^^ |
| |
| test:15:7 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if (non_uniform_global == 0) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, PointerParamModifiedInUniformControlFlow) { |
| std::string src = R"( |
| @binding(0) @group(0) var<uniform> uniform_global : i32; |
| |
| fn foo(p : ptr<function, i32>) { |
| *p = 42; |
| } |
| |
| @compute @workgroup_size(64) |
| fn main() { |
| var a : i32; |
| if (uniform_global == 0) { |
| foo(&a); |
| } |
| |
| if (a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, NonUniformPointerParameterBecomesUniform_AfterUse) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(a : ptr<function, i32>, b : ptr<function, i32>) { |
| *b = *a; |
| *a = 0; |
| } |
| |
| fn foo() { |
| var a = non_uniform; |
| var b = 0; |
| bar(&a, &b); |
| if (b == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:3 note: control flow depends on possibly non-uniform value |
| if (b == 0) { |
| ^^ |
| |
| test:10:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var a = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, NonUniformPointerParameterBecomesUniform_BeforeUse) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(a : ptr<function, i32>, b : ptr<function, i32>) { |
| *a = 0; |
| *b = *a; |
| } |
| |
| fn foo() { |
| var a = non_uniform; |
| var b = 0; |
| bar(&a, &b); |
| if (b == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, UniformPointerParameterBecomesNonUniform_BeforeUse) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(a : ptr<function, i32>, b : ptr<function, i32>) { |
| *a = non_uniform; |
| *b = *a; |
| } |
| |
| fn foo() { |
| var a = 0; |
| var b = 0; |
| bar(&a, &b); |
| if (b == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:3 note: control flow depends on possibly non-uniform value |
| if (b == 0) { |
| ^^ |
| |
| test:12:11 note: contents of pointer may become non-uniform after calling 'bar' |
| bar(&a, &b); |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, UniformPointerParameterBecomesNonUniform_AfterUse) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(a : ptr<function, i32>, b : ptr<function, i32>) { |
| *b = *a; |
| *a = non_uniform; |
| } |
| |
| fn foo() { |
| var a = 0; |
| var b = 0; |
| bar(&a, &b); |
| if (b == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, NonUniformPointerParameterUpdatedInPlace) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) { |
| (*p)++; |
| } |
| |
| fn foo() { |
| var v = non_uniform; |
| bar(&v); |
| if (v == 1) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:12:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (v == 1) { |
| ^^ |
| |
| test:9:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var v = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MultiplePointerParametersBecomeNonUniform) { |
| // The analysis traverses the tree for each pointer parameter, and we need to make sure that we |
| // reset the "visited" state of nodes in between these traversals to properly capture each of |
| // their uniformity states. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(a : ptr<function, i32>, b : ptr<function, i32>) { |
| *a = non_uniform; |
| *b = non_uniform; |
| } |
| |
| fn foo() { |
| var a = 0; |
| var b = 0; |
| bar(&a, &b); |
| if (b == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:3 note: control flow depends on possibly non-uniform value |
| if (b == 0) { |
| ^^ |
| |
| test:12:11 note: contents of pointer may become non-uniform after calling 'bar' |
| bar(&a, &b); |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MultiplePointerParametersWithEdgesToEachOther) { |
| // The analysis traverses the tree for each pointer parameter, and we need to make sure that we |
| // reset the "visited" state of nodes in between these traversals to properly capture each of |
| // their uniformity states. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(a : ptr<function, i32>, b : ptr<function, i32>, c : ptr<function, i32>) { |
| *a = *a; |
| *b = *b; |
| *c = *a + *b; |
| } |
| |
| fn foo() { |
| var a = non_uniform; |
| var b = 0; |
| var c = 0; |
| bar(&a, &b, &c); |
| if (c == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:16:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:15:3 note: control flow depends on possibly non-uniform value |
| if (c == 0) { |
| ^^ |
| |
| test:11:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var a = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MaximumNumberOfPointerParameters) { |
| // Create a function with the maximum number of parameters, all pointers, to stress the |
| // quadratic nature of the analysis. |
| ProgramBuilder b; |
| auto& ty = b.ty; |
| |
| // fn foo(p0 : ptr<function, i32>, p1 : ptr<function, i32>, ...) { |
| // let rhs = *p0 + *p1 + ... + *p244; |
| // *p1 = rhs; |
| // *p2 = rhs; |
| // ... |
| // *p254 = rhs; |
| // } |
| Vector<const ast::Parameter*, 8> params; |
| Vector<const ast::Statement*, 8> foo_body; |
| const ast::Expression* rhs_init = b.Deref("p0"); |
| for (int i = 1; i < 255; i++) { |
| rhs_init = b.Add(rhs_init, b.Deref("p" + std::to_string(i))); |
| } |
| foo_body.Push(b.Decl(b.Let("rhs", rhs_init))); |
| for (int i = 0; i < 255; i++) { |
| params.Push(b.Param("p" + std::to_string(i), ty.ptr<function, i32>())); |
| if (i > 0) { |
| foo_body.Push(b.Assign(b.Deref("p" + std::to_string(i)), "rhs")); |
| } |
| } |
| b.Func("foo", std::move(params), ty.void_(), foo_body); |
| |
| // var<private> non_uniform_global : i32; |
| // fn main() { |
| // var v0 : i32; |
| // var v1 : i32; |
| // ... |
| // var v254 : i32; |
| // v0 = non_uniform_global; |
| // foo(&v0, &v1, ..., &v254); |
| // if (v254 == 0) { |
| // workgroupBarrier(); |
| // } |
| // } |
| b.GlobalVar("non_uniform_global", ty.i32(), core::AddressSpace::kPrivate); |
| Vector<const ast::Statement*, 8> main_body; |
| Vector<const ast::Expression*, 8> args; |
| for (int i = 0; i < 255; i++) { |
| auto name = "v" + std::to_string(i); |
| main_body.Push(b.Decl(b.Var(name, ty.i32()))); |
| args.Push(b.AddressOf(name)); |
| } |
| main_body.Push(b.Assign("v0", "non_uniform_global")); |
| main_body.Push(b.CallStmt(b.Call("foo", args))); |
| main_body.Push(b.If(b.Equal("v254", 0_i), b.Block(b.CallStmt(b.Call("workgroupBarrier"))))); |
| b.Func("main", tint::Empty, ty.void_(), main_body); |
| |
| RunTest(std::move(b), false); |
| EXPECT_EQ(error_, |
| R"(error: 'workgroupBarrier' must only be called from uniform control flow |
| note: control flow depends on possibly non-uniform value |
| note: reading from module-scope private variable 'non_uniform_global' may result in a non-uniform value)"); |
| } |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// Tests to cover access to aggregate types. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_Uniform) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> v : vec4<i32>; |
| |
| fn foo() { |
| if (v[2] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_NonUniform) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> v : array<i32>; |
| |
| fn foo() { |
| if (v[2] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (v[2] == 0) { |
| ^^ |
| |
| test:5:7 note: reading from read_write storage buffer 'v' may result in a non-uniform value |
| if (v[2] == 0) { |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_BecomesNonUniform_BeforeCondition) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[2] = rw; |
| if (v[2] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (v[2] == 0) { |
| ^^ |
| |
| test:6:10 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| v[2] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_BecomesNonUniform_AfterCondition) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| if (v[2] == 0) { |
| v[2] = rw; |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_DifferentElementBecomesNonUniform) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[1] = rw; |
| if (v[2] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (v[2] == 0) { |
| ^^ |
| |
| test:6:10 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| v[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_ElementBecomesUniform) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, that element is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[1] = rw; |
| v[1] = 42; |
| if (v[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (v[1] == 0) { |
| ^^ |
| |
| test:6:10 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| v[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_VectorBecomesUniform_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[1] = rw; |
| v = vec4(1, 2, 3, 4); |
| if (v[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElementViaMember_VectorBecomesUniform_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v.y = rw; |
| v = vec4(1, 2, 3, 4); |
| if (v.y == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_VectorBecomesUniform_ThroughPointer_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[1] = rw; |
| *(&v) = vec4(1, 2, 3, 4); |
| if (v[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| VectorElement_VectorBecomesUniform_ThroughPointerChain_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[1] = rw; |
| *(&(*(&(*(&v))))) = vec4(1, 2, 3, 4); |
| if (v[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| VectorElement_VectorBecomesUniform_ThroughCapturedPointer_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[1] = rw; |
| let p = &v; |
| *p = vec4(1, 2, 3, 4); |
| if (v[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_VectorBecomesUniform_PartialAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[1] = rw; |
| v = vec4(1, 2, 3, v[3]); |
| if (v[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (v[1] == 0) { |
| ^^ |
| |
| test:6:10 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| v[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElementViaMember_VectorBecomesUniform_PartialAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v.y = rw; |
| v = vec4(1, 2, 3, v.w); |
| if (v.y == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (v.y == 0) { |
| ^^ |
| |
| test:6:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| v.y = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_DifferentElementBecomesUniform) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, the whole vector |
| // is still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[1] = rw; |
| v[2] = 42; |
| if (v[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (v[1] == 0) { |
| ^^ |
| |
| test:6:10 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| v[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, VectorElement_NonUniform_AnyBuiltin) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn foo() { |
| var v : vec4<i32>; |
| v[1] = non_uniform_global; |
| if (any(v == vec4(42))) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (any(v == vec4(42))) { |
| ^^ |
| |
| test:6:10 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| v[1] = non_uniform_global; |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_ElementBecomesUniform) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, that element is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| m[1][1] = 42.0; |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:6:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_ElementBecomesUniform_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| m = mat3x3<f32>(vec3(1.0, 2.0, 3.0), vec3(4.0, 5.0, 6.0), vec3(7.0, 8.0, 9.0)); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_ElementBecomesUniform_ThroughPointer_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| *(&m) = mat3x3<f32>(vec3(1.0, 2.0, 3.0), vec3(4.0, 5.0, 6.0), vec3(7.0, 8.0, 9.0)); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| MatrixElement_ElementBecomesUniform_ThroughPointerChain_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| *(&(*(&(*(&m))))) = mat3x3<f32>(vec3(1.0, 2.0, 3.0), vec3(4.0, 5.0, 6.0), vec3(7.0, 8.0, 9.0)); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| MatrixElement_ElementBecomesUniform_ThroughCapturedPointer_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| let p = &m; |
| *p = mat3x3<f32>(vec3(1.0, 2.0, 3.0), vec3(4.0, 5.0, 6.0), vec3(7.0, 8.0, 9.0)); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_ColumnBecomesUniform) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, that element is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| m[1] = vec3(0.0, 42.0, 0.0); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:6:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_ColumnBecomesUniform_ThroughPartialPointer) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, that element is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| *(&(m[1])) = vec3(0.0, 42.0, 0.0); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:6:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_ColumnBecomesUniform_ThroughPartialPointerChain) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, that element is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| *(&(*(&(m[1])))) = vec3(0.0, 42.0, 0.0); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:6:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_ColumnBecomesUniform_ThroughCapturedPartialPointer) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, that element is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| let p = &m[1]; |
| m[1][1] = rw; |
| *p = vec3(0.0, 42.0, 0.0); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:7:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| MatrixElement_ColumnBecomesUniform_ThroughCapturedPartialPointerChain) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, that element is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| let p = &m[1]; |
| m[1][1] = rw; |
| *(&(*p)) = vec3(0.0, 42.0, 0.0); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:7:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_ColumnBecomesUniform_ThroughCapturedPointer) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, that element is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| let p = &m; |
| m[1][1] = rw; |
| (*p)[1] = vec3(0.0, 42.0, 0.0); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:7:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_MatrixBecomesUniform_PartialAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| m = mat3x3<f32>(vec3(1.0, 2.0, 3.0), vec3(4.0, 5.0, 6.0), m[2]); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:6:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| MatrixElement_MatrixBecomesUniform_PartialAssignment_ThroughPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| *(&m) = mat3x3<f32>(vec3(1.0, 2.0, 3.0), vec3(4.0, 5.0, 6.0), m[2]); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:6:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| MatrixElement_MatrixBecomesUniform_PartialAssignment_ThroughCapturedPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| let p = &m; |
| m[1][1] = rw; |
| *p = mat3x3<f32>(vec3(1.0, 2.0, 3.0), vec3(4.0, 5.0, 6.0), (*p)[2]); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:7:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| MatrixElement_MatrixBecomesUniform_PartialAssignment_ThroughCapturedPointerChain) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| let p = &(*(&m)); |
| m[1][1] = rw; |
| *p = mat3x3<f32>(vec3(1.0, 2.0, 3.0), vec3(4.0, 5.0, 6.0), (*p)[2]); |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:7:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, MatrixElement_DifferentElementBecomesUniform) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : f32; |
| |
| fn foo() { |
| var m : mat3x3<f32>; |
| m[1][1] = rw; |
| m[2][2] = 42.0; |
| if (m[1][1] == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (m[1][1] == 0.0) { |
| ^^ |
| |
| test:6:13 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| m[1][1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_Uniform) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read> s : S; |
| |
| fn foo() { |
| if (s.b == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_NonUniform) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> s : S; |
| |
| fn foo() { |
| if (s.b == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (s.b == 0) { |
| ^^ |
| |
| test:9:7 note: reading from read_write storage buffer 's' may result in a non-uniform value |
| if (s.b == 0) { |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_BecomesNonUniform_BeforeCondition) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| s.b = rw; |
| if (s.b == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:12:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (s.b == 0) { |
| ^^ |
| |
| test:10:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.b = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_BecomesNonUniform_AfterCondition) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| if (s.b == 0) { |
| s.b = rw; |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_DifferentMemberBecomesNonUniform) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| s.a = rw; |
| if (s.b == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:12:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (s.b == 0) { |
| ^^ |
| |
| test:10:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_MemberBecomesUniform) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to a member, that member is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| s.a = rw; |
| s.a = 0; |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:13:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:12:3 note: control flow depends on possibly non-uniform value |
| if (s.a == 0) { |
| ^^ |
| |
| test:10:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_MemberBecomesUniformThroughCapturedPointer) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to a member, that member is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| let p = &s; |
| s.a = rw; |
| (*p).a = 0; |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:3 note: control flow depends on possibly non-uniform value |
| if (s.a == 0) { |
| ^^ |
| |
| test:11:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_MemberBecomesUniformThroughPartialPointer) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to a member, that member is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| s.a = rw; |
| *&s.a = 0; |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:13:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:12:3 note: control flow depends on possibly non-uniform value |
| if (s.a == 0) { |
| ^^ |
| |
| test:10:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_MemberBecomesUniformThroughCapturedPartialPointer) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to a member, that member is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| let p = &s.a; |
| s.a = rw; |
| (*p) = 0; |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:3 note: control flow depends on possibly non-uniform value |
| if (s.a == 0) { |
| ^^ |
| |
| test:11:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_StructBecomesUniform_FullAssignment) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| s.a = rw; |
| s = S(1, 2); |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_StructBecomesUniform_PartialAssignment) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| s.a = rw; |
| s = S(1, s.b); |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:13:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:12:3 note: control flow depends on possibly non-uniform value |
| if (s.a == 0) { |
| ^^ |
| |
| test:10:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_StructBecomesUniform_FullAssignment_ThroughPointer) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| s.a = rw; |
| *(&s) = S(1, 2); |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| StructMember_StructBecomesUniform_FullAssignment_ThroughCapturedPointer) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| let p = &s; |
| s.a = rw; |
| *p = S(1, 2); |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| StructMember_StructBecomesUniform_FullAssignment_ThroughCapturedPointerChain) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| let p = &(*(&s)); |
| s.a = rw; |
| *p = S(1, 2); |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_StructBecomesUniform_PartialAssignment_ThroughPointer) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| s.a = rw; |
| *(&s) = S(1, (*(&s)).b); |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:13:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:12:3 note: control flow depends on possibly non-uniform value |
| if (s.a == 0) { |
| ^^ |
| |
| test:10:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| StructMember_StructBecomesUniform_PartialAssignment_ThroughCapturedPointer) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| let p = &s; |
| s.a = rw; |
| *p = S(1, (*p).b); |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:3 note: control flow depends on possibly non-uniform value |
| if (s.a == 0) { |
| ^^ |
| |
| test:11:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| StructMember_StructBecomesUniform_PartialAssignment_ThroughCapturedPointerChain) { |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| let p = &(*(&s)); |
| s.a = rw; |
| *p = S(1, (*p).b); |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:3 note: control flow depends on possibly non-uniform value |
| if (s.a == 0) { |
| ^^ |
| |
| test:11:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StructMember_DifferentMemberBecomesUniform) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to a member, the whole struct |
| // is still considered to be non-uniform. |
| std::string src = R"( |
| struct S { |
| a : i32, |
| b : i32, |
| } |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var s : S; |
| s.a = rw; |
| s.b = 0; |
| if (s.a == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:13:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:12:3 note: control flow depends on possibly non-uniform value |
| if (s.a == 0) { |
| ^^ |
| |
| test:10:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| s.a = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_Uniform) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> arr : array<i32>; |
| |
| fn foo() { |
| if (arr[7] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_NonUniform) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> arr : array<i32>; |
| |
| fn foo() { |
| if (arr[7] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (arr[7] == 0) { |
| ^^ |
| |
| test:5:7 note: reading from read_write storage buffer 'arr' may result in a non-uniform value |
| if (arr[7] == 0) { |
| ^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_BecomesNonUniform_BeforeCondition) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[2] = rw; |
| if (arr[2] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (arr[2] == 0) { |
| ^^ |
| |
| test:6:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[2] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_BecomesNonUniform_AfterCondition) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| if (arr[2] == 0) { |
| arr[2] = rw; |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_DifferentElementBecomesNonUniform) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[1] = rw; |
| if (arr[2] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (arr[2] == 0) { |
| ^^ |
| |
| test:6:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| ArrayElement_DifferentElementBecomesNonUniformThroughPartialPointer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| let pa = &arr[1]; |
| *pa = rw; |
| if (arr[2] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (arr[2] == 0) { |
| ^^ |
| |
| test:7:9 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| *pa = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_ElementBecomesUniform) { |
| // For aggregate types, we conservatively consider them to be forever non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, that element is |
| // still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[1] = rw; |
| arr[1] = 42; |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (arr[1] == 0) { |
| ^^ |
| |
| test:6:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_ElementBecomesUniform_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[1] = rw; |
| arr = array<i32, 4>(1, 2, 3, 4); |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_ElementBecomesUniform_PartialAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[1] = rw; |
| arr = array<i32, 4>(1, 2, 3, arr[3]); |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (arr[1] == 0) { |
| ^^ |
| |
| test:6:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_DifferentElementBecomesUniform) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element, the whole array |
| // is still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[1] = rw; |
| arr[2] = 42; |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (arr[1] == 0) { |
| ^^ |
| |
| test:6:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_ElementBecomesUniform_ThroughPartialPointer) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element through a |
| // pointer, the whole array is still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[1] = rw; |
| *(&(arr[2])) = 42; |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (arr[1] == 0) { |
| ^^ |
| |
| test:6:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_ElementBecomesUniform_ThroughPartialPointerChain) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element through a |
| // pointer, the whole array is still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[1] = rw; |
| *(&(*(&(*(&(arr[2])))))) = 42; |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:9:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:8:3 note: control flow depends on possibly non-uniform value |
| if (arr[1] == 0) { |
| ^^ |
| |
| test:6:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_ElementBecomesUniform_ThroughCapturedPartialPointer) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element through a |
| // pointer, the whole array is still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| let pa = &arr[2]; |
| arr[1] = rw; |
| *pa = 42; |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (arr[1] == 0) { |
| ^^ |
| |
| test:7:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| ArrayElement_ElementBecomesUniform_ThroughCapturedPartialPointerChain) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element through a |
| // pointer, the whole array is still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| let pa = &(*(&arr[2])); |
| arr[1] = rw; |
| *pa = 42; |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (arr[1] == 0) { |
| ^^ |
| |
| test:7:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_ElementBecomesUniform_ThroughCapturedPointer) { |
| // For aggregate types, we conservatively consider them to be non-uniform once they |
| // become non-uniform. Test that after assigning a uniform value to an element through a |
| // pointer, the whole array is still considered to be non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| let pa = &arr; |
| arr[1] = rw; |
| (*pa)[2] = 42; |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (arr[1] == 0) { |
| ^^ |
| |
| test:7:12 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| arr[1] = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayElement_ArrayBecomesUniform_ThroughPointer_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[1] = rw; |
| *(&arr) = array<i32, 4>(); |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| ArrayElement_ArrayBecomesUniform_ThroughPointerChain_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| arr[1] = rw; |
| *(&(*(&(*(&arr))))) = array<i32, 4>(); |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| ArrayElement_ArrayBecomesUniform_ThroughCapturedPointer_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| let pa = &arr; |
| arr[1] = rw; |
| *pa = array<i32, 4>(); |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, |
| ArrayElement_ArrayBecomesUniform_ThroughCapturedPointerChain_FullAssignment) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var arr : array<i32, 4>; |
| let pa = &(*(&arr)); |
| arr[1] = rw; |
| *pa = array<i32, 4>(); |
| if (arr[1] == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// Miscellaneous statement and expression tests. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| TEST_F(UniformityAnalysisTest, NonUniformDiscard) { |
| // Non-uniform discard statements should not cause uniformity issues. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| discard; |
| } |
| _ = dpdx(1.0); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, FunctionReconvergesOnExit) { |
| // Call a function that has returns during non-uniform control flow, and test that the analysis |
| // reconverges when returning to the caller. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| var<private> p : i32; |
| |
| fn foo() { |
| if (rw == 0) { |
| p = 42; |
| return; |
| } |
| p = 5; |
| return; |
| } |
| |
| fn main() { |
| foo(); |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, TypeInitializer) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn foo() { |
| if (i32(non_uniform_global) == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (i32(non_uniform_global) == 0) { |
| ^^ |
| |
| test:5:11 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if (i32(non_uniform_global) == 0) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Conversion) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn foo() { |
| if (f32(non_uniform_global) == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (f32(non_uniform_global) == 0.0) { |
| ^^ |
| |
| test:5:11 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if (f32(non_uniform_global) == 0.0) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Bitcast) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn foo() { |
| if (bitcast<f32>(non_uniform_global) == 0.0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (bitcast<f32>(non_uniform_global) == 0.0) { |
| ^^ |
| |
| test:5:20 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| if (bitcast<f32>(non_uniform_global) == 0.0) { |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, CompoundAssignment_NonUniformRHS) { |
| // Use compound assignment with a non-uniform RHS on a variable. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v = 0; |
| v += rw; |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:6:8 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| v += rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, CompoundAssignment_UniformRHS_StillNonUniform) { |
| // Use compound assignment with a uniform RHS on a variable that is already non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v = rw; |
| v += 1; |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:5:11 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| var v = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, CompoundAssignment_Global) { |
| // Use compound assignment on a global variable. |
| // Tests that we do not assume there is always a variable node for the LHS, but we still process |
| // the expression. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| var<private> v : array<i32, 4>; |
| |
| fn bar(p : ptr<function, i32>) -> i32 { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| return 0; |
| } |
| |
| fn foo() { |
| var f = rw; |
| v[bar(&f)] += 1; |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:7:8 note: parameter 'p' of 'bar' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:15:9 note: possibly non-uniform value passed via pointer here |
| v[bar(&f)] += 1; |
| ^ |
| |
| test:14:11 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| var f = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IncDec_StillNonUniform) { |
| // Use increment on a variable that is already non-uniform. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| var v = rw; |
| v++; |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (v == 0) { |
| ^^ |
| |
| test:5:11 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| var v = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IncDec_Global) { |
| // Use increment on a global variable. |
| // Tests that we do not assume there is always a variable node for the LHS, but we still process |
| // the expression. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| var<private> v : array<i32, 4>; |
| |
| fn bar(p : ptr<function, i32>) -> i32 { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| return 0; |
| } |
| |
| fn foo() { |
| var f = rw; |
| v[bar(&f)]++; |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:7:8 note: parameter 'p' of 'bar' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:15:9 note: possibly non-uniform value passed via pointer here |
| v[bar(&f)]++; |
| ^ |
| |
| test:14:11 note: reading from read_write storage buffer 'rw' may result in a non-uniform value |
| var f = rw; |
| ^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignmentEval_LHS_Then_RHS_Pass) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn b(p : ptr<function, i32>) -> i32 { |
| *p = non_uniform; |
| return 0; |
| } |
| |
| fn a(p : ptr<function, i32>) -> i32 { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| return 0; |
| } |
| |
| fn foo() { |
| var i = 0; |
| var arr : array<i32, 4>; |
| arr[a(&i)] = arr[b(&i)]; |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, AssignmentEval_LHS_Then_RHS_Fail) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn a(p : ptr<function, i32>) -> i32 { |
| *p = non_uniform; |
| return 0; |
| } |
| |
| fn b(p : ptr<function, i32>) -> i32 { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| return 0; |
| } |
| |
| fn foo() { |
| var i = 0; |
| var arr : array<i32, 4>; |
| arr[a(&i)] = arr[b(&i)]; |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:11:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:10:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:10:8 note: parameter 'p' of 'b' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:19:22 note: possibly non-uniform value passed via pointer here |
| arr[a(&i)] = arr[b(&i)]; |
| ^ |
| |
| test:19:9 note: contents of pointer may become non-uniform after calling 'a' |
| arr[a(&i)] = arr[b(&i)]; |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, CompoundAssignmentEval_LHS_Then_RHS_Pass) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn b(p : ptr<function, i32>) -> i32 { |
| *p = non_uniform; |
| return 0; |
| } |
| |
| fn a(p : ptr<function, i32>) -> i32 { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| return 0; |
| } |
| |
| fn foo() { |
| var i = 0; |
| var arr : array<i32, 4>; |
| arr[a(&i)] += arr[b(&i)]; |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, CompoundAssignmentEval_LHS_Then_RHS_Fail) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn a(p : ptr<function, i32>) -> i32 { |
| *p = non_uniform; |
| return 0; |
| } |
| |
| fn b(p : ptr<function, i32>) -> i32 { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| return 0; |
| } |
| |
| fn foo() { |
| var i = 0; |
| var arr : array<i32, 4>; |
| arr[a(&i)] += arr[b(&i)]; |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:11:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:10:3 note: control flow depends on possibly non-uniform value |
| if (*p == 0) { |
| ^^ |
| |
| test:10:8 note: parameter 'p' of 'b' may be non-uniform |
| if (*p == 0) { |
| ^ |
| |
| test:19:23 note: possibly non-uniform value passed via pointer here |
| arr[a(&i)] += arr[b(&i)]; |
| ^ |
| |
| test:19:9 note: contents of pointer may become non-uniform after calling 'a' |
| arr[a(&i)] += arr[b(&i)]; |
| ^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, CompoundAssignmentEval_RHS_Makes_LHS_NonUniform_After_Load) { |
| // Test that the LHS is loaded from before the RHS makes is evaluated. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) -> i32 { |
| *p = non_uniform; |
| return 0; |
| } |
| |
| fn foo() { |
| var i = 0; |
| var arr : array<i32, 4>; |
| i += arr[bar(&i)]; |
| if (i == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, CompoundAssignmentEval_RHS_Makes_LHS_Uniform_After_Load) { |
| // Test that the LHS is loaded from before the RHS makes is evaluated. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) -> i32 { |
| *p = 0; |
| return 0; |
| } |
| |
| fn foo() { |
| var i = non_uniform; |
| var arr : array<i32, 4>; |
| i += arr[bar(&i)]; |
| if (i == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:3 note: control flow depends on possibly non-uniform value |
| if (i == 0) { |
| ^^ |
| |
| test:10:11 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| var i = non_uniform; |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, CompoundAssignmentEval_LHS_OnlyOnce) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) -> i32 { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| *p = non_uniform; |
| return 0; |
| } |
| |
| fn foo(){ |
| var f : i32 = 0; |
| var arr : array<i32, 4>; |
| arr[bar(&f)] += 1; |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, IncDec_LHS_OnlyOnce) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar(p : ptr<function, i32>) -> i32 { |
| if (*p == 0) { |
| workgroupBarrier(); |
| } |
| *p = non_uniform; |
| return 0; |
| } |
| |
| fn foo(){ |
| var f : i32 = 0; |
| var arr : array<i32, 4>; |
| arr[bar(&f)]++; |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ShortCircuiting_UniformLHS) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read> uniform_global : i32; |
| |
| fn main() { |
| let b = (uniform_global == 0) && (dpdx(1.0) == 0.0); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ShortCircuiting_NonUniformLHS) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn main() { |
| let b = (non_uniform_global == 0) && (dpdx(1.0) == 0.0); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:5:41 error: 'dpdx' must only be called from uniform control flow |
| let b = (non_uniform_global == 0) && (dpdx(1.0) == 0.0); |
| ^^^^^^^^^ |
| |
| test:5:37 note: control flow depends on possibly non-uniform value |
| let b = (non_uniform_global == 0) && (dpdx(1.0) == 0.0); |
| ^^ |
| |
| test:5:12 note: reading from read_write storage buffer 'non_uniform_global' may result in a non-uniform value |
| let b = (non_uniform_global == 0) && (dpdx(1.0) == 0.0); |
| ^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ShortCircuiting_ReconvergeLHS) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn main() { |
| let b = (non_uniform_global == 0) && false; |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ShortCircuiting_ReconvergeRHS) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn main() { |
| let b = false && (non_uniform_global == 0); |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ShortCircuiting_ReconvergeBoth) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform_global : i32; |
| |
| fn main() { |
| let b = (non_uniform_global != 0) && (non_uniform_global != 42); |
| workgroupBarrier(); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, DeadCode_AfterReturn) { |
| // Dead code after a return statement shouldn't cause uniformity errors. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| return; |
| if (non_uniform == 42) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayLength) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> arr : array<f32>; |
| |
| fn foo() { |
| for (var i = 0u; i < arrayLength(&arr); i++) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayLength_OnPtrArg) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> arr : array<f32>; |
| |
| fn bar(p : ptr<storage, array<f32>, read_write>) { |
| for (var i = 0u; i < arrayLength(p); i++) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn foo() { |
| bar(&arr); |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayLength_PtrArgRequiredToBeUniformForRetval_Pass) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> arr : array<f32>; |
| |
| fn length(p : ptr<storage, array<f32>, read_write>) -> u32 { |
| return arrayLength(p); |
| } |
| |
| fn foo() { |
| for (var i = 0u; i < length(&arr); i++) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| // TODO(jrprice): This test requires variable pointers. |
| TEST_F(UniformityAnalysisTest, DISABLED_ArrayLength_PtrArgRequiredToBeUniformForRetval_Fail) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var<storage, read_write> arr1 : array<f32>; |
| @group(0) @binding(2) var<storage, read_write> arr2 : array<f32>; |
| |
| fn length(p : ptr<storage, array<f32>, read_write>) -> u32 { |
| return arrayLength(p); |
| } |
| |
| fn foo() { |
| let non_uniform_ptr = select(&arr1, &arr2, non_uniform == 0); |
| let len = length(non_uniform_ptr); |
| if (len > 10) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:16:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:15:3 note: control flow depends on non-uniform value |
| if (len > 10) { |
| ^^ |
| |
| test:14:20 note: passing non-uniform pointer to 'length' may produce a non-uniform output |
| let len = length(non_uniform_ptr, &len); |
| ^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayLength_PtrArgRequiredToBeUniformForOtherPtrResult_Pass) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> arr : array<f32>; |
| |
| fn length(p : ptr<storage, array<f32>, read_write>, out : ptr<function, u32>) { |
| *out = arrayLength(p); |
| } |
| |
| fn foo() { |
| var len : u32; |
| length(&arr, &len); |
| if (len > 10) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| // TODO(jrprice): This test requires variable pointers. |
| TEST_F(UniformityAnalysisTest, |
| DISABLED_ArrayLength_PtrArgRequiredToBeUniformForOtherPtrResult_Fail) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var<storage, read_write> arr1 : array<f32>; |
| @group(0) @binding(2) var<storage, read_write> arr2 : array<f32>; |
| |
| fn length(p : ptr<storage, array<f32>, read_write>, out : ptr<function, u32>) { |
| *out = arrayLength(p); |
| } |
| |
| fn foo() { |
| var len : u32; |
| let non_uniform_ptr = select(&arr1, &arr2, non_uniform == 0); |
| length(non_uniform_ptr, &len); |
| if (len > 10) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:17:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:16:3 note: control flow depends on non-uniform value |
| if (len > 10) { |
| ^^ |
| |
| test:15:10 note: passing non-uniform pointer to 'length' may produce a non-uniform output |
| length(non_uniform_ptr, &len); |
| ^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, ArrayLength_PtrArgRequiresUniformityAndAffectsReturnValue) { |
| // Test that a single pointer argument can directly require uniformity as well as affecting the |
| // uniformity of the return value. |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| @group(0) @binding(0) var<storage, read_write> arr : array<u32>; |
| |
| fn bar(p : ptr<storage, array<u32>, read_write>) -> u32 { |
| // This requires `p` to always be uniform. |
| if (arrayLength(p) == 10) { |
| workgroupBarrier(); |
| } |
| |
| // This requires the contents of `p` to be uniform in order for the return value to be uniform. |
| return (*p)[0]; |
| } |
| |
| fn foo() { |
| let p = &arr; |
| // We pass a uniform pointer, so the direct uniformity requirement on the parameter is satisfied. |
| if (0 == bar(p)) { |
| // This will fail as the return value of `p` is non-uniform due to non-uniform contents of `p`. |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:21:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:19:3 note: control flow depends on possibly non-uniform value |
| if (0 == bar(p)) { |
| ^^ |
| |
| test:4:48 note: reading from read_write storage buffer 'arr' may result in a non-uniform value |
| @group(0) @binding(0) var<storage, read_write> arr : array<u32>; |
| ^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, WorkgroupUniformLoad) { |
| std::string src = R"( |
| const wgsize = 4; |
| var<workgroup> data : array<u32, wgsize>; |
| |
| @compute @workgroup_size(wgsize) |
| fn main(@builtin(local_invocation_index) idx : u32) { |
| data[idx] = idx + 1; |
| if (workgroupUniformLoad(&data[0]) > 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, WorkgroupUniformLoad_ViaPtrArg) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| const wgsize = 4; |
| var<workgroup> data : array<u32, wgsize>; |
| |
| fn foo(p : ptr<workgroup, u32>) -> u32 { |
| return workgroupUniformLoad(p); |
| } |
| |
| @compute @workgroup_size(wgsize) |
| fn main(@builtin(local_invocation_index) idx : u32) { |
| data[idx] = idx + 1; |
| if (foo(&data[0]) > 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, WorkgroupUniformLoad_NonUniformPtr) { |
| std::string src = R"( |
| const wgsize = 4; |
| var<workgroup> data : array<u32, wgsize>; |
| |
| @compute @workgroup_size(wgsize) |
| fn main(@builtin(local_invocation_index) idx : u32) { |
| data[idx] = idx + 1; |
| if (workgroupUniformLoad(&data[idx]) > 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:28 error: possibly non-uniform value passed here |
| if (workgroupUniformLoad(&data[idx]) > 0) { |
| ^ |
| |
| test:8:34 note: builtin 'idx' of 'main' may be non-uniform |
| if (workgroupUniformLoad(&data[idx]) > 0) { |
| ^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, WorkgroupUniformLoad_NonUniformPtr_ViaPtrArg) { |
| std::string src = R"( |
| enable chromium_experimental_full_ptr_parameters; |
| |
| const wgsize = 4; |
| var<workgroup> data : array<u32, wgsize>; |
| |
| fn foo(p : ptr<workgroup, u32>) -> u32 { |
| return workgroupUniformLoad(p); |
| } |
| |
| @compute @workgroup_size(wgsize) |
| fn main(@builtin(local_invocation_index) idx : u32) { |
| data[idx] = idx + 1; |
| if (foo(&data[idx]) > 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:31 error: possibly non-uniform value passed here |
| return workgroupUniformLoad(p); |
| ^ |
| |
| test:8:31 note: parameter 'p' of 'foo' may be non-uniform |
| return workgroupUniformLoad(p); |
| ^ |
| |
| test:14:11 note: possibly non-uniform value passed here |
| if (foo(&data[idx]) > 0) { |
| ^ |
| |
| test:14:17 note: builtin 'idx' of 'main' may be non-uniform |
| if (foo(&data[idx]) > 0) { |
| ^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, WorkgroupAtomics) { |
| std::string src = R"( |
| var<workgroup> a : atomic<i32>; |
| |
| fn foo() { |
| if (atomicAdd(&a, 1) == 1) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (atomicAdd(&a, 1) == 1) { |
| ^^ |
| |
| test:5:7 note: return value of 'atomicAdd' may be non-uniform |
| if (atomicAdd(&a, 1) == 1) { |
| ^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StorageAtomics) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> a : atomic<i32>; |
| |
| fn foo() { |
| if (atomicAdd(&a, 1) == 1) { |
| storageBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'storageBarrier' must only be called from uniform control flow |
| storageBarrier(); |
| ^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (atomicAdd(&a, 1) == 1) { |
| ^^ |
| |
| test:5:7 note: return value of 'atomicAdd' may be non-uniform |
| if (atomicAdd(&a, 1) == 1) { |
| ^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StorageTextureLoad_ReadOnly) { |
| std::string src = R"( |
| enable chromium_experimental_read_write_storage_texture; |
| |
| @group(0) @binding(0) var t : texture_storage_2d<r32sint, read>; |
| |
| fn foo() { |
| if (textureLoad(t, vec2()).r == 0) { |
| storageBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StorageTextureLoad_ReadWrite) { |
| std::string src = R"( |
| enable chromium_experimental_read_write_storage_texture; |
| |
| @group(0) @binding(0) var t : texture_storage_2d<r32sint, read_write>; |
| |
| fn foo() { |
| if (textureLoad(t, vec2()).r == 0) { |
| storageBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:5 error: 'storageBarrier' must only be called from uniform control flow |
| storageBarrier(); |
| ^^^^^^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (textureLoad(t, vec2()).r == 0) { |
| ^^ |
| |
| test:7:7 note: return value of 'textureLoad' may be non-uniform |
| if (textureLoad(t, vec2()).r == 0) { |
| ^^^^^^^^^^^^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, DisableAnalysisWithExtension) { |
| std::string src = R"( |
| enable chromium_disable_uniformity_analysis; |
| |
| @group(0) @binding(0) var<storage, read_write> rw : i32; |
| |
| fn foo() { |
| if (rw == 0) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| } |
| |
| TEST_F(UniformityAnalysisTest, StressGraphTraversalDepth) { |
| // Create a function with a very long sequence of variable declarations and assignments to |
| // test traversals of very deep graphs. This requires a non-recursive traversal algorithm. |
| ProgramBuilder b; |
| auto& ty = b.ty; |
| |
| // var<private> v0 : i32 = 0i; |
| // fn foo() { |
| // let v1 = v0; |
| // let v2 = v1; |
| // ... |
| // let v{N} = v{N-1}; |
| // if (v{N} == 0) { |
| // workgroupBarrier(); |
| // } |
| // } |
| b.GlobalVar("v0", ty.i32(), core::AddressSpace::kPrivate, b.Expr(0_i)); |
| Vector<const ast::Statement*, 8> foo_body; |
| std::string v_last = "v0"; |
| for (int i = 1; i < 100000; i++) { |
| auto v = "v" + std::to_string(i); |
| foo_body.Push(b.Decl(b.Var(v, b.Expr(v_last)))); |
| v_last = v; |
| } |
| foo_body.Push(b.If(b.Equal(v_last, 0_i), b.Block(b.CallStmt(b.Call("workgroupBarrier"))))); |
| b.Func("foo", tint::Empty, ty.void_(), foo_body); |
| |
| RunTest(std::move(b), false); |
| EXPECT_EQ(error_, |
| R"(error: 'workgroupBarrier' must only be called from uniform control flow |
| note: control flow depends on possibly non-uniform value |
| note: reading from module-scope private variable 'v0' may result in a non-uniform value)"); |
| } |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// Tests for the derivative_uniformity diagnostic filter. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| class UniformityAnalysisDiagnosticFilterTest |
| : public UniformityAnalysisTestBase, |
| public ::testing::TestWithParam<wgsl::DiagnosticSeverity> { |
| protected: |
| // TODO(jrprice): Remove this in favour of tint::ToString() when we change "note" to "info". |
| const char* ToStr(wgsl::DiagnosticSeverity severity) { |
| switch (severity) { |
| case wgsl::DiagnosticSeverity::kError: |
| return "error"; |
| case wgsl::DiagnosticSeverity::kWarning: |
| return "warning"; |
| case wgsl::DiagnosticSeverity::kInfo: |
| return "note"; |
| default: |
| return "<undefined>"; |
| } |
| } |
| }; |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, Directive) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << "diagnostic(" << param << ", derivative_uniformity);" |
| << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var t : texture_2d<f32>; |
| @group(0) @binding(2) var s : sampler; |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| let color = textureSample(t, s, vec2(0, 0)); |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'textureSample' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnFunction) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var t : texture_2d<f32>; |
| @group(0) @binding(2) var s : sampler; |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << |
| R"(fn foo() { |
| if (non_uniform == 42) { |
| let color = textureSample(t, s, vec2(0, 0)); |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'textureSample' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnBlock) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var t : texture_2d<f32>; |
| @group(0) @binding(2) var s : sampler; |
| fn foo() { |
| if (non_uniform == 42))" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"({ |
| let color = textureSample(t, s, vec2(0, 0)); |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'textureSample' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnForStatement_CallInInitializer) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(for (var b = (non_uniform == 42 && dpdx(1.0) > 0.0); false;) { |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnForStatement_CallInCondition) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(for (; non_uniform == 42 && dpdx(1.0) > 0.0;) { |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnForStatement_CallInIncrement) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(for (var b = false; false; b = (non_uniform == 42 && dpdx(1.0) > 0.0)) { |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnForStatement_CallInBody) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var t : texture_2d<f32>; |
| @group(0) @binding(2) var s : sampler; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(for (; non_uniform == 42;) { |
| let color = textureSample(t, s, vec2(0, 0)); |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'textureSample' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnIfStatement_CallInCondition) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(if (non_uniform == 42 && dpdx(1.0) > 0.0) { |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnIfStatement_CallInBody) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var t : texture_2d<f32>; |
| @group(0) @binding(2) var s : sampler; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(if (non_uniform == 42) { |
| let color = textureSample(t, s, vec2(0, 0)); |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'textureSample' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnIfStatement_CallInElse) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var t : texture_2d<f32>; |
| @group(0) @binding(2) var s : sampler; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(if (non_uniform == 42) { |
| } else { |
| let color = textureSample(t, s, vec2(0, 0)); |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'textureSample' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnLoopStatement_CallInBody) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(loop { |
| _ = dpdx(1.0); |
| continuing { |
| break if non_uniform == 0; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnLoopStatement_CallInContinuing) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(loop { |
| continuing { |
| _ = dpdx(1.0); |
| break if non_uniform == 0; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnLoopBody_CallInBody) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| loop )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"( { |
| _ = dpdx(1.0); |
| continuing { |
| break if non_uniform == 0; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnLoopBody_CallInContinuing) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| loop )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"( { |
| continuing { |
| _ = dpdx(1.0); |
| break if non_uniform == 0; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnLoopContinuing_CallInContinuing) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| loop { |
| continuing )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"( { |
| _ = dpdx(1.0); |
| break if non_uniform == 0; |
| } |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnSwitchStatement_CallInCondition) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(switch (i32(non_uniform == 42 && dpdx(1.0) > 0.0)) { |
| default {} |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnSwitchStatement_CallInBody) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var t : texture_2d<f32>; |
| @group(0) @binding(2) var s : sampler; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(switch (non_uniform) { |
| default { |
| let color = textureSample(t, s, vec2(0, 0)); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'textureSample' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnSwitchBody_CallInBody) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var t : texture_2d<f32>; |
| @group(0) @binding(2) var s : sampler; |
| fn foo() { |
| switch (non_uniform))" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"( { |
| default { |
| let color = textureSample(t, s, vec2(0, 0)); |
| } |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'textureSample' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnWhileStatement_CallInCondition) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(while (non_uniform == 42 && dpdx(1.0) > 0.0) { |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'dpdx' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| TEST_P(UniformityAnalysisDiagnosticFilterTest, AttributeOnWhileStatement_CallInBody) { |
| auto& param = GetParam(); |
| StringStream ss; |
| ss << R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| @group(0) @binding(1) var t : texture_2d<f32>; |
| @group(0) @binding(2) var s : sampler; |
| fn foo() { |
| )" |
| << "@diagnostic(" << param << ", derivative_uniformity)" |
| << R"(while (non_uniform == 42) { |
| let color = textureSample(t, s, vec2(0, 0)); |
| } |
| } |
| )"; |
| |
| RunTest(ss.str(), param != wgsl::DiagnosticSeverity::kError); |
| if (param == wgsl::DiagnosticSeverity::kOff) { |
| EXPECT_TRUE(error_.empty()); |
| } else { |
| StringStream err; |
| err << ToStr(param) << ": 'textureSample' must only be called"; |
| EXPECT_THAT(error_, ::testing::HasSubstr(err.str())); |
| } |
| } |
| |
| INSTANTIATE_TEST_SUITE_P(UniformityAnalysisTest, |
| UniformityAnalysisDiagnosticFilterTest, |
| ::testing::Values(wgsl::DiagnosticSeverity::kError, |
| wgsl::DiagnosticSeverity::kWarning, |
| wgsl::DiagnosticSeverity::kInfo, |
| wgsl::DiagnosticSeverity::kOff)); |
| |
| TEST_F(UniformityAnalysisDiagnosticFilterTest, AttributeOnFunction_CalledByAnotherFunction) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| @diagnostic(info, derivative_uniformity) |
| fn bar() { |
| _ = dpdx(1.0); |
| } |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| bar(); |
| } |
| } |
| )"; |
| |
| RunTest(src, true); |
| EXPECT_THAT(error_, ::testing::HasSubstr("note: 'dpdx' must only be called")); |
| } |
| |
| TEST_F(UniformityAnalysisDiagnosticFilterTest, AttributeOnFunction_RequirementOnParameter) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| @diagnostic(info, derivative_uniformity) |
| fn bar(x : i32) { |
| if (x == 0) { |
| _ = dpdx(1.0); |
| } |
| } |
| |
| fn foo() { |
| bar(non_uniform); |
| } |
| )"; |
| |
| RunTest(src, true); |
| EXPECT_THAT(error_, ::testing::HasSubstr("note: 'dpdx' must only be called")); |
| } |
| |
| TEST_F(UniformityAnalysisDiagnosticFilterTest, AttributeOnFunction_BuiltinInChildCall) { |
| // Make sure that the diagnostic filter does not descend into functions called by the function |
| // with the attribute. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn bar() { |
| _ = dpdx(1.0); |
| } |
| |
| @diagnostic(off, derivative_uniformity) |
| fn foo() { |
| if (non_uniform == 42) { |
| bar(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_THAT(error_, ::testing::HasSubstr(": 'dpdx' must only be called")); |
| } |
| |
| TEST_F(UniformityAnalysisDiagnosticFilterTest, MixOfGlobalAndLocalFilters) { |
| // Test that a global filter is overridden by a local attribute, and that we find multiple |
| // violations until an error is found. |
| std::string src = R"( |
| diagnostic(info, derivative_uniformity); |
| |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn a() { |
| if (non_uniform == 42) { |
| _ = dpdx(1.0); |
| } |
| } |
| |
| @diagnostic(off, derivative_uniformity) |
| fn b() { |
| if (non_uniform == 42) { |
| _ = dpdx(1.0); |
| } |
| } |
| |
| @diagnostic(info, derivative_uniformity) |
| fn c() { |
| if (non_uniform == 42) { |
| _ = dpdx(1.0); |
| } |
| } |
| |
| @diagnostic(warning, derivative_uniformity) |
| fn d() { |
| if (non_uniform == 42) { |
| _ = dpdx(1.0); |
| } |
| } |
| |
| @diagnostic(error, derivative_uniformity) |
| fn e() { |
| if (non_uniform == 42) { |
| _ = dpdx(1.0); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:8:9 note: 'dpdx' must only be called from uniform control flow |
| _ = dpdx(1.0); |
| ^^^^^^^^^ |
| |
| test:7:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:7:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| |
| test:22:9 note: 'dpdx' must only be called from uniform control flow |
| _ = dpdx(1.0); |
| ^^^^^^^^^ |
| |
| test:21:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:21:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| |
| test:29:9 warning: 'dpdx' must only be called from uniform control flow |
| _ = dpdx(1.0); |
| ^^^^^^^^^ |
| |
| test:28:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:28:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| |
| test:36:9 error: 'dpdx' must only be called from uniform control flow |
| _ = dpdx(1.0); |
| ^^^^^^^^^ |
| |
| test:35:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:35:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisDiagnosticFilterTest, BuiltinReturnValueNotAffected) { |
| // Make sure that a diagnostic filter does not affect the uniformity of the return value of a |
| // derivative builtin. |
| std::string src = R"( |
| fn foo() { |
| var x: f32; |
| |
| @diagnostic(off,derivative_uniformity) { |
| x = dpdx(1.0); |
| } |
| |
| if (x < 0.5) { |
| _ = dpdy(1.0); // Should trigger an error |
| } |
| } |
| |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:10:9 error: 'dpdy' must only be called from uniform control flow |
| _ = dpdy(1.0); // Should trigger an error |
| ^^^^^^^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (x < 0.5) { |
| ^^ |
| |
| test:6:9 note: return value of 'dpdx' may be non-uniform |
| x = dpdx(1.0); |
| ^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisDiagnosticFilterTest, |
| ParameterRequiredToBeUniform_With_ParameterRequiredToBeUniformForReturnValue) { |
| // Make sure that both requirements on parameters are captured. |
| std::string src = R"( |
| @diagnostic(info,derivative_uniformity) |
| fn foo(x : bool) -> bool { |
| if (x) { |
| _ = dpdx(1.0); // Should trigger an info |
| } |
| return x; |
| } |
| |
| var<private> non_uniform: bool; |
| |
| @diagnostic(error,derivative_uniformity) |
| fn bar() { |
| let ret = foo(non_uniform); |
| if (ret) { |
| _ = dpdy(1.0); // Should trigger an error |
| } |
| } |
| |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:16:9 error: 'dpdy' must only be called from uniform control flow |
| _ = dpdy(1.0); // Should trigger an error |
| ^^^^^^^^^ |
| |
| test:15:3 note: control flow depends on possibly non-uniform value |
| if (ret) { |
| ^^ |
| |
| test:14:17 note: reading from module-scope private variable 'non_uniform' may result in a non-uniform value |
| let ret = foo(non_uniform); |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisDiagnosticFilterTest, BarriersNotAffected) { |
| // Make sure that the diagnostic filter does not affect barriers. |
| std::string src = R"( |
| diagnostic(off, derivative_uniformity); |
| |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| if (non_uniform == 42) { |
| _ = dpdx(1.0); |
| } |
| } |
| |
| fn bar() { |
| if (non_uniform == 42) { |
| workgroupBarrier(); |
| } |
| } |
| |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:14:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:13:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:13:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| //////////////////////////////////////////////////////////////////////////////// |
| /// Tests for the quality of the error messages produced by the analysis. |
| //////////////////////////////////////////////////////////////////////////////// |
| |
| TEST_F(UniformityAnalysisTest, Error_CallUserThatCallsBuiltinDirectly) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo() { |
| workgroupBarrier(); |
| } |
| |
| fn main() { |
| if (non_uniform == 42) { |
| foo(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:5:3 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:10:5 note: called by 'foo' from 'main' |
| foo(); |
| ^^^ |
| |
| test:9:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:9:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Error_CallUserThatCallsBuiltinIndirectly) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn zoo() { |
| workgroupBarrier(); |
| } |
| |
| fn bar() { |
| zoo(); |
| } |
| |
| fn foo() { |
| bar(); |
| } |
| |
| fn main() { |
| if (non_uniform == 42) { |
| foo(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:5:3 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:18:5 note: called indirectly by 'foo' from 'main' |
| foo(); |
| ^^^ |
| |
| test:17:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:17:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Error_ParametersRequireUniformityInChain) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn zoo(a : i32) { |
| if (a == 42) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn bar(b : i32) { |
| zoo(b); |
| } |
| |
| fn foo(c : i32) { |
| bar(c); |
| } |
| |
| fn main() { |
| foo(non_uniform); |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:5:3 note: control flow depends on possibly non-uniform value |
| if (a == 42) { |
| ^^ |
| |
| test:5:7 note: parameter 'a' of 'zoo' may be non-uniform |
| if (a == 42) { |
| ^ |
| |
| test:11:7 note: possibly non-uniform value passed here |
| zoo(b); |
| ^ |
| |
| test:11:7 note: parameter 'b' of 'bar' may be non-uniform |
| zoo(b); |
| ^ |
| |
| test:15:7 note: possibly non-uniform value passed here |
| bar(c); |
| ^ |
| |
| test:15:7 note: parameter 'c' of 'foo' may be non-uniform |
| bar(c); |
| ^ |
| |
| test:19:7 note: possibly non-uniform value passed here |
| foo(non_uniform); |
| ^^^^^^^^^^^ |
| |
| test:19:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| foo(non_uniform); |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Error_ReturnValueMayBeNonUniformChain) { |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn zoo() -> i32 { |
| return non_uniform; |
| } |
| |
| fn bar() -> i32 { |
| return zoo(); |
| } |
| |
| fn foo() -> i32 { |
| return bar(); |
| } |
| |
| fn main() { |
| if (foo() == 42) { |
| workgroupBarrier(); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:18:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:17:3 note: control flow depends on possibly non-uniform value |
| if (foo() == 42) { |
| ^^ |
| |
| test:17:7 note: return value of 'foo' may be non-uniform |
| if (foo() == 42) { |
| ^^^^^ |
| )"); |
| } |
| |
| TEST_F(UniformityAnalysisTest, Error_CallsiteAndParameterRequireUniformity) { |
| // Test that we report a violation for the callsite of a function when it has multiple |
| // uniformity requirements. |
| std::string src = R"( |
| @group(0) @binding(0) var<storage, read_write> non_uniform : i32; |
| |
| fn foo(v : i32) { |
| if (v == 0) { |
| workgroupBarrier(); |
| } |
| } |
| |
| fn main() { |
| if (non_uniform == 42) { |
| foo(0); |
| } |
| } |
| )"; |
| |
| RunTest(src, false); |
| EXPECT_EQ(error_, |
| R"(test:6:5 error: 'workgroupBarrier' must only be called from uniform control flow |
| workgroupBarrier(); |
| ^^^^^^^^^^^^^^^^ |
| |
| test:12:5 note: called by 'foo' from 'main' |
| foo(0); |
| ^^^ |
| |
| test:11:3 note: control flow depends on possibly non-uniform value |
| if (non_uniform == 42) { |
| ^^ |
| |
| test:11:7 note: reading from read_write storage buffer 'non_uniform' may result in a non-uniform value |
| if (non_uniform == 42) { |
| ^^^^^^^^^^^ |
| )"); |
| } |
| |
| } // namespace |
| } // namespace tint::resolver |
