commit e9bc506e0ab03dd7984ab5a6aade07651f2d9c17
author Corentin Wallez <cwallez@chromium.org> Wed Sep 02 12:56:29 2020 +0000
committer Commit Bot service account <commit-bot@chromium.org> Wed Sep 02 12:56:29 2020 +0000
tree 66a3d08844984742e59d88f168afbb234dd613f3
parent 5ffc1e1adb9b8f681d5a696f1b66f14dfa4fa928

TextureVk: Add a couple TODOs related to barriers.

Bug: None
Change-Id: I2da575ce7b79c92f5a2a320334e51e571f672b46
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/28003
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

src/dawn_native/vulkan/TextureVk.cpp

diff --git a/src/dawn_native/vulkan/TextureVk.cpp b/src/dawn_native/vulkan/TextureVk.cpp
index e61facd..f45e2b4 100644
--- a/src/dawn_native/vulkan/TextureVk.cpp
+++ b/src/dawn_native/vulkan/TextureVk.cpp
@@ -51,6 +51,8 @@
         }
 
         // Computes which vulkan access type could be required for the given Dawn usage.
+        // TODO(cwallez@chromium.org): We shouldn't need any access usages for srcAccessMask when
+        // the previous usage is readonly because an execution dependency is sufficient.
         VkAccessFlags VulkanAccessFlags(wgpu::TextureUsage usage, const Format& format) {
             VkAccessFlags flags = 0;
 
@@ -151,6 +153,9 @@
                 flags |= VK_PIPELINE_STAGE_TRANSFER_BIT;
             }
             if (usage & (wgpu::TextureUsage::Sampled | kReadonlyStorageTexture)) {
+                // TODO(cwallez@chromium.org): Only transition to the usage we care about to avoid
+                // introducing FS -> VS dependencies that would prevent parallelization on tiler
+                // GPUs
                 flags |= VK_PIPELINE_STAGE_VERTEX_SHADER_BIT |
                          VK_PIPELINE_STAGE_FRAGMENT_SHADER_BIT |
                          VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT;