Skip all the dawn_end2end_tests using glTextureView() on GLES
This patch skips all the dawn_end2end_tests using glTextureView() on the
OpenGL ES backend as glTextureView() is not available in OpenGL ES.
With this patch all the dawn_end2end_tests will be able to run on Intel
Mesa OpenGL ES drivers with no crash.
BUG=dawn:580
Change-Id: I420eebfd699edf745bd08cb941f3143aad2fbd06
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/36040
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
diff --git a/src/tests/end2end/CompressedTextureFormatTests.cpp b/src/tests/end2end/CompressedTextureFormatTests.cpp
index bbbe2ee..b0b3fc1 100644
--- a/src/tests/end2end/CompressedTextureFormatTests.cpp
+++ b/src/tests/end2end/CompressedTextureFormatTests.cpp
@@ -485,6 +485,9 @@
DAWN_SKIP_TEST_IF(!IsBCFormatSupported());
+ // This test uses glTextureView() which is not supported in OpenGL ES.
+ DAWN_SKIP_TEST_IF(IsOpenGLES());
+
CopyConfig config;
config.textureDescriptor.usage = kDefaultBCFormatTextureUsage;
config.textureDescriptor.size = {8, 8, 1};
@@ -511,6 +514,9 @@
DAWN_SKIP_TEST_IF(!IsBCFormatSupported());
+ // This test uses glTextureView() which is not supported in OpenGL ES.
+ DAWN_SKIP_TEST_IF(IsOpenGLES());
+
CopyConfig config;
config.textureDescriptor.usage = kDefaultBCFormatTextureUsage;
config.textureDescriptor.size = {60, 60, 1};
@@ -551,6 +557,9 @@
DAWN_SKIP_TEST_IF(!IsBCFormatSupported());
+ // This test uses glTextureView() which is not supported in OpenGL ES.
+ DAWN_SKIP_TEST_IF(IsOpenGLES());
+
// TODO(cwallez@chromium.org): This consistently fails on with the 12th pixel being opaque black
// instead of opaque red on Win10 FYI Release (NVIDIA GeForce GTX 1660). See
// https://bugs.chromium.org/p/chromium/issues/detail?id=981393
@@ -604,7 +613,7 @@
// TODO(jiawei.shao@intel.com): add workaround on the T2T copies where Extent3D fits in one
// subresource and does not fit in another one on OpenGL.
- DAWN_SKIP_TEST_IF(IsOpenGL());
+ DAWN_SKIP_TEST_IF(IsOpenGL() || IsOpenGLES());
// TODO(jiawei.shao@intel.com): find out why this test is flaky on Windows Intel Vulkan
// bots.
@@ -668,7 +677,7 @@
// TODO(jiawei.shao@intel.com): add workaround on the T2T copies where Extent3D fits in one
// subresource and does not fit in another one on OpenGL.
- DAWN_SKIP_TEST_IF(IsOpenGL());
+ DAWN_SKIP_TEST_IF(IsOpenGL() || IsOpenGLES());
// TODO(jiawei.shao@intel.com): find out why this test is flaky on Windows Intel Vulkan
// bots.
@@ -728,7 +737,7 @@
// TODO(jiawei.shao@intel.com): add workaround on the T2T copies where Extent3D fits in one
// subresource and does not fit in another one on OpenGL.
- DAWN_SKIP_TEST_IF(IsOpenGL());
+ DAWN_SKIP_TEST_IF(IsOpenGL() || IsOpenGLES());
// TODO(jiawei.shao@intel.com): find out why this test is flaky on Windows Intel Vulkan
// bots.
@@ -974,6 +983,9 @@
DAWN_SKIP_TEST_IF(!IsBCFormatSupported());
+ // This test uses glTextureView() which is not supported in OpenGL ES.
+ DAWN_SKIP_TEST_IF(IsOpenGLES());
+
CopyConfig config;
config.textureDescriptor.usage = kDefaultBCFormatTextureUsage;
config.textureDescriptor.size = {56, 56, 1};
@@ -1017,6 +1029,9 @@
DAWN_SKIP_TEST_IF(!IsBCFormatSupported());
+ // This test uses glTextureView() which is not supported in OpenGL ES.
+ DAWN_SKIP_TEST_IF(IsOpenGLES());
+
constexpr uint32_t kArrayLayerCount = 3;
CopyConfig config;
@@ -1044,6 +1059,9 @@
DAWN_SKIP_TEST_IF(!IsBCFormatSupported());
+ // This test uses glTextureView() which is not supported in OpenGL ES.
+ DAWN_SKIP_TEST_IF(IsOpenGLES());
+
constexpr uint32_t kArrayLayerCount = 3;
CopyConfig config;
