commit ec60b179640d997783b19ed16d6b319aefa64be7
author Austin Eng <enga@chromium.org> Mon Oct 25 16:16:53 2021 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Oct 25 16:16:53 2021 +0000
tree e1e5d1dc88627508c8b5bfa4b2c0547f731ccedb
parent 066ab14e349632d42bc50397f66d24e61c8b5d24

Revert "Disable DrawIndexedIndirect"

This reverts commit d84d7f1ea3280e90e27242df50334133513ed8da.

Reason for revert: CTS tests for this are now enabled.

Original change's description:
> Disable DrawIndexedIndirect
>
> Not passing CTS yet
>
> Bug: dawn:809
> Change-Id: Ib7c240372a8fdbd45803230292c374e2957c8d15
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/65601
> Reviewed-by: Ben Clayton <bclayton@google.com>
> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
> Commit-Queue: Austin Eng <enga@chromium.org>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: dawn:809
Change-Id: I3018fec67c278343956a6da68041bc6ec24d55f4
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/67420
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Austin Eng <enga@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>

src/dawn_native/RenderEncoderBase.cpp

diff --git a/src/dawn_native/RenderEncoderBase.cpp b/src/dawn_native/RenderEncoderBase.cpp
index d519f0d..0445a97 100644
--- a/src/dawn_native/RenderEncoderBase.cpp
+++ b/src/dawn_native/RenderEncoderBase.cpp
@@ -185,14 +185,6 @@
                     DAWN_TRY(ValidateCanUseAs(indirectBuffer, wgpu::BufferUsage::Indirect));
                     DAWN_TRY(mCommandBufferState.ValidateCanDrawIndexed());
 
-                    // Disallow draw indexed indirect until the validation is correctly implemented.
-                    if (GetDevice()->IsToggleEnabled(Toggle::DisallowUnsafeAPIs)) {
-                        return DAWN_VALIDATION_ERROR(
-                            "DrawIndexedIndirect is disallowed because it doesn't correctly "
-                            "validate that "
-                            "the index range is valid yet.");
-                    }
-
                     DAWN_INVALID_IF(indirectOffset % 4 != 0,
                                     "Indirect offset (%u) is not a multiple of 4.", indirectOffset);