commit ef869c2d01d5241ba8d16e6863e8595bc1fac9fd
author Corentin Wallez <cwallez@chromium.org> Thu Jan 21 11:07:44 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Thu Jan 21 11:07:44 2021 +0000
tree 7900e088d2cd75d930b15ac9a695132aac632f23
parent 738aa17493c2e6259b75548cd395c8392d516e01

Use SubresourceStorage to track per-subresource state.

Using this container is a small performance regression in the simple
cases where all subresources are the same, or when the texture has few
subrsources. However it give better performance in the hard subresource
tracking cases of textures with many subresources.

Using SubresourceStorage also makes it easier to work with compressed
storage since the compression is mostly transparent. It reduces code
duplication and prevent bugs from appearing when a developer would
forget to handle compression.

This fixes a state tracking issue in ValidatePassResourceUsage where the
function didn't correctly handle the case where the PassResourceUsage
was compressed.

Also removes the unused vulkan::Texture::TransitionFullUsage.

Also makes SubresourceStorage<T> only require operator== on T and not
operator !=.

Also fixes the texture format's aspect being used to create pipeline
barriers instead of the range's aspects.

Bug: dawn:441

Change-Id: I234b8191f39a09b541c1c63a60cccd6cee970550
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/37706
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>