Google Git
Sign in
dawn / dawn / f4cc537192cae225dc058af03d3b7cb45c9d8a7c
commitf4cc537192cae225dc058af03d3b7cb45c9d8a7c[log] [tgz]
authorKyle Charbonneau <kylechar@google.com>Mon Jul 07 17:50:24 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jul 07 17:50:24 2025 -0700
tree32da98d0747284873f660657eb935ac9f2cf6dec
parent5c1d03d6302f3b02573bcbe4ffef1cc501a2cb57 [diff]
Use vector to hold objects to destroy

ApiObjectList::Destroy() moved the objects it is going to destoy to a
temporary LinkedList. ApiObjectList::Untrack() returns true if the
object is in any list. If another thread runs
ApiObjectBase::DeleteThis() at the same time, that sees the objects are
in a list and proceeds to remove it from list and then destroy it. This
can result in object being removed from list and having DestroyImpl()
called on it twice.

This is fixed by using a std::vector to track the objects to destroy
instead. This avoids the double remove/destruction as
ApiObjectList::Destroy() removes all objects from the original list
under the lock.

Note there is still a problem where the if the last reference is dropped
on another thread before ApiObjectList calls DestroyImpl(). The other
thread will delete the object resulting in DestroyImpl() being a
use-after-free. That is going to fixed as a follow up.

Bug: 429112750, 396294899
Change-Id: I9e8a809c653a1565d1dfbb4a7be48c91a644f540
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/251094
Commit-Queue: Kyle Charbonneau <kylechar@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
1 file changed
tree: 32da98d0747284873f660657eb935ac9f2cf6dec
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. WATCHLISTS
  48. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.