Google Git
Sign in
dawn / dawn / f5fcc294c56511b3052afe928f0d37d1bdc9caeb
commitf5fcc294c56511b3052afe928f0d37d1bdc9caeb[log] [tgz]
authorLokbondo Kung <lokokung@google.com>Fri Nov 22 00:14:33 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 22 00:14:33 2024 +0000
treed4d40456a324f46772489a68382aa77a945c5d96
parent83e66191b77afe75ceb03281aa0a6db8d2a1dc58 [diff]
[dawn][metal] Work around race condition in timestamp resolution.

- Adds a new toggle to gate the workaround, and enable it in
  Apple silicon > M1s.
- Includes a small (kinda tangential) cleanup in TextureMTL with
  unused wait events.
- Implements timestamp resolve query set workaround to avoid race
  between the the timestamp resolve and the actual writing of the
  timestamps. The workaround serializes the command buffer between
  generation of the timestamps, and their resolution, with a wait
  in between them via a MTLSharedEvent. Note that this workaround
  is also implemented in WebKit via:
  https://github.com/WebKit/WebKit/pull/36645
- Locally, this now passes the once failing dawn_end2end test:
  MultithreadTimestampQueryTests.ResolveQuerySets_InParallel
  on my M3, and seems to fix the repro detailed in the bug even
  with multiple refreshes in a local build of Chromium.

Bug: 372698905
Change-Id: I7d77bbcaf269d507b1179478e1f69316613384e9
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215774
Reviewed-by: Ken Russell <kbr@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
8 files changed
tree: d4d40456a324f46772489a68382aa77a945c5d96
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.