Google Git
Sign in
dawn / dawn / fad20a09b2d37250536c459bd884024f7a3c975b
commitfad20a09b2d37250536c459bd884024f7a3c975b[log] [tgz]
authorRyan Harrison <rharrison@chromium.org>Tue May 20 14:14:35 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 20 14:14:35 2025 -0700
tree502d37b5e76bafb70cc31493b63f11d8c2fca86c
parentab8b92ee2549ca4ad6ad748857d7e23c2a076645 [diff]
[tint][ir] Check enum deserialized values in decoder

proto3 uses 'open' enums, which means when a value is out of the
expected range for a enum it still gets written into the message data
when deserializing, instead of being written to the unknown set.

(This is done for reasons relating to avoiding mangling data when
serializing/deserializing using different versions of a .proto.)

The consequence of this is that the IR binary decoder needs to check
that enum values coming out of the deserialized protobuf message are
valid before using them. (There is no provided protobuf message is
well formed method, etc).

This has been done via inserting checking logic for each of the enums,
either in the conversion method if there is an appropriate 'unknown'
or 'invalid' value in the IR that can be returned, or by checking
before the conversion callsite and doing what is ever appropriate for
bad inputs.

The TINT_ICEs in the conversion methods have been retained so that if
a new value is added to the binary/IR format, but decoding logic is
not added that decoder there will be a crash instead of just a
potentially silent failure.

Fixes: 418918028
Change-Id: I5fb3260ae1ec849771c5d147a984b35459a2bd5f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/243094
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
1 file changed
tree: 502d37b5e76bafb70cc31493b63f11d8c2fca86c
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. WATCHLISTS
  48. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.