[utils] Disable -Wmissing-designated-field-initializers Turn off -Wmissing-designated-field-initializers, which prevents using designated initializers without setting EVERY field. This forces code to either use other initialization methods or specify every field, which we don't generally want. This unblocks the standalone Dawn Android GN build because there is a bunch of standalone-only Android-specific code that triggers it and fixing this warning would make that code uglier. No other code triggers it because we had this warning there, and because most of our code was written before designated initializers were available. Because of those, most new code followed the old style instead of taking advantage of defaulting in designated initializers. Bug: 520153663 Change-Id: I34502858c1bb131bd4a8bbeb4ba76c0f15a3fa9e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/317597 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Shrek Shao <shrekshao@google.com>
diff --git a/src/utils/BUILD.gn b/src/utils/BUILD.gn index 08f2d78..483c873 100644 --- a/src/utils/BUILD.gn +++ b/src/utils/BUILD.gn
@@ -65,6 +65,10 @@ "-Wno-pre-c++17-compat", "-Wno-pre-c++20-compat", "-Wno-padded", + + # This warning complains on normal usages of structs, especially in + # Vulkan, and pushes developers away from using designated initializers. + "-Wno-missing-designated-field-initializers", ] # TODO(crbug.com/523358231): triage these warnings and determine whether