Update perf test shutdown to wait for all operations.

When tearing down the Dawn perf tests we're seeing some racing which
appears to terminate the tests on the bots, there is no logging output
when this happens, just the test fails to teardown.

It seems that there maybe a race between GPU commands and test tear
down.

Specifically:

1. UniformBufferUpdatePref tests do MapAsync on a bunch of buffers, the
callback for those map asyncs uses the `this` pointer to set some
information
2. The test "completes" while the MapAsync messages are in progress
3. The test harness waits for its iteration counter, based on queue
submission. That iteration counter can complete before the map async.
4. The test harness exits the test is torn down and the fixture for the
`this` pointer is destroyed. 5. the MapAsync finishes, tries to access
this and then dies.

This is a hypothesis, I haven't been able to reproduce the test locally
where it crashes.

This CL changes the waiting for a specific iteration count to a
`WaitForAllOperations` call instead. This seems, when trying to run the
tests on the perf bot in the try jobs, to make the flake go away over a
number of runs.

Change-Id: I808a915973eabeb3568b4490ce808c5649543876
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/295355
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
1 file changed
tree: b7fd8c8e92988dfd271f3908cd78213b43247826
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. .bazelrc
  15. .clang-format
  16. .clang-format-ignore
  17. .clang-tidy
  18. .git-blame-ignore-revs
  19. .gitattributes
  20. .gitignore
  21. .gitmodules
  22. .gn
  23. .style.yapf
  24. .vpython3
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. test_spec_presubmit_support.py
  45. unsafe_buffers_paths.txt
  46. WATCHLISTS
  47. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.