Google Git
Sign in
dawn / dawn / 67ca77db121ffdfe2372ed94d52194702b1d8861
commit67ca77db121ffdfe2372ed94d52194702b1d8861[log] [tgz]
authorCorentin Wallez <cwallez@chromium.org>Tue Aug 20 08:09:38 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 20 08:09:38 2024 +0000
tree4b32575c073f2096fe151102793e3a672da89768
parentae5dd592666efd521c46d400a9f5f533fa6953b7 [diff]
EncodingContext: Use a Status enum to handle the various states.

Following the logic of what's happening in EncodingContext was difficult
as there was a mix of booleans, mTopLevelEncoder != nullptr and implicit
handling of when EncodingContext was used for an error encoder.

Introduce a status enum with the invariant that
(mStatus == Open) == (mToplevelEncoder != nullptr) to keep the fast
check for ValidateCanEncodeOn (renamed from CheckCurrentEncoder).

Adds a constructor for EncodingContext with the ErrorTag that's used in
the error constructors of CommandEncoder and RenderBundleEncoder.

Removes dawn_unittests expliclty calling EncodingContext::Destroy at
random times which forced more complex handling than necessary
(Destroy is called only in the top level encoder's DestroyImpl or in
~EncodingContext).

Slightly simplify the handling of the acquisition of the CommandIterator
as it can only be done once, and can always go through AcquireCommands.

Fixup a couple tests for the functional change that now starting a pass
on an error CommandEncoder will emit a device error instead of silently
failing.

Bug: 355308275
Change-Id: I5536f17da10b157c2924372ff499387743e0a485
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/200135
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
8 files changed
tree: 4b32575c073f2096fe151102793e3a672da89768
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.