Google Git
Sign in
dawn / dawn / ff133c03b9f14358ef746386f7210ec8b1cedb34
commitff133c03b9f14358ef746386f7210ec8b1cedb34[log] [tgz]
authorStephen White <senorblanco@chromium.org>Tue May 14 05:40:58 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 14 05:40:58 2024 +0000
tree693445574c215aed76f8ef3e75824b8183585b88
parent166c9d5d561d72bfbfacb99671d99675eb9e7fac [diff]
OpenGL: fix spurious EGLSync on queue destruction.

During Device::Destroy(), Queue::WaitForIdleForDestruction() is
called. In the GL backend, this calls gl.Finish(). But the
"GetGL()" call used to call gl.Finish() causes mHasPendingCommands
to be set to true.

Later in Device::Destroy(), TickImpl() is called one last time
to release resources. In the GL case, since mHasPendingCommands
is true, this inserts a new EGLSync which is never destroyed or
waited on.

The fix is to set mHasPendingCommands to false after gl.Finish().
Leaving no pending commands is the very definition of glFinish(),
so it's safe to do.

Bug: 340202279
Change-Id: I3625363018b564fd4409c957576ab9dfe5917d7f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/188061
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>
1 file changed
tree: 693445574c215aed76f8ef3e75824b8183585b88
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.