commit fff34d3c49712d2875122c8efdaec02a9684b522
author Stephen White <senorblanco@chromium.org> Thu Jul 11 22:53:05 2024 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Jul 11 22:53:05 2024 +0000
tree c17d875fd8b5462eefb48ebb03352a7cff786e1a
parent 2461ee677a6011fcaed8e6058fa556a1fb16d935

GLSL: fix storage texture binding.

The binding number simply wasn't being emitted in Tint's GLSL backend.

Also change all the Emit*Variable() functions in GLSL's ASTPrinter
to take a sem::GlobalVariable, rather than taking a sem::Variable and
casting it back.

Bug: dawn:1692
Change-Id: Iab7742732b62be5b2714f9c31e1b2073117fb4b7
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/197975
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Commit-Queue: Stephen White <senorblanco@chromium.org>

test/tint/builtins/gen/var/textureDimensions/15aa17.wgsl.expected.glsl

diff --git a/test/tint/builtins/gen/var/textureDimensions/15aa17.wgsl.expected.glsl b/test/tint/builtins/gen/var/textureDimensions/15aa17.wgsl.expected.glsl
index ecbd64a..8de85f8 100644
--- a/test/tint/builtins/gen/var/textureDimensions/15aa17.wgsl.expected.glsl
+++ b/test/tint/builtins/gen/var/textureDimensions/15aa17.wgsl.expected.glsl
@@ -7,7 +7,7 @@
   uint pad;
 } prevent_dce;
 
-layout(rgba32i) uniform highp writeonly iimage3D arg_0;
+layout(binding = 0, rgba32i) uniform highp writeonly iimage3D arg_0;
 uvec3 textureDimensions_15aa17() {
   uvec3 res = uvec3(imageSize(arg_0));
   return res;
@@ -28,7 +28,7 @@
   uint pad;
 } prevent_dce;
 
-layout(rgba32i) uniform highp writeonly iimage3D arg_0;
+layout(binding = 0, rgba32i) uniform highp writeonly iimage3D arg_0;
 uvec3 textureDimensions_15aa17() {
   uvec3 res = uvec3(imageSize(arg_0));
   return res;