Google Git
Sign in
dawn / dawn / 8670795e321dfa023fbc661c0e302aa644c22070
commit8670795e321dfa023fbc661c0e302aa644c22070[log] [tgz]
authorKyle Charbonneau <kylechar@google.com>Fri Jan 23 07:41:20 2026 -0800
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 23 07:41:20 2026 -0800
tree4a30728d3cdcc37a20006cc511bd560da65f733e
parentb841244ed5276f38adb8d6526dcc1c8af43a3daa [diff]
Change D3D12 buffer fence synchronization

D3D12 Buffer::SynchronizeBufferBeforeUseOnGPU() was calling
MarkUsedInPendingCommands() to increment the last usage serial. This
isn't necessary as the command that uses the buffer on the GPU already
increments last usage serial.

Additionally don't call SynchronizeBufferBeforeUseOnGPU() from
CopyFromStagingToBuffer(). The buffer is added to mSharedBuffers which
calls SynchronizeBufferBeforeUseOnGPU() on the buffer before commands
are submitted.

The motivation here is MarkUsedInPendingCommands() called from
SynchronizeBufferBeforeUseOnGPU() triggers an assertion in added in
https://dawn-review.googlesource.com/c/dawn/+/278575. This is a problem
when SubmitPendingCommandsImpl() is run from Tick(). Removing the
unnecessary call seems like the easiest way to fix that.

Bug: 425472913
Change-Id: I249c718228c5c8ca8785b50657568234e3ea086f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/286355
Commit-Queue: Kyle Charbonneau <kylechar@google.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
2 files changed
tree: 4a30728d3cdcc37a20006cc511bd560da65f733e
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. test_spec_presubmit_support.py
  48. unsafe_buffers_paths.txt
  49. WATCHLISTS
  50. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.