Reenable D3D12 tests that failed with TINT_UNIMPLEMENTED Fixed: tint:683 Change-Id: I38bd482063a38ae9aa71047e4fc05dbbc4a1c236 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/47423 Commit-Queue: Ben Clayton <bclayton@google.com> Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
diff --git a/src/tests/end2end/BufferZeroInitTests.cpp b/src/tests/end2end/BufferZeroInitTests.cpp index b91d029..da478b4 100644 --- a/src/tests/end2end/BufferZeroInitTests.cpp +++ b/src/tests/end2end/BufferZeroInitTests.cpp
@@ -1186,9 +1186,6 @@ // Test the buffer will be lazily initialized correctly when its first use is in resolveQuerySet TEST_P(BufferZeroInitTest, ResolveQuerySet) { - // TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED - DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator")); - // Timestamp query is not supported on OpenGL DAWN_SKIP_TEST_IF(IsOpenGL());
diff --git a/src/tests/end2end/ComputeCopyStorageBufferTests.cpp b/src/tests/end2end/ComputeCopyStorageBufferTests.cpp index bbda58f..a1c64a7 100644 --- a/src/tests/end2end/ComputeCopyStorageBufferTests.cpp +++ b/src/tests/end2end/ComputeCopyStorageBufferTests.cpp
@@ -110,9 +110,6 @@ // Test that a slightly-less-trivial compute-shader memcpy implementation works. TEST_P(ComputeCopyStorageBufferTests, SizedArrayOfStruct) { - // TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED - DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator")); - BasicTest(R"( struct S { a : vec2<u32>;
diff --git a/src/tests/end2end/QueryTests.cpp b/src/tests/end2end/QueryTests.cpp index daf6e4b..1dd3464 100644 --- a/src/tests/end2end/QueryTests.cpp +++ b/src/tests/end2end/QueryTests.cpp
@@ -512,9 +512,6 @@ void SetUp() override { DawnTest::SetUp(); - // TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED - DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator")); - // Skip all tests if timestamp extension is not supported DAWN_SKIP_TEST_IF(!SupportsExtensions({"timestamp_query"})); }
diff --git a/src/tests/white_box/QueryInternalShaderTests.cpp b/src/tests/white_box/QueryInternalShaderTests.cpp index 7baff77..c6ffbe3 100644 --- a/src/tests/white_box/QueryInternalShaderTests.cpp +++ b/src/tests/white_box/QueryInternalShaderTests.cpp
@@ -86,8 +86,6 @@ // timestamp period (here use GPU frequency (HZ) on Intel D3D12 to calculate the period in // ns for testing). TEST_P(QueryInternalShaderTests, TimestampComputeShader) { - // TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED - DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator")); // TODO(crbug.com/dawn/741): Test output is wrong with D3D12 + WARP. DAWN_SKIP_TEST_IF(IsD3D12() && IsWARP());