commit 566d7f25b864ee5df0a463b06841f3d033049812
author dan sinclair <dsinclair@chromium.org> Mon Apr 11 15:50:50 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Apr 11 15:50:50 2022 +0000
tree 6d1dc82993a34a41fe365a0864dc2671bd5a8d9c
parent c9fcc458438e7b073b640b1dc9f84f85a0f6c839

Enable empty_if_body lint.

This CL updates the one instance of an empty if body in Dawn to
remove the if. This allows enabling the empty_if_body lint check.

Change-Id: I5c05db828e8033b4f3155a34c3a6723bfd3181d6
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86082
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>

src/dawn/CPPLINT.cfg

diff --git a/src/dawn/CPPLINT.cfg b/src/dawn/CPPLINT.cfg
index b172426..27dc5d4 100644
--- a/src/dawn/CPPLINT.cfg
+++ b/src/dawn/CPPLINT.cfg
@@ -10,4 +10,3 @@
 filter=-runtime/explicit
 filter=-runtime/indentation_namespace
 filter=-runtime/int
-filter=-whitespace/empty_if_body

src/dawn/native/RenderPassEncoder.cpp

diff --git a/src/dawn/native/RenderPassEncoder.cpp b/src/dawn/native/RenderPassEncoder.cpp
index b7f7563..31e740d 100644
--- a/src/dawn/native/RenderPassEncoder.cpp
+++ b/src/dawn/native/RenderPassEncoder.cpp
@@ -131,31 +131,30 @@
     }
 
     void RenderPassEncoder::APIEnd() {
-        if (mEncodingContext->TryEncode(
-                this,
-                [&](CommandAllocator* allocator) -> MaybeError {
-                    if (IsValidationEnabled()) {
-                        DAWN_TRY(ValidateProgrammableEncoderEnd());
+        mEncodingContext->TryEncode(
+            this,
+            [&](CommandAllocator* allocator) -> MaybeError {
+                if (IsValidationEnabled()) {
+                    DAWN_TRY(ValidateProgrammableEncoderEnd());
 
-                        DAWN_INVALID_IF(
-                            mOcclusionQueryActive,
-                            "Render pass %s ended with incomplete occlusion query index %u of %s.",
-                            this, mCurrentOcclusionQueryIndex, mOcclusionQuerySet.Get());
-                    }
+                    DAWN_INVALID_IF(
+                        mOcclusionQueryActive,
+                        "Render pass %s ended with incomplete occlusion query index %u of %s.",
+                        this, mCurrentOcclusionQueryIndex, mOcclusionQuerySet.Get());
+                }
 
-                    EndRenderPassCmd* cmd =
-                        allocator->Allocate<EndRenderPassCmd>(Command::EndRenderPass);
-                    // The query availability has already been updated at the beginning of render
-                    // pass, and no need to do update here.
-                    cmd->timestampWrites = std::move(mTimestampWritesAtEnd);
+                EndRenderPassCmd* cmd =
+                    allocator->Allocate<EndRenderPassCmd>(Command::EndRenderPass);
+                // The query availability has already been updated at the beginning of render
+                // pass, and no need to do update here.
+                cmd->timestampWrites = std::move(mTimestampWritesAtEnd);
 
-                    DAWN_TRY(mEncodingContext->ExitRenderPass(this, std::move(mUsageTracker),
-                                                              mCommandEncoder.Get(),
-                                                              std::move(mIndirectDrawMetadata)));
-                    return {};
-                },
-                "encoding %s.End().", this)) {
-        }
+                DAWN_TRY(mEncodingContext->ExitRenderPass(this, std::move(mUsageTracker),
+                                                          mCommandEncoder.Get(),
+                                                          std::move(mIndirectDrawMetadata)));
+                return {};
+            },
+            "encoding %s.End().", this);
     }
 
     void RenderPassEncoder::APIEndPass() {