commit 8c590acda0dcefcc7c916c59bf0102073d917bba
author Jiawei Shao <jiawei.shao@intel.com> Tue Aug 02 01:45:34 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Aug 02 01:45:34 2022 +0000
tree d5cba4b3f51bb92c19b1b0d8ddd3168711f1f79e
parent cbadf96e7951f97d319cda402c61b4104228a58a

Remove the deprecated toggle DEPRECATED_DumpTranslatedShaders

Bug: dawn:792
Change-Id: I2eee16490617c3371bfd65a69aca678aa4a6f3dc
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/97780
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

src/dawn/native/Toggles.cpp

diff --git a/src/dawn/native/Toggles.cpp b/src/dawn/native/Toggles.cpp
index 55ac82f..5c90de2 100644
--- a/src/dawn/native/Toggles.cpp
+++ b/src/dawn/native/Toggles.cpp
@@ -203,8 +203,6 @@
       "Dump shaders for debugging purposes. Dumped shaders will be log via EmitLog, thus printed "
       "in Chrome console or consumed by user-defined callback function.",
       "https://crbug.com/dawn/792"}},
-    {Toggle::DEPRECATED_DumpTranslatedShaders,
-     {"dump_translated_shaders", "Deprecated. Use dump_shaders", "https://crbug.com/dawn/792"}},
     {Toggle::ForceWGSLStep,
      {"force_wgsl_step",
       "When ingesting SPIR-V shaders, force a first conversion to WGSL. This allows testing Tint's "
@@ -297,19 +295,12 @@
 }  // anonymous namespace
 
 void TogglesSet::Set(Toggle toggle, bool enabled) {
-    if (toggle == Toggle::DEPRECATED_DumpTranslatedShaders) {
-        Set(Toggle::DumpShaders, enabled);
-        return;
-    }
     ASSERT(toggle != Toggle::InvalidEnum);
     const size_t toggleIndex = static_cast<size_t>(toggle);
     toggleBitset.set(toggleIndex, enabled);
 }
 
 bool TogglesSet::Has(Toggle toggle) const {
-    if (toggle == Toggle::DEPRECATED_DumpTranslatedShaders) {
-        return Has(Toggle::DumpShaders);
-    }
     ASSERT(toggle != Toggle::InvalidEnum);
     const size_t toggleIndex = static_cast<size_t>(toggle);
     return toggleBitset.test(toggleIndex);

src/dawn/native/Toggles.h

diff --git a/src/dawn/native/Toggles.h b/src/dawn/native/Toggles.h
index 32aa009..ceb8bf7 100644
--- a/src/dawn/native/Toggles.h
+++ b/src/dawn/native/Toggles.h
@@ -59,7 +59,6 @@
     EmitHLSLDebugSymbols,
     DisallowSpirv,
     DumpShaders,
-    DEPRECATED_DumpTranslatedShaders,  // Use DumpShaders
     ForceWGSLStep,
     DisableWorkgroupInit,
     DisableSymbolRenaming,