commit fdd2ff11455b9c628e7b9383e5cabe1825878c55
author dan sinclair <dsinclair@chromium.org> Wed Oct 19 20:28:34 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Oct 19 20:28:34 2022 +0000
tree fa3fbe252576f3a97c76a6102bc7baa56683bd8b
parent 1c94938726db859f555167d5028f5230d83a0567

Add tests to show correct handling of mixed && and ||.

This CL adds tests to verify the new parser handles the mixing of && and
|| correctly.

Bug: tint:1599
Change-Id: I1a73d041a00118ed649522ae07fc1489021c4b41
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/106461
Kokoro: Kokoro <noreply+kokoro@google.com>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Ben Clayton <bclayton@google.com>

src/tint/reader/wgsl/parser_impl_expression_test.cc

diff --git a/src/tint/reader/wgsl/parser_impl_expression_test.cc b/src/tint/reader/wgsl/parser_impl_expression_test.cc
index e3e53fc..389999f 100644
--- a/src/tint/reader/wgsl/parser_impl_expression_test.cc
+++ b/src/tint/reader/wgsl/parser_impl_expression_test.cc
@@ -250,6 +250,25 @@
     EXPECT_EQ(p->error(), "1:6: unable to parse right side of <= expression");
 }
 
+TEST_F(ParserImplTest, Expression_Associativity) {
+    auto p = parser("1 < 2 || 2 < 3");
+    auto e = p->expression();
+    EXPECT_TRUE(e.matched);
+    EXPECT_FALSE(e.errored);
+    EXPECT_FALSE(p->has_error()) << p->error();
+    ASSERT_NE(e.value, nullptr);
+}
+
+TEST_F(ParserImplTest, Expression_InvalidAssociativity) {
+    auto p = parser("1 < 2 && 2 < 3 || 3 < 4");
+    auto e = p->expression();
+    EXPECT_FALSE(e.matched);
+    EXPECT_TRUE(e.errored);
+    EXPECT_TRUE(p->has_error());
+    EXPECT_EQ(e.value, nullptr);
+    EXPECT_EQ(p->error(), R"(1:7: mixing '&&' and '||' requires parenthesis)");
+}
+
 namespace mixing_binary_ops {
 
 struct BinaryOperatorInfo {