|author||Corentin Wallez <firstname.lastname@example.org>||Wed Sep 20 13:34:19 2023 +0000|
|committer||Dawn LUCI CQ <email@example.com>||Wed Sep 20 13:34:19 2023 +0000|
vulkan::Device: Don't rely on the queue during DestroyImpl It was only used to get the completed serial, which is basically kMaxExecutionSerial, so just use that. DestroyImpl's full logic might need to run without a queue if the following happens: - DeviceVk::Initialize runs partially, enough to have a VkDevice, and fails before the call to DeviceBase::Initialize. - DeviceBase::Initialize IS NOT called and so mQueue IS NOT set. - DeviceBase::~DeviceBase calls DeviceBase::Destroy which calls Device::DestroyImpl. - Device::DestroyImpl sees there is a VkDevice so full deinitialization is needed, and that used to call GetQueue(), which this CL fixes. Bug: chromium:1484300 Change-Id: I66ae8a2c7eeccffb4212323ef21b1670efcc762f Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/152404 Kokoro: Kokoro <firstname.lastname@example.org> Commit-Queue: Corentin Wallez <email@example.com> Reviewed-by: Loko Kung <firstname.lastname@example.org>
Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements
webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.hversion that Dawn implements.
User documentation: (TODO, figure out what overlaps with the webgpu.h docs)
Apache 2.0 Public License, please see LICENSE.
This is not an officially supported Google product.