Google Git
Sign in
dawn / dawn / refs/heads/chromium/6021
commit6e852f8fa88ca2e9e9bc3500552d7bc547c49caa[log] [tgz]
authorCorentin Wallez <cwallez@chromium.org>Wed Sep 20 13:34:19 2023 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Sep 20 13:34:19 2023 +0000
tree3631521eef96b8338688e0d3888398bcd21f94cc
parent21acc62bb268c959b7dfbe8fc308b4ec34f5ad87 [diff]
vulkan::Device: Don't rely on the queue during DestroyImpl

It was only used to get the completed serial, which is basically
kMaxExecutionSerial, so just use that. DestroyImpl's full logic might
need to run without a queue if the following happens:

 - DeviceVk::Initialize runs partially, enough to have a VkDevice, and
   fails before the call to DeviceBase::Initialize.
 - DeviceBase::Initialize IS NOT called and so mQueue IS NOT set.
 - DeviceBase::~DeviceBase calls DeviceBase::Destroy which calls
   Device::DestroyImpl.
 - Device::DestroyImpl sees there is a VkDevice so full deinitialization
   is needed, and that used to call GetQueue(), which this CL fixes.

Bug: chromium:1484300
Change-Id: I66ae8a2c7eeccffb4212323ef21b1670efcc762f
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/152404
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
3 files changed
tree: 3631521eef96b8338688e0d3888398bcd21f94cc
  1. .vscode/
  2. build_overrides/
  3. docs/
  4. generator/
  5. include/
  6. infra/
  7. scripts/
  8. src/
  9. test/
  10. third_party/
  11. tools/
  12. webgpu-cts/
  13. build
  14. buildtools
  15. testing
  16. .bazelrc
  17. .clang-format
  18. .clang-tidy
  19. .gitattributes
  20. .gitignore
  21. .gitmodules
  22. .gn
  23. AUTHORS
  24. BUILD.bazel
  25. BUILD.gn
  26. CMakeLists.txt
  27. CMakeSettings.json
  28. CODE_OF_CONDUCT.md
  29. codereview.settings
  30. CONTRIBUTING.md
  31. CPPLINT.cfg
  32. dawn.json
  33. dawn_wire.json
  34. DEPS
  35. DIR_METADATA
  36. Doxyfile
  37. go.mod
  38. go.sum
  39. go_presubmit_support.py
  40. LICENSE
  41. OWNERS
  42. PRESUBMIT.py
  43. README.chromium
  44. README.md
  45. WORKSPACE.bazel
README.md

Dawn's logo: a sun rising behind a stylized mountain inspired by the WebGPU logo. The text Dawn is written below it.

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

Status

(TODO)

License

Apache 2.0 Public License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.