commit 2eae44a628063255ab08f92ba5dbe2afd1908862
author James Price <jrprice@google.com> Wed Sep 20 23:24:15 2023 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 20 23:24:15 2023 +0000
tree ef79f0320ed8e94c9d75b69f1360e4493d8ee236
parent 5b3ae14cca5b2d0573c47f64b3c37c24ce61135f

[ir] Dump before validating, when dumping

This is much more useful for debugging in practice.

Change-Id: I0018d016807a381e4aacc295f5656511b2c7fc53
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/152580
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: James Price <jrprice@google.com>

src/tint/lang/core/ir/validator.cc

diff --git a/src/tint/lang/core/ir/validator.cc b/src/tint/lang/core/ir/validator.cc
index b40e9bc..e7cc0f2 100644
--- a/src/tint/lang/core/ir/validator.cc
+++ b/src/tint/lang/core/ir/validator.cc
@@ -872,6 +872,14 @@
 
 Result<SuccessType, std::string> ValidateAndDumpIfNeeded([[maybe_unused]] Module& ir,
                                                          [[maybe_unused]] const char* msg) {
+#if TINT_DUMP_IR_WHEN_VALIDATING
+    Disassembler disasm(ir);
+    std::cout << "=========================================================" << std::endl;
+    std::cout << "== IR dump before " << msg << ":" << std::endl;
+    std::cout << "=========================================================" << std::endl;
+    std::cout << disasm.Disassemble();
+#endif
+
 #ifndef NDEBUG
     auto result = Validate(ir);
     if (!result) {
@@ -882,14 +890,6 @@
     }
 #endif
 
-#if TINT_DUMP_IR_WHEN_VALIDATING
-    Disassembler disasm(ir);
-    std::cout << "=========================================================" << std::endl;
-    std::cout << "== IR dump before " << msg << ":" << std::endl;
-    std::cout << "=========================================================" << std::endl;
-    std::cout << disasm.Disassemble();
-#endif
-
     return Success;
 }