Google Git
Sign in
dawn/dawn/refs/heads/chromium/7075
commit
a5df8c51ea116ba5c9926725637da323f4b5d0ed
[log]
author
dan sinclair <dsinclair@chromium.org>
Mon Mar 17 14:24:52 2025 -0700
committer
Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>
Mon Mar 17 14:24:52 2025 -0700
tree
86edf593cd6ad50d2bbca3b54f6a97a81e5c1a34
parent
43c7c10ca0b712ce3f18d5dff4a7cac4ed53d17f [diff]
[glsl] Only apply BGRA swizzle to `in` address space.

Currently the `bgra_swizzle` values are getting applied to all address
spaces. This means if we have a `location(0)` in the `in` address space
and a `location(0)` in the `out` address space we'll apply the BGRA
swizzle to both of them. Is then can cause issues if the output address
space item isn't a `vec4f` as the assignment will fail.

Change the `bgra_swizzle` code to only apply to `in` address space
locations.

Bug: 389559096
Change-Id: I992ff2612627644c791913a65d9c6e25a9aa8a34
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/231494
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
10 files changed
tree: 86edf593cd6ad50d2bbca3b54f6a97a81e5c1a34
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.