Google Git
Sign in
dawn / dawn / 43be1a4dda86f981fab9ca598571a322770dc816
commit43be1a4dda86f981fab9ca598571a322770dc816[log] [tgz]
authorGregg Tavares <gman@chromium.org>Thu Oct 30 20:14:38 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Oct 30 20:14:38 2025 -0700
treebe3d3adbfde140a042a12d101446d5b3549546b9
parent84a7b6cdf5da91dbd49dc9375a54a0b9b346677d [diff]
Fix WebGPU-On-WebGPU use after free issue

The previous solution was associating pipelines
with BindGroupLayoutInternals. That was just flat
out invalid as BindGroupLayoutInternals are deduped
so the association was incorrect.

The association was needed for bindGroupLayouts
that are implicitly created by pipelines using
automatic layout as we need to know which pipeline
to create to get the implicitly generated
bindGroupLayout.

The new solution gathers all the pipelines used in
a command buffer first and serialized them. That way,
ids for the implicit bindGroupLayouts already exist
and it's safe to then serialize the bindGroups.

Bug: 455605671
Change-Id: I78e866eda372df48f37e0b6b91e8d6c76199e458
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/269574
Commit-Queue: Gregg Tavares <gman@chromium.org>
Reviewed-by: Loko Kung <lokokung@google.com>
11 files changed
tree: be3d3adbfde140a042a12d101446d5b3549546b9
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. unsafe_buffers_paths.txt
  48. WATCHLISTS
  49. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.