[spirv] Gate NonPrivatePointer on cooperative matrix loads

SubgroupMatrixLoad() hardcodes SpvMemoryAccessNonPrivatePointerMask on
OpCooperativeMatrixLoadKHR. Ordinary accesses do not: the printer's
MemoryAccessMaskForPointer() requests it only under the Vulkan memory
model, for storage or workgroup pointers, and only when the access mode
is read_write. The same file already follows that rule for storage
textures, via NonPrivateTexel.

NonPrivatePointer makes the access take part in the memory model's
availability and visibility rules. A read-only pointer has nothing to
take part in, since no agent can write it for the life of the dispatch,
but honouring the operand still keeps the access out of storage that
other agents cannot observe.

Apply the same rule. Only its access mode term needs testing here: these
builtins accept nothing but storage and workgroup pointers, and subgroup
matrix already requires the memory model. SubgroupMatrixStore() is left
alone: storing needs a writable pointer, so the rule could never change
its result.

Measured with two builds differing only in this change, on Phi-4-mini
prefill at 512 tokens through ONNX Runtime's subgroup-matrix matmul
kernel, which reads its A operand from a var<storage, read> buffer: an
AMD Radeon RX 7900 XTX goes from 2300 to 5058 tok/s. On an NVIDIA
GeForce RTX 5080 and an Intel Arc 140V there was neither improvement nor
regression.

The added test covers a read-only pointer; the existing subgroup matrix
tests all use read_write, whose result is unchanged.

Bug: none
Change-Id: Iea60136b3aabe3274141bf1cdb93db2d7d4879a0
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/330695
Reviewed-by: Alan Baker <alanbaker@google.com>
SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>
Commit-Queue: Yang Gu <ygu@microsoft.com>
434 files changed
tree: 8d065d034246e14effb8fbe5f4899a3cc12731ce
  1. .github/
  2. .vscode/
  3. agents/
  4. build_overrides/
  5. docs/
  6. generator/
  7. include/
  8. infra/
  9. scripts/
  10. src/
  11. test/
  12. third_party/
  13. tools/
  14. webgpu-cts/
  15. .bazelignore
  16. .bazelrc
  17. .bazelversion
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. MODULE.bazel
  44. MODULE.bazel.lock
  45. OWNERS
  46. PRESUBMIT.py
  47. PRESUBMIT_test.py
  48. README.chromium
  49. README.md
  50. unsafe_buffers_paths.txt
  51. WATCHLISTS
  52. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.