Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1 | // Copyright 2021 The Tint Authors. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | #include "src/tint/transform/promote_side_effects_to_decl.h" |
| 16 | |
| 17 | #include "src/tint/transform/test_helper.h" |
| 18 | |
dan sinclair | b5599d3 | 2022-04-07 16:55:14 +0000 | [diff] [blame] | 19 | namespace tint::transform { |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 20 | namespace { |
| 21 | |
| 22 | using PromoteSideEffectsToDeclTest = TransformTest; |
| 23 | |
| 24 | TEST_F(PromoteSideEffectsToDeclTest, EmptyModule) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 25 | auto* src = ""; |
| 26 | auto* expect = ""; |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 27 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 28 | DataMap data; |
| 29 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 30 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 31 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 32 | } |
| 33 | |
| 34 | TEST_F(PromoteSideEffectsToDeclTest, Unary_Arith_SE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 35 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 36 | fn a(i : i32) -> i32 { |
| 37 | return 1; |
| 38 | } |
| 39 | |
| 40 | fn f() { |
| 41 | let r = -(a(0)); |
| 42 | } |
| 43 | )"; |
| 44 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 45 | auto* expect = src; |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 46 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 47 | DataMap data; |
| 48 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 49 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 50 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 51 | } |
| 52 | |
| 53 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_BothSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 54 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 55 | fn a() -> i32 { |
| 56 | return 1; |
| 57 | } |
| 58 | |
| 59 | fn b() -> i32 { |
| 60 | return 1; |
| 61 | } |
| 62 | |
| 63 | fn f() { |
| 64 | let r = a() + b(); |
| 65 | } |
| 66 | )"; |
| 67 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 68 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 69 | fn a() -> i32 { |
| 70 | return 1; |
| 71 | } |
| 72 | |
| 73 | fn b() -> i32 { |
| 74 | return 1; |
| 75 | } |
| 76 | |
| 77 | fn f() { |
| 78 | let tint_symbol = a(); |
| 79 | let tint_symbol_1 = b(); |
| 80 | let r = (tint_symbol + tint_symbol_1); |
| 81 | } |
| 82 | )"; |
| 83 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 84 | DataMap data; |
| 85 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 86 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 87 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 88 | } |
| 89 | |
| 90 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_LeftSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 91 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 92 | fn a() -> i32 { |
| 93 | return 1; |
| 94 | } |
| 95 | |
| 96 | fn f() { |
| 97 | var b = 1; |
| 98 | let r = a() + b; |
| 99 | } |
| 100 | )"; |
| 101 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 102 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 103 | fn a() -> i32 { |
| 104 | return 1; |
| 105 | } |
| 106 | |
| 107 | fn f() { |
| 108 | var b = 1; |
| 109 | let tint_symbol = a(); |
| 110 | let r = (tint_symbol + b); |
| 111 | } |
| 112 | )"; |
| 113 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 114 | DataMap data; |
| 115 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 116 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 117 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 118 | } |
| 119 | |
| 120 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_RightSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 121 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 122 | fn a() -> i32 { |
| 123 | return 1; |
| 124 | } |
| 125 | |
| 126 | fn f() { |
| 127 | var b = 1; |
| 128 | let r = b + a(); |
| 129 | } |
| 130 | )"; |
| 131 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 132 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 133 | fn a() -> i32 { |
| 134 | return 1; |
| 135 | } |
| 136 | |
| 137 | fn f() { |
| 138 | var b = 1; |
| 139 | let tint_symbol = b; |
| 140 | let tint_symbol_1 = a(); |
| 141 | let r = (tint_symbol + tint_symbol_1); |
| 142 | } |
| 143 | )"; |
| 144 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 145 | DataMap data; |
| 146 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 147 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 148 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 149 | } |
| 150 | |
| 151 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_LeftmostSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 152 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 153 | fn a() -> i32 { |
| 154 | return 1; |
| 155 | } |
| 156 | |
| 157 | fn f() { |
| 158 | var b = 1; |
| 159 | var c = 1; |
| 160 | var d = 1; |
| 161 | let r = a() + b + c + d; |
| 162 | } |
| 163 | )"; |
| 164 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 165 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 166 | fn a() -> i32 { |
| 167 | return 1; |
| 168 | } |
| 169 | |
| 170 | fn f() { |
| 171 | var b = 1; |
| 172 | var c = 1; |
| 173 | var d = 1; |
| 174 | let tint_symbol = a(); |
| 175 | let r = (((tint_symbol + b) + c) + d); |
| 176 | } |
| 177 | )"; |
| 178 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 179 | DataMap data; |
| 180 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 181 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 182 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 183 | } |
| 184 | |
| 185 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_RightmostSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 186 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 187 | fn a() -> i32 { |
| 188 | return 1; |
| 189 | } |
| 190 | |
| 191 | fn f() { |
| 192 | var b = 1; |
| 193 | var c = 1; |
| 194 | var d = 1; |
| 195 | let r = b + c + d + a(); |
| 196 | } |
| 197 | )"; |
| 198 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 199 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 200 | fn a() -> i32 { |
| 201 | return 1; |
| 202 | } |
| 203 | |
| 204 | fn f() { |
| 205 | var b = 1; |
| 206 | var c = 1; |
| 207 | var d = 1; |
| 208 | let tint_symbol = ((b + c) + d); |
| 209 | let tint_symbol_1 = a(); |
| 210 | let r = (tint_symbol + tint_symbol_1); |
| 211 | } |
| 212 | )"; |
| 213 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 214 | DataMap data; |
| 215 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 216 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 217 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 218 | } |
| 219 | |
| 220 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_MiddleSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 221 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 222 | fn a() -> i32 { |
| 223 | return 1; |
| 224 | } |
| 225 | |
| 226 | fn f() { |
| 227 | var b = 1; |
| 228 | var c = 1; |
| 229 | var d = 1; |
| 230 | var e = 1; |
| 231 | let r = b + c + a() + d + e; |
| 232 | } |
| 233 | )"; |
| 234 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 235 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 236 | fn a() -> i32 { |
| 237 | return 1; |
| 238 | } |
| 239 | |
| 240 | fn f() { |
| 241 | var b = 1; |
| 242 | var c = 1; |
| 243 | var d = 1; |
| 244 | var e = 1; |
| 245 | let tint_symbol = (b + c); |
| 246 | let tint_symbol_1 = a(); |
| 247 | let r = (((tint_symbol + tint_symbol_1) + d) + e); |
| 248 | } |
| 249 | )"; |
| 250 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 251 | DataMap data; |
| 252 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 253 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 254 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 255 | } |
| 256 | |
| 257 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_ThreeSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 258 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 259 | fn a(v : i32) -> i32 { |
| 260 | return v; |
| 261 | } |
| 262 | |
| 263 | fn f() { |
| 264 | let r = a(0) + a(1) + a(2); |
| 265 | } |
| 266 | )"; |
| 267 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 268 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 269 | fn a(v : i32) -> i32 { |
| 270 | return v; |
| 271 | } |
| 272 | |
| 273 | fn f() { |
| 274 | let tint_symbol = a(0); |
| 275 | let tint_symbol_1 = a(1); |
| 276 | let tint_symbol_2 = a(2); |
| 277 | let r = ((tint_symbol + tint_symbol_1) + tint_symbol_2); |
| 278 | } |
| 279 | )"; |
| 280 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 281 | DataMap data; |
| 282 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 283 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 284 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 285 | } |
| 286 | |
| 287 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_Constants_NoRecvSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 288 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 289 | fn a(i : i32) -> i32 { |
| 290 | return 1; |
| 291 | } |
| 292 | |
| 293 | fn f() { |
| 294 | let r = ((((1 + a(0)) - 2) + 3) - 4); |
| 295 | } |
| 296 | )"; |
| 297 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 298 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 299 | fn a(i : i32) -> i32 { |
| 300 | return 1; |
| 301 | } |
| 302 | |
| 303 | fn f() { |
| 304 | let tint_symbol = a(0); |
| 305 | let r = ((((1 + tint_symbol) - 2) + 3) - 4); |
| 306 | } |
| 307 | )"; |
| 308 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 309 | DataMap data; |
| 310 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 311 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 312 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 313 | } |
| 314 | |
| 315 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_Constants_RecvSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 316 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 317 | fn a(i : i32) -> i32 { |
| 318 | return 1; |
| 319 | } |
| 320 | |
| 321 | fn f() { |
| 322 | var b = 1; |
| 323 | let r = a(0) + 1 + b + a(1) + 2; |
| 324 | } |
| 325 | )"; |
| 326 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 327 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 328 | fn a(i : i32) -> i32 { |
| 329 | return 1; |
| 330 | } |
| 331 | |
| 332 | fn f() { |
| 333 | var b = 1; |
| 334 | let tint_symbol = a(0); |
| 335 | let tint_symbol_1 = b; |
| 336 | let tint_symbol_2 = a(1); |
| 337 | let r = ((((tint_symbol + 1) + tint_symbol_1) + tint_symbol_2) + 2); |
| 338 | } |
| 339 | )"; |
| 340 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 341 | DataMap data; |
| 342 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 343 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 344 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 345 | } |
| 346 | |
| 347 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_Constants_ConstAndSEAndVar) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 348 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 349 | fn a(i : i32) -> i32 { |
| 350 | return 1; |
| 351 | } |
| 352 | |
| 353 | fn main() { |
| 354 | var b = 1; |
| 355 | var c = 1; |
| 356 | let r = 1 + a(0) + b; |
| 357 | } |
| 358 | )"; |
| 359 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 360 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 361 | fn a(i : i32) -> i32 { |
| 362 | return 1; |
| 363 | } |
| 364 | |
| 365 | fn main() { |
| 366 | var b = 1; |
| 367 | var c = 1; |
| 368 | let tint_symbol = a(0); |
| 369 | let r = ((1 + tint_symbol) + b); |
| 370 | } |
| 371 | )"; |
| 372 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 373 | DataMap data; |
| 374 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 375 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 376 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 377 | } |
| 378 | |
| 379 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_Constants_VarAndSEAndConst) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 380 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 381 | fn a(i : i32) -> i32 { |
| 382 | return 1; |
| 383 | } |
| 384 | |
| 385 | fn main() { |
| 386 | var b = 1; |
| 387 | let r = b + a(0) + 1; |
| 388 | } |
| 389 | )"; |
| 390 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 391 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 392 | fn a(i : i32) -> i32 { |
| 393 | return 1; |
| 394 | } |
| 395 | |
| 396 | fn main() { |
| 397 | var b = 1; |
| 398 | let tint_symbol = b; |
| 399 | let tint_symbol_1 = a(0); |
| 400 | let r = ((tint_symbol + tint_symbol_1) + 1); |
| 401 | } |
| 402 | )"; |
| 403 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 404 | DataMap data; |
| 405 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 406 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 407 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 408 | } |
| 409 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 410 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_Constants_SEAndVarAndConstAndVar) { |
| 411 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 412 | fn a(i : i32) -> i32 { |
| 413 | return 1; |
| 414 | } |
| 415 | |
| 416 | fn main() { |
| 417 | var b = 1; |
| 418 | var c = 1; |
| 419 | let r = a(0) + b + 1 + c; |
| 420 | } |
| 421 | )"; |
| 422 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 423 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 424 | fn a(i : i32) -> i32 { |
| 425 | return 1; |
| 426 | } |
| 427 | |
| 428 | fn main() { |
| 429 | var b = 1; |
| 430 | var c = 1; |
| 431 | let tint_symbol = a(0); |
| 432 | let r = (((tint_symbol + b) + 1) + c); |
| 433 | } |
| 434 | )"; |
| 435 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 436 | DataMap data; |
| 437 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 438 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 439 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 440 | } |
| 441 | |
| 442 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_Builtins_WithSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 443 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 444 | struct SB { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 445 | a : atomic<i32>, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 446 | } |
| 447 | |
| 448 | @group(0) @binding(0) var<storage, read_write> sb : SB; |
| 449 | |
| 450 | fn f() { |
| 451 | var b = 0; |
| 452 | let r = atomicAdd(&sb.a, 123) + b; |
| 453 | } |
| 454 | )"; |
| 455 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 456 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 457 | struct SB { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 458 | a : atomic<i32>, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 459 | } |
| 460 | |
| 461 | @group(0) @binding(0) var<storage, read_write> sb : SB; |
| 462 | |
| 463 | fn f() { |
| 464 | var b = 0; |
| 465 | let tint_symbol = atomicAdd(&(sb.a), 123); |
| 466 | let r = (tint_symbol + b); |
| 467 | } |
| 468 | )"; |
| 469 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 470 | DataMap data; |
| 471 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 472 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 473 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 474 | } |
| 475 | |
| 476 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_Builtins_NoSEAndVar) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 477 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 478 | struct SB { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 479 | a : atomic<i32>, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 480 | } |
| 481 | |
| 482 | @group(0) @binding(0) var<storage, read_write> sb : SB; |
| 483 | |
| 484 | fn f() { |
| 485 | var b = 0; |
| 486 | let r = (atomicLoad(&(sb.a)) + b); |
| 487 | } |
| 488 | )"; |
| 489 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 490 | auto* expect = src; |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 491 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 492 | DataMap data; |
| 493 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 494 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 495 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 496 | } |
| 497 | |
| 498 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_Builtins_NoSEAndSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 499 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 500 | struct SB { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 501 | a : atomic<i32>, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 502 | } |
| 503 | |
| 504 | @group(0) @binding(0) var<storage, read_write> sb : SB; |
| 505 | |
| 506 | fn a(i : i32) -> i32 { |
| 507 | return 1; |
| 508 | } |
| 509 | |
| 510 | fn f() { |
| 511 | var b = 0; |
| 512 | let r = (atomicLoad(&(sb.a)) + a(0)); |
| 513 | } |
| 514 | )"; |
| 515 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 516 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 517 | struct SB { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 518 | a : atomic<i32>, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 519 | } |
| 520 | |
| 521 | @group(0) @binding(0) var<storage, read_write> sb : SB; |
| 522 | |
| 523 | fn a(i : i32) -> i32 { |
| 524 | return 1; |
| 525 | } |
| 526 | |
| 527 | fn f() { |
| 528 | var b = 0; |
| 529 | let tint_symbol = atomicLoad(&(sb.a)); |
| 530 | let tint_symbol_1 = a(0); |
| 531 | let r = (tint_symbol + tint_symbol_1); |
| 532 | } |
| 533 | )"; |
| 534 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 535 | DataMap data; |
| 536 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 537 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 538 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 539 | } |
| 540 | |
| 541 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_Vector_RightSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 542 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 543 | fn a() -> i32 { |
| 544 | return 1; |
| 545 | } |
| 546 | |
| 547 | fn f() { |
| 548 | var b : vec3<i32>; |
| 549 | var c : i32; |
| 550 | let r = b[c] + a(); |
| 551 | } |
| 552 | )"; |
| 553 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 554 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 555 | fn a() -> i32 { |
| 556 | return 1; |
| 557 | } |
| 558 | |
| 559 | fn f() { |
| 560 | var b : vec3<i32>; |
| 561 | var c : i32; |
| 562 | let tint_symbol = c; |
| 563 | let tint_symbol_1 = b[tint_symbol]; |
| 564 | let tint_symbol_2 = a(); |
| 565 | let r = (tint_symbol_1 + tint_symbol_2); |
| 566 | } |
| 567 | )"; |
| 568 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 569 | DataMap data; |
| 570 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 571 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 572 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 573 | } |
| 574 | |
| 575 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InCall) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 576 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 577 | fn a(i : i32) -> i32 { |
| 578 | return i; |
| 579 | } |
| 580 | |
| 581 | fn g(i : i32) -> i32 { |
| 582 | return i; |
| 583 | } |
| 584 | |
| 585 | fn f() { |
| 586 | var b = 1; |
| 587 | let r = g(a(0)) - g(b + a(1)); |
| 588 | } |
| 589 | )"; |
| 590 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 591 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 592 | fn a(i : i32) -> i32 { |
| 593 | return i; |
| 594 | } |
| 595 | |
| 596 | fn g(i : i32) -> i32 { |
| 597 | return i; |
| 598 | } |
| 599 | |
| 600 | fn f() { |
| 601 | var b = 1; |
| 602 | let tint_symbol = a(0); |
| 603 | let tint_symbol_1 = g(tint_symbol); |
| 604 | let tint_symbol_2 = b; |
| 605 | let tint_symbol_3 = a(1); |
| 606 | let tint_symbol_4 = g((tint_symbol_2 + tint_symbol_3)); |
| 607 | let r = (tint_symbol_1 - tint_symbol_4); |
| 608 | } |
| 609 | )"; |
| 610 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 611 | DataMap data; |
| 612 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 613 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 614 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 615 | } |
| 616 | |
| 617 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InTypeCtor) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 618 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 619 | |
| 620 | fn a(i : i32) -> i32 { |
| 621 | return 1; |
| 622 | } |
| 623 | |
| 624 | fn f() { |
| 625 | var b = 1; |
| 626 | let r = i32(a(0)) + i32(a(1) + b) - i32(a(2) - a(3)); |
| 627 | } |
| 628 | )"; |
| 629 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 630 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 631 | fn a(i : i32) -> i32 { |
| 632 | return 1; |
| 633 | } |
| 634 | |
| 635 | fn f() { |
| 636 | var b = 1; |
| 637 | let tint_symbol = a(0); |
| 638 | let tint_symbol_1 = i32(tint_symbol); |
| 639 | let tint_symbol_2 = a(1); |
| 640 | let tint_symbol_3 = i32((tint_symbol_2 + b)); |
| 641 | let tint_symbol_4 = a(2); |
| 642 | let tint_symbol_5 = a(3); |
| 643 | let tint_symbol_6 = i32((tint_symbol_4 - tint_symbol_5)); |
| 644 | let r = ((tint_symbol_1 + tint_symbol_3) - tint_symbol_6); |
| 645 | } |
| 646 | )"; |
| 647 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 648 | DataMap data; |
| 649 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 650 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 651 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 652 | } |
| 653 | |
| 654 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InTypeConversion) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 655 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 656 | |
| 657 | fn a(i : i32) -> i32 { |
| 658 | return 1; |
| 659 | } |
| 660 | |
| 661 | fn f() { |
| 662 | var b = 1u; |
| 663 | let r = u32(a(0)) + u32(a(1)) - b; |
| 664 | } |
| 665 | )"; |
| 666 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 667 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 668 | fn a(i : i32) -> i32 { |
| 669 | return 1; |
| 670 | } |
| 671 | |
| 672 | fn f() { |
| 673 | var b = 1u; |
| 674 | let tint_symbol = a(0); |
| 675 | let tint_symbol_1 = u32(tint_symbol); |
| 676 | let tint_symbol_2 = a(1); |
| 677 | let tint_symbol_3 = u32(tint_symbol_2); |
| 678 | let r = ((tint_symbol_1 + tint_symbol_3) - b); |
| 679 | } |
| 680 | )"; |
| 681 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 682 | DataMap data; |
| 683 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 684 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 685 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 686 | } |
| 687 | |
| 688 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InIntrinsic) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 689 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 690 | |
| 691 | fn a(i : i32) -> i32 { |
| 692 | return i; |
| 693 | } |
| 694 | |
| 695 | fn f() { |
| 696 | var b = 1; |
| 697 | let r = abs(a(0)) + abs(a(1) + b) - abs(a(2) + a(3)); |
| 698 | } |
| 699 | )"; |
| 700 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 701 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 702 | fn a(i : i32) -> i32 { |
| 703 | return i; |
| 704 | } |
| 705 | |
| 706 | fn f() { |
| 707 | var b = 1; |
| 708 | let tint_symbol = a(0); |
| 709 | let tint_symbol_1 = abs(tint_symbol); |
| 710 | let tint_symbol_2 = a(1); |
| 711 | let tint_symbol_3 = abs((tint_symbol_2 + b)); |
| 712 | let tint_symbol_4 = a(2); |
| 713 | let tint_symbol_5 = a(3); |
| 714 | let tint_symbol_6 = abs((tint_symbol_4 + tint_symbol_5)); |
| 715 | let r = ((tint_symbol_1 + tint_symbol_3) - tint_symbol_6); |
| 716 | } |
| 717 | )"; |
| 718 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 719 | DataMap data; |
| 720 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 721 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 722 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 723 | } |
| 724 | |
| 725 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InMemberAccessor) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 726 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 727 | |
| 728 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 729 | v : i32, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 730 | } |
| 731 | |
| 732 | fn a(i : i32) -> S { |
| 733 | return S(); |
| 734 | } |
| 735 | |
| 736 | fn f() { |
| 737 | var b = 1; |
| 738 | let r = a(0).v + b + a(1).v; |
| 739 | } |
| 740 | )"; |
| 741 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 742 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 743 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 744 | v : i32, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 745 | } |
| 746 | |
| 747 | fn a(i : i32) -> S { |
| 748 | return S(); |
| 749 | } |
| 750 | |
| 751 | fn f() { |
| 752 | var b = 1; |
| 753 | let tint_symbol = a(0); |
| 754 | let tint_symbol_1 = b; |
| 755 | let tint_symbol_2 = a(1); |
| 756 | let r = ((tint_symbol.v + tint_symbol_1) + tint_symbol_2.v); |
| 757 | } |
| 758 | )"; |
| 759 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 760 | DataMap data; |
| 761 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 762 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 763 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 764 | } |
| 765 | |
| 766 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InUnary) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 767 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 768 | fn a(i : i32) -> i32 { |
| 769 | return i; |
| 770 | } |
| 771 | |
| 772 | fn f() { |
| 773 | var b = 1; |
| 774 | let r = -a(0) + -(b + a(1)); |
| 775 | } |
| 776 | )"; |
| 777 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 778 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 779 | fn a(i : i32) -> i32 { |
| 780 | return i; |
| 781 | } |
| 782 | |
| 783 | fn f() { |
| 784 | var b = 1; |
| 785 | let tint_symbol = -(a(0)); |
| 786 | let tint_symbol_1 = b; |
| 787 | let tint_symbol_2 = a(1); |
| 788 | let r = (tint_symbol + -((tint_symbol_1 + tint_symbol_2))); |
| 789 | } |
| 790 | )"; |
| 791 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 792 | DataMap data; |
| 793 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 794 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 795 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 796 | } |
| 797 | |
| 798 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InBitcast) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 799 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 800 | fn a(i : i32) -> i32 { |
| 801 | return i; |
| 802 | } |
| 803 | |
| 804 | fn f() { |
| 805 | var b = 1; |
| 806 | let r = bitcast<u32>(a(0) + a(1)); |
| 807 | } |
| 808 | )"; |
| 809 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 810 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 811 | fn a(i : i32) -> i32 { |
| 812 | return i; |
| 813 | } |
| 814 | |
| 815 | fn f() { |
| 816 | var b = 1; |
| 817 | let tint_symbol = a(0); |
| 818 | let tint_symbol_1 = a(1); |
| 819 | let r = bitcast<u32>((tint_symbol + tint_symbol_1)); |
| 820 | } |
| 821 | )"; |
| 822 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 823 | DataMap data; |
| 824 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 825 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 826 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 827 | } |
| 828 | |
| 829 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InForLoopInit) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 830 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 831 | fn a(i : i32) -> i32 { |
| 832 | return i; |
| 833 | } |
| 834 | |
| 835 | fn f() { |
| 836 | var b = 1; |
| 837 | for(var r = a(0) + b; ; ) { |
| 838 | var marker = 0; |
| 839 | break; |
| 840 | } |
| 841 | } |
| 842 | )"; |
| 843 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 844 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 845 | fn a(i : i32) -> i32 { |
| 846 | return i; |
| 847 | } |
| 848 | |
| 849 | fn f() { |
| 850 | var b = 1; |
| 851 | let tint_symbol = a(0); |
| 852 | for(var r = (tint_symbol + b); ; ) { |
| 853 | var marker = 0; |
| 854 | break; |
| 855 | } |
| 856 | } |
| 857 | )"; |
| 858 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 859 | DataMap data; |
| 860 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 861 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 862 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 863 | } |
| 864 | |
| 865 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InForLoopCond) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 866 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 867 | fn a(i : i32) -> i32 { |
| 868 | return i; |
| 869 | } |
| 870 | |
| 871 | fn f() { |
| 872 | var b = 1; |
| 873 | for(; a(0) + b > 0;) { |
| 874 | var marker = 0; |
| 875 | } |
| 876 | } |
| 877 | )"; |
| 878 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 879 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 880 | fn a(i : i32) -> i32 { |
| 881 | return i; |
| 882 | } |
| 883 | |
| 884 | fn f() { |
| 885 | var b = 1; |
| 886 | loop { |
| 887 | let tint_symbol = a(0); |
| 888 | if (!(((tint_symbol + b) > 0))) { |
| 889 | break; |
| 890 | } |
| 891 | { |
| 892 | var marker = 0; |
| 893 | } |
| 894 | } |
| 895 | } |
| 896 | )"; |
| 897 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 898 | DataMap data; |
| 899 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 900 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 901 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 902 | } |
| 903 | |
| 904 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InForLoopCont) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 905 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 906 | fn a(i : i32) -> i32 { |
| 907 | return i; |
| 908 | } |
| 909 | |
| 910 | fn f() { |
| 911 | var b = 1; |
| 912 | var r = 0; |
| 913 | for(; ; r = a(0) + b) { |
| 914 | var marker = 0; |
| 915 | break; |
| 916 | } |
| 917 | } |
| 918 | )"; |
| 919 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 920 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 921 | fn a(i : i32) -> i32 { |
| 922 | return i; |
| 923 | } |
| 924 | |
| 925 | fn f() { |
| 926 | var b = 1; |
| 927 | var r = 0; |
| 928 | loop { |
| 929 | { |
| 930 | var marker = 0; |
| 931 | break; |
| 932 | } |
| 933 | |
| 934 | continuing { |
| 935 | let tint_symbol = a(0); |
| 936 | r = (tint_symbol + b); |
| 937 | } |
| 938 | } |
| 939 | } |
| 940 | )"; |
| 941 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 942 | DataMap data; |
| 943 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 944 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 945 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 946 | } |
| 947 | |
| 948 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InForLoopInitCondCont) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 949 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 950 | fn a(i : i32) -> i32 { |
| 951 | return i; |
| 952 | } |
| 953 | |
| 954 | fn f() { |
| 955 | var b = 1; |
| 956 | var c = 2; |
| 957 | var d = 3; |
| 958 | var r = 0; |
| 959 | for(var r = a(0) + b; a(1) + c > 0; r = a(2) + d) { |
| 960 | var marker = 0; |
| 961 | } |
| 962 | } |
| 963 | )"; |
| 964 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 965 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 966 | fn a(i : i32) -> i32 { |
| 967 | return i; |
| 968 | } |
| 969 | |
| 970 | fn f() { |
| 971 | var b = 1; |
| 972 | var c = 2; |
| 973 | var d = 3; |
| 974 | var r = 0; |
| 975 | { |
| 976 | let tint_symbol = a(0); |
| 977 | var r = (tint_symbol + b); |
| 978 | loop { |
| 979 | let tint_symbol_1 = a(1); |
| 980 | if (!(((tint_symbol_1 + c) > 0))) { |
| 981 | break; |
| 982 | } |
| 983 | { |
| 984 | var marker = 0; |
| 985 | } |
| 986 | |
| 987 | continuing { |
| 988 | let tint_symbol_2 = a(2); |
| 989 | r = (tint_symbol_2 + d); |
| 990 | } |
| 991 | } |
| 992 | } |
| 993 | } |
| 994 | )"; |
| 995 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 996 | DataMap data; |
| 997 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 998 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 999 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1000 | } |
| 1001 | |
| 1002 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InElseIf) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1003 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1004 | fn a(i : i32) -> i32 { |
| 1005 | return i; |
| 1006 | } |
| 1007 | |
| 1008 | fn f() { |
| 1009 | var b = 1; |
| 1010 | if (true) { |
| 1011 | var marker = 0; |
| 1012 | } else if (a(0) + b > 0) { |
| 1013 | var marker = 1; |
| 1014 | } |
| 1015 | } |
| 1016 | )"; |
| 1017 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1018 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1019 | fn a(i : i32) -> i32 { |
| 1020 | return i; |
| 1021 | } |
| 1022 | |
| 1023 | fn f() { |
| 1024 | var b = 1; |
| 1025 | if (true) { |
| 1026 | var marker = 0; |
| 1027 | } else { |
| 1028 | let tint_symbol = a(0); |
| 1029 | if (((tint_symbol + b) > 0)) { |
| 1030 | var marker = 1; |
| 1031 | } |
| 1032 | } |
| 1033 | } |
| 1034 | )"; |
| 1035 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1036 | DataMap data; |
| 1037 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1038 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1039 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1040 | } |
| 1041 | |
| 1042 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InElseIfChain) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1043 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1044 | fn a(i : i32) -> i32 { |
| 1045 | return i; |
| 1046 | } |
| 1047 | |
| 1048 | fn f() { |
| 1049 | var b = 1; |
| 1050 | if (true) { |
| 1051 | var marker = 0; |
| 1052 | } else if (true) { |
| 1053 | var marker = 1; |
| 1054 | } else if (a(0) + b > 0) { |
| 1055 | var marker = 2; |
| 1056 | } else if (a(1) + a(2) > 0) { |
| 1057 | var marker = 3; |
| 1058 | } else if (true) { |
| 1059 | var marker = 4; |
| 1060 | } else { |
| 1061 | var marker = 5; |
| 1062 | } |
| 1063 | } |
| 1064 | )"; |
| 1065 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1066 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1067 | fn a(i : i32) -> i32 { |
| 1068 | return i; |
| 1069 | } |
| 1070 | |
| 1071 | fn f() { |
| 1072 | var b = 1; |
| 1073 | if (true) { |
| 1074 | var marker = 0; |
| 1075 | } else if (true) { |
| 1076 | var marker = 1; |
| 1077 | } else { |
| 1078 | let tint_symbol = a(0); |
| 1079 | if (((tint_symbol + b) > 0)) { |
| 1080 | var marker = 2; |
| 1081 | } else { |
| 1082 | let tint_symbol_1 = a(1); |
| 1083 | let tint_symbol_2 = a(2); |
| 1084 | if (((tint_symbol_1 + tint_symbol_2) > 0)) { |
| 1085 | var marker = 3; |
| 1086 | } else if (true) { |
| 1087 | var marker = 4; |
| 1088 | } else { |
| 1089 | var marker = 5; |
| 1090 | } |
| 1091 | } |
| 1092 | } |
| 1093 | } |
| 1094 | )"; |
| 1095 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1096 | DataMap data; |
| 1097 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1098 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1099 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1100 | } |
| 1101 | |
| 1102 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InReturn) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1103 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1104 | fn a(i : i32) -> i32 { |
| 1105 | return i; |
| 1106 | } |
| 1107 | |
| 1108 | fn f() -> i32 { |
| 1109 | var b = 1; |
| 1110 | return b + a(0); |
| 1111 | } |
| 1112 | )"; |
| 1113 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1114 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1115 | fn a(i : i32) -> i32 { |
| 1116 | return i; |
| 1117 | } |
| 1118 | |
| 1119 | fn f() -> i32 { |
| 1120 | var b = 1; |
| 1121 | let tint_symbol = b; |
| 1122 | let tint_symbol_1 = a(0); |
| 1123 | return (tint_symbol + tint_symbol_1); |
| 1124 | } |
| 1125 | )"; |
| 1126 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1127 | DataMap data; |
| 1128 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1129 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1130 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1131 | } |
| 1132 | |
| 1133 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Arith_InSwitch) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1134 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1135 | fn a(i : i32) -> i32 { |
| 1136 | return i; |
| 1137 | } |
| 1138 | |
| 1139 | fn f() { |
| 1140 | var b = 1; |
| 1141 | switch (b + a(0)) { |
| 1142 | default: { |
| 1143 | } |
| 1144 | } |
| 1145 | } |
| 1146 | )"; |
| 1147 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1148 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1149 | fn a(i : i32) -> i32 { |
| 1150 | return i; |
| 1151 | } |
| 1152 | |
| 1153 | fn f() { |
| 1154 | var b = 1; |
| 1155 | let tint_symbol = b; |
| 1156 | let tint_symbol_1 = a(0); |
| 1157 | switch((tint_symbol + tint_symbol_1)) { |
| 1158 | default: { |
| 1159 | } |
| 1160 | } |
| 1161 | } |
| 1162 | )"; |
| 1163 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1164 | DataMap data; |
| 1165 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1166 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1167 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1168 | } |
| 1169 | |
| 1170 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_LeftSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1171 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1172 | fn a(i : i32) -> bool { |
| 1173 | return true; |
| 1174 | } |
| 1175 | |
| 1176 | fn f() { |
| 1177 | var b = true; |
| 1178 | let r = a(0) && b; |
| 1179 | } |
| 1180 | )"; |
| 1181 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1182 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1183 | fn a(i : i32) -> bool { |
| 1184 | return true; |
| 1185 | } |
| 1186 | |
| 1187 | fn f() { |
| 1188 | var b = true; |
| 1189 | var tint_symbol = a(0); |
| 1190 | if (tint_symbol) { |
| 1191 | tint_symbol = b; |
| 1192 | } |
| 1193 | let r = tint_symbol; |
| 1194 | } |
| 1195 | )"; |
| 1196 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1197 | DataMap data; |
| 1198 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1199 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1200 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1201 | } |
| 1202 | |
| 1203 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_RightSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1204 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1205 | fn a(i : i32) -> bool { |
| 1206 | return true; |
| 1207 | } |
| 1208 | |
| 1209 | fn f() { |
| 1210 | var b = true; |
| 1211 | let r = b && a(0); |
| 1212 | } |
| 1213 | )"; |
| 1214 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1215 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1216 | fn a(i : i32) -> bool { |
| 1217 | return true; |
| 1218 | } |
| 1219 | |
| 1220 | fn f() { |
| 1221 | var b = true; |
| 1222 | var tint_symbol = b; |
| 1223 | if (tint_symbol) { |
| 1224 | tint_symbol = a(0); |
| 1225 | } |
| 1226 | let r = tint_symbol; |
| 1227 | } |
| 1228 | )"; |
| 1229 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1230 | DataMap data; |
| 1231 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1232 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1233 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1234 | } |
| 1235 | |
| 1236 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_BothSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1237 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1238 | fn a(i : i32) -> bool { |
| 1239 | return true; |
| 1240 | } |
| 1241 | |
| 1242 | fn f() { |
| 1243 | let r = a(0) && a(1); |
| 1244 | } |
| 1245 | )"; |
| 1246 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1247 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1248 | fn a(i : i32) -> bool { |
| 1249 | return true; |
| 1250 | } |
| 1251 | |
| 1252 | fn f() { |
| 1253 | var tint_symbol = a(0); |
| 1254 | if (tint_symbol) { |
| 1255 | tint_symbol = a(1); |
| 1256 | } |
| 1257 | let r = tint_symbol; |
| 1258 | } |
| 1259 | )"; |
| 1260 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1261 | DataMap data; |
| 1262 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1263 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1264 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1265 | } |
| 1266 | |
| 1267 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_LeftmostSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1268 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1269 | fn a(i : i32) -> bool { |
| 1270 | return true; |
| 1271 | } |
| 1272 | |
| 1273 | fn f() { |
| 1274 | var b = true; |
| 1275 | var c = true; |
| 1276 | var d = true; |
| 1277 | let r = a(0) && b && c && d; |
| 1278 | } |
| 1279 | )"; |
| 1280 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1281 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1282 | fn a(i : i32) -> bool { |
| 1283 | return true; |
| 1284 | } |
| 1285 | |
| 1286 | fn f() { |
| 1287 | var b = true; |
| 1288 | var c = true; |
| 1289 | var d = true; |
| 1290 | var tint_symbol_2 = a(0); |
| 1291 | if (tint_symbol_2) { |
| 1292 | tint_symbol_2 = b; |
| 1293 | } |
| 1294 | var tint_symbol_1 = tint_symbol_2; |
| 1295 | if (tint_symbol_1) { |
| 1296 | tint_symbol_1 = c; |
| 1297 | } |
| 1298 | var tint_symbol = tint_symbol_1; |
| 1299 | if (tint_symbol) { |
| 1300 | tint_symbol = d; |
| 1301 | } |
| 1302 | let r = tint_symbol; |
| 1303 | } |
| 1304 | )"; |
| 1305 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1306 | DataMap data; |
| 1307 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1308 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1309 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1310 | } |
| 1311 | |
| 1312 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_RightmostSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1313 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1314 | fn a(i : i32) -> bool { |
| 1315 | return true; |
| 1316 | } |
| 1317 | |
| 1318 | fn f() { |
| 1319 | var b = true; |
| 1320 | var c = true; |
| 1321 | var d = true; |
| 1322 | let r = b && c && d && a(0); |
| 1323 | } |
| 1324 | )"; |
| 1325 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1326 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1327 | fn a(i : i32) -> bool { |
| 1328 | return true; |
| 1329 | } |
| 1330 | |
| 1331 | fn f() { |
| 1332 | var b = true; |
| 1333 | var c = true; |
| 1334 | var d = true; |
| 1335 | var tint_symbol = ((b && c) && d); |
| 1336 | if (tint_symbol) { |
| 1337 | tint_symbol = a(0); |
| 1338 | } |
| 1339 | let r = tint_symbol; |
| 1340 | } |
| 1341 | )"; |
| 1342 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1343 | DataMap data; |
| 1344 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1345 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1346 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1347 | } |
| 1348 | |
| 1349 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_MiddleSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1350 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1351 | fn a(i : i32) -> bool { |
| 1352 | return true; |
| 1353 | } |
| 1354 | |
| 1355 | fn f() { |
| 1356 | var b = true; |
| 1357 | var c = true; |
| 1358 | var d = true; |
| 1359 | let r = b && c && a(0) && c && d; |
| 1360 | } |
| 1361 | )"; |
| 1362 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1363 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1364 | fn a(i : i32) -> bool { |
| 1365 | return true; |
| 1366 | } |
| 1367 | |
| 1368 | fn f() { |
| 1369 | var b = true; |
| 1370 | var c = true; |
| 1371 | var d = true; |
| 1372 | var tint_symbol_2 = (b && c); |
| 1373 | if (tint_symbol_2) { |
| 1374 | tint_symbol_2 = a(0); |
| 1375 | } |
| 1376 | var tint_symbol_1 = tint_symbol_2; |
| 1377 | if (tint_symbol_1) { |
| 1378 | tint_symbol_1 = c; |
| 1379 | } |
| 1380 | var tint_symbol = tint_symbol_1; |
| 1381 | if (tint_symbol) { |
| 1382 | tint_symbol = d; |
| 1383 | } |
| 1384 | let r = tint_symbol; |
| 1385 | } |
| 1386 | )"; |
| 1387 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1388 | DataMap data; |
| 1389 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1390 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1391 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1392 | } |
| 1393 | |
| 1394 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_Constants_NoRecvSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1395 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1396 | fn a(i : i32) -> bool { |
| 1397 | return true; |
| 1398 | } |
| 1399 | |
| 1400 | fn f() { |
| 1401 | let r = true && a(0) && false && a(1); |
| 1402 | } |
| 1403 | )"; |
| 1404 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1405 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1406 | fn a(i : i32) -> bool { |
| 1407 | return true; |
| 1408 | } |
| 1409 | |
| 1410 | fn f() { |
| 1411 | var tint_symbol_2 = true; |
| 1412 | if (tint_symbol_2) { |
| 1413 | tint_symbol_2 = a(0); |
| 1414 | } |
| 1415 | var tint_symbol_1 = tint_symbol_2; |
| 1416 | if (tint_symbol_1) { |
| 1417 | tint_symbol_1 = false; |
| 1418 | } |
| 1419 | var tint_symbol = tint_symbol_1; |
| 1420 | if (tint_symbol) { |
| 1421 | tint_symbol = a(1); |
| 1422 | } |
| 1423 | let r = tint_symbol; |
| 1424 | } |
| 1425 | )"; |
| 1426 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1427 | DataMap data; |
| 1428 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1429 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1430 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1431 | } |
| 1432 | |
| 1433 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_Constants_RecvSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1434 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1435 | fn a(i : i32) -> bool { |
| 1436 | return true; |
| 1437 | } |
| 1438 | |
| 1439 | fn f() { |
| 1440 | var b = true; |
| 1441 | let r = b && true && a(0) && false && a(1); |
| 1442 | } |
| 1443 | )"; |
| 1444 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1445 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1446 | fn a(i : i32) -> bool { |
| 1447 | return true; |
| 1448 | } |
| 1449 | |
| 1450 | fn f() { |
| 1451 | var b = true; |
| 1452 | var tint_symbol_2 = (b && true); |
| 1453 | if (tint_symbol_2) { |
| 1454 | tint_symbol_2 = a(0); |
| 1455 | } |
| 1456 | var tint_symbol_1 = tint_symbol_2; |
| 1457 | if (tint_symbol_1) { |
| 1458 | tint_symbol_1 = false; |
| 1459 | } |
| 1460 | var tint_symbol = tint_symbol_1; |
| 1461 | if (tint_symbol) { |
| 1462 | tint_symbol = a(1); |
| 1463 | } |
| 1464 | let r = tint_symbol; |
| 1465 | } |
| 1466 | )"; |
| 1467 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1468 | DataMap data; |
| 1469 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1470 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1471 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1472 | } |
| 1473 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1474 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_Constants_ConstAndSEAndVar) { |
| 1475 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1476 | fn a(i : i32) -> bool { |
| 1477 | return true; |
| 1478 | } |
| 1479 | |
| 1480 | fn main() { |
| 1481 | var b = true; |
| 1482 | var c = true; |
| 1483 | let r = true && a(0) && b; |
| 1484 | } |
| 1485 | )"; |
| 1486 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1487 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1488 | fn a(i : i32) -> bool { |
| 1489 | return true; |
| 1490 | } |
| 1491 | |
| 1492 | fn main() { |
| 1493 | var b = true; |
| 1494 | var c = true; |
| 1495 | var tint_symbol_1 = true; |
| 1496 | if (tint_symbol_1) { |
| 1497 | tint_symbol_1 = a(0); |
| 1498 | } |
| 1499 | var tint_symbol = tint_symbol_1; |
| 1500 | if (tint_symbol) { |
| 1501 | tint_symbol = b; |
| 1502 | } |
| 1503 | let r = tint_symbol; |
| 1504 | } |
| 1505 | )"; |
| 1506 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1507 | DataMap data; |
| 1508 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1509 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1510 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1511 | } |
| 1512 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1513 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_Constants_VarAndSEAndConst) { |
| 1514 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1515 | fn a(i : i32) -> bool { |
| 1516 | return true; |
| 1517 | } |
| 1518 | |
| 1519 | fn main() { |
| 1520 | var b = true; |
| 1521 | let r = b && a(0) && true; |
| 1522 | } |
| 1523 | )"; |
| 1524 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1525 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1526 | fn a(i : i32) -> bool { |
| 1527 | return true; |
| 1528 | } |
| 1529 | |
| 1530 | fn main() { |
| 1531 | var b = true; |
| 1532 | var tint_symbol_1 = b; |
| 1533 | if (tint_symbol_1) { |
| 1534 | tint_symbol_1 = a(0); |
| 1535 | } |
| 1536 | var tint_symbol = tint_symbol_1; |
| 1537 | if (tint_symbol) { |
| 1538 | tint_symbol = true; |
| 1539 | } |
| 1540 | let r = tint_symbol; |
| 1541 | } |
| 1542 | )"; |
| 1543 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1544 | DataMap data; |
| 1545 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1546 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1547 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1548 | } |
| 1549 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1550 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_Constants_SEAndVarAndConstAndVar) { |
| 1551 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1552 | fn a(i : i32) -> bool { |
| 1553 | return true; |
| 1554 | } |
| 1555 | |
| 1556 | fn main() { |
| 1557 | var b = true; |
| 1558 | var c = true; |
| 1559 | let r = a(0) && b && true && c; |
| 1560 | } |
| 1561 | )"; |
| 1562 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1563 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1564 | fn a(i : i32) -> bool { |
| 1565 | return true; |
| 1566 | } |
| 1567 | |
| 1568 | fn main() { |
| 1569 | var b = true; |
| 1570 | var c = true; |
| 1571 | var tint_symbol_2 = a(0); |
| 1572 | if (tint_symbol_2) { |
| 1573 | tint_symbol_2 = b; |
| 1574 | } |
| 1575 | var tint_symbol_1 = tint_symbol_2; |
| 1576 | if (tint_symbol_1) { |
| 1577 | tint_symbol_1 = true; |
| 1578 | } |
| 1579 | var tint_symbol = tint_symbol_1; |
| 1580 | if (tint_symbol) { |
| 1581 | tint_symbol = c; |
| 1582 | } |
| 1583 | let r = tint_symbol; |
| 1584 | } |
| 1585 | )"; |
| 1586 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1587 | DataMap data; |
| 1588 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1589 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1590 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1591 | } |
| 1592 | |
| 1593 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_MixedSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1594 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1595 | fn a(i : i32) -> bool { |
| 1596 | return true; |
| 1597 | } |
| 1598 | |
| 1599 | fn f() { |
| 1600 | var b = true; |
| 1601 | var c = true; |
| 1602 | var d = true; |
| 1603 | let r = b && a(0) || c && a(1) && c && d || a(2); |
| 1604 | } |
| 1605 | )"; |
| 1606 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1607 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1608 | fn a(i : i32) -> bool { |
| 1609 | return true; |
| 1610 | } |
| 1611 | |
| 1612 | fn f() { |
| 1613 | var b = true; |
| 1614 | var c = true; |
| 1615 | var d = true; |
| 1616 | var tint_symbol_2 = b; |
| 1617 | if (tint_symbol_2) { |
| 1618 | tint_symbol_2 = a(0); |
| 1619 | } |
| 1620 | var tint_symbol_1 = tint_symbol_2; |
| 1621 | if (!(tint_symbol_1)) { |
| 1622 | var tint_symbol_5 = c; |
| 1623 | if (tint_symbol_5) { |
| 1624 | tint_symbol_5 = a(1); |
| 1625 | } |
| 1626 | var tint_symbol_4 = tint_symbol_5; |
| 1627 | if (tint_symbol_4) { |
| 1628 | tint_symbol_4 = c; |
| 1629 | } |
| 1630 | var tint_symbol_3 = tint_symbol_4; |
| 1631 | if (tint_symbol_3) { |
| 1632 | tint_symbol_3 = d; |
| 1633 | } |
| 1634 | tint_symbol_1 = tint_symbol_3; |
| 1635 | } |
| 1636 | var tint_symbol = tint_symbol_1; |
| 1637 | if (!(tint_symbol)) { |
| 1638 | tint_symbol = a(2); |
| 1639 | } |
| 1640 | let r = tint_symbol; |
| 1641 | } |
| 1642 | )"; |
| 1643 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1644 | DataMap data; |
| 1645 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1646 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1647 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1648 | } |
| 1649 | |
| 1650 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_NestedAnds) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1651 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1652 | fn a(i : i32) -> bool { |
| 1653 | return true; |
| 1654 | } |
| 1655 | |
| 1656 | fn f() { |
| 1657 | let r = a(0) && (a(1) && (a(2) && (a(3) && (a(4) && a(5))))); |
| 1658 | } |
| 1659 | )"; |
| 1660 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1661 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1662 | fn a(i : i32) -> bool { |
| 1663 | return true; |
| 1664 | } |
| 1665 | |
| 1666 | fn f() { |
| 1667 | var tint_symbol = a(0); |
| 1668 | if (tint_symbol) { |
| 1669 | var tint_symbol_1 = a(1); |
| 1670 | if (tint_symbol_1) { |
| 1671 | var tint_symbol_2 = a(2); |
| 1672 | if (tint_symbol_2) { |
| 1673 | var tint_symbol_3 = a(3); |
| 1674 | if (tint_symbol_3) { |
| 1675 | var tint_symbol_4 = a(4); |
| 1676 | if (tint_symbol_4) { |
| 1677 | tint_symbol_4 = a(5); |
| 1678 | } |
| 1679 | tint_symbol_3 = tint_symbol_4; |
| 1680 | } |
| 1681 | tint_symbol_2 = tint_symbol_3; |
| 1682 | } |
| 1683 | tint_symbol_1 = tint_symbol_2; |
| 1684 | } |
| 1685 | tint_symbol = tint_symbol_1; |
| 1686 | } |
| 1687 | let r = tint_symbol; |
| 1688 | } |
| 1689 | )"; |
| 1690 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1691 | DataMap data; |
| 1692 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1693 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1694 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1695 | } |
| 1696 | |
| 1697 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_NestedOrs) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1698 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1699 | fn a(i : i32) -> bool { |
| 1700 | return true; |
| 1701 | } |
| 1702 | |
| 1703 | fn f() { |
| 1704 | let r = a(0) || (a(1) || (a(2) || (a(3) || (a(4) || a(5))))); |
| 1705 | } |
| 1706 | )"; |
| 1707 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1708 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1709 | fn a(i : i32) -> bool { |
| 1710 | return true; |
| 1711 | } |
| 1712 | |
| 1713 | fn f() { |
| 1714 | var tint_symbol = a(0); |
| 1715 | if (!(tint_symbol)) { |
| 1716 | var tint_symbol_1 = a(1); |
| 1717 | if (!(tint_symbol_1)) { |
| 1718 | var tint_symbol_2 = a(2); |
| 1719 | if (!(tint_symbol_2)) { |
| 1720 | var tint_symbol_3 = a(3); |
| 1721 | if (!(tint_symbol_3)) { |
| 1722 | var tint_symbol_4 = a(4); |
| 1723 | if (!(tint_symbol_4)) { |
| 1724 | tint_symbol_4 = a(5); |
| 1725 | } |
| 1726 | tint_symbol_3 = tint_symbol_4; |
| 1727 | } |
| 1728 | tint_symbol_2 = tint_symbol_3; |
| 1729 | } |
| 1730 | tint_symbol_1 = tint_symbol_2; |
| 1731 | } |
| 1732 | tint_symbol = tint_symbol_1; |
| 1733 | } |
| 1734 | let r = tint_symbol; |
| 1735 | } |
| 1736 | )"; |
| 1737 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1738 | DataMap data; |
| 1739 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1740 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1741 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1742 | } |
| 1743 | |
| 1744 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_MultipleStatements) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1745 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1746 | fn a(i : i32) -> bool { |
| 1747 | return true; |
| 1748 | } |
| 1749 | |
| 1750 | fn f() { |
| 1751 | var b = true; |
| 1752 | let r1 = b && a(0); |
| 1753 | let r2 = a(1) || b; |
| 1754 | } |
| 1755 | )"; |
| 1756 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1757 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1758 | fn a(i : i32) -> bool { |
| 1759 | return true; |
| 1760 | } |
| 1761 | |
| 1762 | fn f() { |
| 1763 | var b = true; |
| 1764 | var tint_symbol = b; |
| 1765 | if (tint_symbol) { |
| 1766 | tint_symbol = a(0); |
| 1767 | } |
| 1768 | let r1 = tint_symbol; |
| 1769 | var tint_symbol_1 = a(1); |
| 1770 | if (!(tint_symbol_1)) { |
| 1771 | tint_symbol_1 = b; |
| 1772 | } |
| 1773 | let r2 = tint_symbol_1; |
| 1774 | } |
| 1775 | )"; |
| 1776 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1777 | DataMap data; |
| 1778 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1779 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1780 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1781 | } |
| 1782 | |
| 1783 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InCall) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1784 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1785 | fn a(i : i32) -> bool { |
| 1786 | return true; |
| 1787 | } |
| 1788 | |
| 1789 | fn g(v : bool) -> bool { |
| 1790 | return v; |
| 1791 | } |
| 1792 | |
| 1793 | fn f() { |
| 1794 | var b = true; |
| 1795 | g(b && a(1)); |
| 1796 | } |
| 1797 | )"; |
| 1798 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1799 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1800 | fn a(i : i32) -> bool { |
| 1801 | return true; |
| 1802 | } |
| 1803 | |
| 1804 | fn g(v : bool) -> bool { |
| 1805 | return v; |
| 1806 | } |
| 1807 | |
| 1808 | fn f() { |
| 1809 | var b = true; |
| 1810 | var tint_symbol = b; |
| 1811 | if (tint_symbol) { |
| 1812 | tint_symbol = a(1); |
| 1813 | } |
| 1814 | g(tint_symbol); |
| 1815 | } |
| 1816 | )"; |
| 1817 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1818 | DataMap data; |
| 1819 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1820 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1821 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1822 | } |
| 1823 | |
| 1824 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InTypeCtor) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1825 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1826 | |
| 1827 | fn a(i : i32) -> bool { |
| 1828 | return true; |
| 1829 | } |
| 1830 | |
| 1831 | fn f() { |
| 1832 | var b = true; |
| 1833 | let r = bool(a(0)) && bool(a(1) && b) || bool(a(2) && a(3)); |
| 1834 | } |
| 1835 | )"; |
| 1836 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1837 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1838 | fn a(i : i32) -> bool { |
| 1839 | return true; |
| 1840 | } |
| 1841 | |
| 1842 | fn f() { |
| 1843 | var b = true; |
| 1844 | let tint_symbol_2 = a(0); |
| 1845 | var tint_symbol_1 = bool(tint_symbol_2); |
| 1846 | if (tint_symbol_1) { |
| 1847 | var tint_symbol_3 = a(1); |
| 1848 | if (tint_symbol_3) { |
| 1849 | tint_symbol_3 = b; |
| 1850 | } |
| 1851 | tint_symbol_1 = bool(tint_symbol_3); |
| 1852 | } |
| 1853 | var tint_symbol = tint_symbol_1; |
| 1854 | if (!(tint_symbol)) { |
| 1855 | var tint_symbol_4 = a(2); |
| 1856 | if (tint_symbol_4) { |
| 1857 | tint_symbol_4 = a(3); |
| 1858 | } |
| 1859 | tint_symbol = bool(tint_symbol_4); |
| 1860 | } |
| 1861 | let r = tint_symbol; |
| 1862 | } |
| 1863 | )"; |
| 1864 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1865 | DataMap data; |
| 1866 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1867 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1868 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1869 | } |
| 1870 | |
| 1871 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InTypeConversion) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1872 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1873 | |
| 1874 | fn a(i : i32) -> i32 { |
| 1875 | return 1; |
| 1876 | } |
| 1877 | |
| 1878 | fn f() { |
| 1879 | var b = true; |
| 1880 | let r = bool(a(0)) && bool(a(1)) || b; |
| 1881 | } |
| 1882 | )"; |
| 1883 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1884 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1885 | fn a(i : i32) -> i32 { |
| 1886 | return 1; |
| 1887 | } |
| 1888 | |
| 1889 | fn f() { |
| 1890 | var b = true; |
| 1891 | let tint_symbol_2 = a(0); |
| 1892 | var tint_symbol_1 = bool(tint_symbol_2); |
| 1893 | if (tint_symbol_1) { |
| 1894 | let tint_symbol_3 = a(1); |
| 1895 | tint_symbol_1 = bool(tint_symbol_3); |
| 1896 | } |
| 1897 | var tint_symbol = tint_symbol_1; |
| 1898 | if (!(tint_symbol)) { |
| 1899 | tint_symbol = b; |
| 1900 | } |
| 1901 | let r = tint_symbol; |
| 1902 | } |
| 1903 | )"; |
| 1904 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1905 | DataMap data; |
| 1906 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1907 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1908 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1909 | } |
| 1910 | |
| 1911 | // Make sure we process logical binary expressions of non-logical binary |
| 1912 | // expressions. |
| 1913 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_OfNonLogical) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1914 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1915 | |
| 1916 | fn a(i : i32) -> i32 { |
| 1917 | return 1; |
| 1918 | } |
| 1919 | |
| 1920 | fn f() { |
| 1921 | var b = 1; |
| 1922 | let r = bool(a(0) == b) && bool(a(1) == b); |
| 1923 | } |
| 1924 | )"; |
| 1925 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1926 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1927 | fn a(i : i32) -> i32 { |
| 1928 | return 1; |
| 1929 | } |
| 1930 | |
| 1931 | fn f() { |
| 1932 | var b = 1; |
| 1933 | let tint_symbol_1 = a(0); |
| 1934 | var tint_symbol = bool((tint_symbol_1 == b)); |
| 1935 | if (tint_symbol) { |
| 1936 | let tint_symbol_2 = a(1); |
| 1937 | tint_symbol = bool((tint_symbol_2 == b)); |
| 1938 | } |
| 1939 | let r = tint_symbol; |
| 1940 | } |
| 1941 | )"; |
| 1942 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1943 | DataMap data; |
| 1944 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1945 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1946 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1947 | } |
| 1948 | |
| 1949 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InIntrinsic) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1950 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1951 | |
| 1952 | fn a(i : i32) -> bool { |
| 1953 | return true; |
| 1954 | } |
| 1955 | |
| 1956 | fn f() { |
| 1957 | var b = true; |
| 1958 | let r = all(a(0)) && all(a(1) && b) || all(a(2) && a(3)); |
| 1959 | } |
| 1960 | )"; |
| 1961 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1962 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1963 | fn a(i : i32) -> bool { |
| 1964 | return true; |
| 1965 | } |
| 1966 | |
| 1967 | fn f() { |
| 1968 | var b = true; |
| 1969 | let tint_symbol_2 = a(0); |
| 1970 | var tint_symbol_1 = all(tint_symbol_2); |
| 1971 | if (tint_symbol_1) { |
| 1972 | var tint_symbol_3 = a(1); |
| 1973 | if (tint_symbol_3) { |
| 1974 | tint_symbol_3 = b; |
| 1975 | } |
| 1976 | tint_symbol_1 = all(tint_symbol_3); |
| 1977 | } |
| 1978 | var tint_symbol = tint_symbol_1; |
| 1979 | if (!(tint_symbol)) { |
| 1980 | var tint_symbol_4 = a(2); |
| 1981 | if (tint_symbol_4) { |
| 1982 | tint_symbol_4 = a(3); |
| 1983 | } |
| 1984 | tint_symbol = all(tint_symbol_4); |
| 1985 | } |
| 1986 | let r = tint_symbol; |
| 1987 | } |
| 1988 | )"; |
| 1989 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1990 | DataMap data; |
| 1991 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1992 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1993 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1994 | } |
| 1995 | |
| 1996 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InMemberAccessor) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 1997 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 1998 | |
| 1999 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 2000 | v : bool, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2001 | } |
| 2002 | |
| 2003 | fn a(i : i32) -> S { |
| 2004 | return S(); |
| 2005 | } |
| 2006 | |
| 2007 | fn f() { |
| 2008 | var b = true; |
| 2009 | let r = a(0).v && b && a(1).v; |
| 2010 | } |
| 2011 | )"; |
| 2012 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2013 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2014 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 2015 | v : bool, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2016 | } |
| 2017 | |
| 2018 | fn a(i : i32) -> S { |
| 2019 | return S(); |
| 2020 | } |
| 2021 | |
| 2022 | fn f() { |
| 2023 | var b = true; |
| 2024 | let tint_symbol_2 = a(0); |
| 2025 | var tint_symbol_1 = tint_symbol_2.v; |
| 2026 | if (tint_symbol_1) { |
| 2027 | tint_symbol_1 = b; |
| 2028 | } |
| 2029 | var tint_symbol = tint_symbol_1; |
| 2030 | if (tint_symbol) { |
| 2031 | let tint_symbol_3 = a(1); |
| 2032 | tint_symbol = tint_symbol_3.v; |
| 2033 | } |
| 2034 | let r = tint_symbol; |
| 2035 | } |
| 2036 | )"; |
| 2037 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2038 | DataMap data; |
| 2039 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2040 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2041 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2042 | } |
| 2043 | |
| 2044 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InUnary) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2045 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2046 | |
| 2047 | fn a(i : i32) -> bool { |
| 2048 | return true; |
| 2049 | } |
| 2050 | |
| 2051 | fn f() { |
| 2052 | var b = true; |
| 2053 | let r = !(b || a(1)); |
| 2054 | } |
| 2055 | )"; |
| 2056 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2057 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2058 | fn a(i : i32) -> bool { |
| 2059 | return true; |
| 2060 | } |
| 2061 | |
| 2062 | fn f() { |
| 2063 | var b = true; |
| 2064 | var tint_symbol = b; |
| 2065 | if (!(tint_symbol)) { |
| 2066 | tint_symbol = a(1); |
| 2067 | } |
| 2068 | let r = !(tint_symbol); |
| 2069 | } |
| 2070 | )"; |
| 2071 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2072 | DataMap data; |
| 2073 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2074 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2075 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2076 | } |
| 2077 | |
| 2078 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InBitcast) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2079 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2080 | fn a(i : i32) -> bool { |
| 2081 | return true; |
| 2082 | } |
| 2083 | |
| 2084 | fn f() { |
| 2085 | var b = true; |
| 2086 | let r = bitcast<u32>(i32(a(0) && a(1))); |
| 2087 | } |
| 2088 | )"; |
| 2089 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2090 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2091 | fn a(i : i32) -> bool { |
| 2092 | return true; |
| 2093 | } |
| 2094 | |
| 2095 | fn f() { |
| 2096 | var b = true; |
| 2097 | var tint_symbol = a(0); |
| 2098 | if (tint_symbol) { |
| 2099 | tint_symbol = a(1); |
| 2100 | } |
| 2101 | let r = bitcast<u32>(i32(tint_symbol)); |
| 2102 | } |
| 2103 | )"; |
| 2104 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2105 | DataMap data; |
| 2106 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2107 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2108 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2109 | } |
| 2110 | |
| 2111 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InForLoopInit) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2112 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2113 | fn a(i : i32) -> bool { |
| 2114 | return true; |
| 2115 | } |
| 2116 | |
| 2117 | fn f() { |
| 2118 | var b = true; |
| 2119 | for(var r = a(0) && b; ; ) { |
| 2120 | var marker = 0; |
| 2121 | break; |
| 2122 | } |
| 2123 | } |
| 2124 | )"; |
| 2125 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2126 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2127 | fn a(i : i32) -> bool { |
| 2128 | return true; |
| 2129 | } |
| 2130 | |
| 2131 | fn f() { |
| 2132 | var b = true; |
| 2133 | var tint_symbol = a(0); |
| 2134 | if (tint_symbol) { |
| 2135 | tint_symbol = b; |
| 2136 | } |
| 2137 | for(var r = tint_symbol; ; ) { |
| 2138 | var marker = 0; |
| 2139 | break; |
| 2140 | } |
| 2141 | } |
| 2142 | )"; |
| 2143 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2144 | DataMap data; |
| 2145 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2146 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2147 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2148 | } |
| 2149 | |
| 2150 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InForLoopCond) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2151 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2152 | fn a(i : i32) -> bool { |
| 2153 | return true; |
| 2154 | } |
| 2155 | |
| 2156 | fn f() { |
| 2157 | var b = true; |
| 2158 | for(; a(0) && b;) { |
| 2159 | var marker = 0; |
| 2160 | } |
| 2161 | } |
| 2162 | )"; |
| 2163 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2164 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2165 | fn a(i : i32) -> bool { |
| 2166 | return true; |
| 2167 | } |
| 2168 | |
| 2169 | fn f() { |
| 2170 | var b = true; |
| 2171 | loop { |
| 2172 | var tint_symbol = a(0); |
| 2173 | if (tint_symbol) { |
| 2174 | tint_symbol = b; |
| 2175 | } |
| 2176 | if (!(tint_symbol)) { |
| 2177 | break; |
| 2178 | } |
| 2179 | { |
| 2180 | var marker = 0; |
| 2181 | } |
| 2182 | } |
| 2183 | } |
| 2184 | )"; |
| 2185 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2186 | DataMap data; |
| 2187 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2188 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2189 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2190 | } |
| 2191 | |
| 2192 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InForLoopCont) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2193 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2194 | fn a(i : i32) -> bool { |
| 2195 | return true; |
| 2196 | } |
| 2197 | |
| 2198 | fn f() { |
| 2199 | var b = true; |
| 2200 | var r = true; |
| 2201 | for(; ; r = a(0) && b) { |
| 2202 | var marker = 0; |
| 2203 | break; |
| 2204 | } |
| 2205 | } |
| 2206 | )"; |
| 2207 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2208 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2209 | fn a(i : i32) -> bool { |
| 2210 | return true; |
| 2211 | } |
| 2212 | |
| 2213 | fn f() { |
| 2214 | var b = true; |
| 2215 | var r = true; |
| 2216 | loop { |
| 2217 | { |
| 2218 | var marker = 0; |
| 2219 | break; |
| 2220 | } |
| 2221 | |
| 2222 | continuing { |
| 2223 | var tint_symbol = a(0); |
| 2224 | if (tint_symbol) { |
| 2225 | tint_symbol = b; |
| 2226 | } |
| 2227 | r = tint_symbol; |
| 2228 | } |
| 2229 | } |
| 2230 | } |
| 2231 | )"; |
| 2232 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2233 | DataMap data; |
| 2234 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2235 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2236 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2237 | } |
| 2238 | |
| 2239 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InForLoopInitCondCont) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2240 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2241 | fn a(i : i32) -> bool { |
| 2242 | return true; |
| 2243 | } |
| 2244 | |
| 2245 | fn f() { |
| 2246 | var b = true; |
| 2247 | var c = true; |
| 2248 | var d = true; |
| 2249 | var r = true; |
| 2250 | for(var r = a(0) && b; a(1) && c; r = a(2) && d) { |
| 2251 | var marker = 0; |
| 2252 | } |
| 2253 | } |
| 2254 | )"; |
| 2255 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2256 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2257 | fn a(i : i32) -> bool { |
| 2258 | return true; |
| 2259 | } |
| 2260 | |
| 2261 | fn f() { |
| 2262 | var b = true; |
| 2263 | var c = true; |
| 2264 | var d = true; |
| 2265 | var r = true; |
| 2266 | { |
| 2267 | var tint_symbol = a(0); |
| 2268 | if (tint_symbol) { |
| 2269 | tint_symbol = b; |
| 2270 | } |
| 2271 | var r = tint_symbol; |
| 2272 | loop { |
| 2273 | var tint_symbol_1 = a(1); |
| 2274 | if (tint_symbol_1) { |
| 2275 | tint_symbol_1 = c; |
| 2276 | } |
| 2277 | if (!(tint_symbol_1)) { |
| 2278 | break; |
| 2279 | } |
| 2280 | { |
| 2281 | var marker = 0; |
| 2282 | } |
| 2283 | |
| 2284 | continuing { |
| 2285 | var tint_symbol_2 = a(2); |
| 2286 | if (tint_symbol_2) { |
| 2287 | tint_symbol_2 = d; |
| 2288 | } |
| 2289 | r = tint_symbol_2; |
| 2290 | } |
| 2291 | } |
| 2292 | } |
| 2293 | } |
| 2294 | )"; |
| 2295 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2296 | DataMap data; |
| 2297 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2298 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2299 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2300 | } |
| 2301 | |
| 2302 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InElseIf) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2303 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2304 | fn a(i : i32) -> bool { |
| 2305 | return true; |
| 2306 | } |
| 2307 | |
| 2308 | fn f() { |
| 2309 | var b = true; |
| 2310 | if (true) { |
| 2311 | var marker = 0; |
| 2312 | } else if (a(0) && b) { |
| 2313 | var marker = 1; |
| 2314 | } |
| 2315 | } |
| 2316 | )"; |
| 2317 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2318 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2319 | fn a(i : i32) -> bool { |
| 2320 | return true; |
| 2321 | } |
| 2322 | |
| 2323 | fn f() { |
| 2324 | var b = true; |
| 2325 | if (true) { |
| 2326 | var marker = 0; |
| 2327 | } else { |
| 2328 | var tint_symbol = a(0); |
| 2329 | if (tint_symbol) { |
| 2330 | tint_symbol = b; |
| 2331 | } |
| 2332 | if (tint_symbol) { |
| 2333 | var marker = 1; |
| 2334 | } |
| 2335 | } |
| 2336 | } |
| 2337 | )"; |
| 2338 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2339 | DataMap data; |
| 2340 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2341 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2342 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2343 | } |
| 2344 | |
| 2345 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Logical_InElseIfChain) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2346 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2347 | fn a(i : i32) -> bool { |
| 2348 | return true; |
| 2349 | } |
| 2350 | |
| 2351 | fn f() { |
| 2352 | var b = true; |
| 2353 | if (true) { |
| 2354 | var marker = 0; |
| 2355 | } else if (true) { |
| 2356 | var marker = 1; |
| 2357 | } else if (a(0) && b) { |
| 2358 | var marker = 2; |
| 2359 | } else if (a(1) && a(2)) { |
| 2360 | var marker = 3; |
| 2361 | } else if (true) { |
| 2362 | var marker = 4; |
| 2363 | } else { |
| 2364 | var marker = 5; |
| 2365 | } |
| 2366 | } |
| 2367 | )"; |
| 2368 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2369 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2370 | fn a(i : i32) -> bool { |
| 2371 | return true; |
| 2372 | } |
| 2373 | |
| 2374 | fn f() { |
| 2375 | var b = true; |
| 2376 | if (true) { |
| 2377 | var marker = 0; |
| 2378 | } else if (true) { |
| 2379 | var marker = 1; |
| 2380 | } else { |
| 2381 | var tint_symbol = a(0); |
| 2382 | if (tint_symbol) { |
| 2383 | tint_symbol = b; |
| 2384 | } |
| 2385 | if (tint_symbol) { |
| 2386 | var marker = 2; |
| 2387 | } else { |
| 2388 | var tint_symbol_1 = a(1); |
| 2389 | if (tint_symbol_1) { |
| 2390 | tint_symbol_1 = a(2); |
| 2391 | } |
| 2392 | if (tint_symbol_1) { |
| 2393 | var marker = 3; |
| 2394 | } else if (true) { |
| 2395 | var marker = 4; |
| 2396 | } else { |
| 2397 | var marker = 5; |
| 2398 | } |
| 2399 | } |
| 2400 | } |
| 2401 | } |
| 2402 | )"; |
| 2403 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2404 | DataMap data; |
| 2405 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2406 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2407 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2408 | } |
| 2409 | |
| 2410 | TEST_F(PromoteSideEffectsToDeclTest, Call_NoSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2411 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2412 | fn a(i : i32) -> i32 { |
| 2413 | return 1; |
| 2414 | } |
| 2415 | |
| 2416 | fn g(a : i32, b : i32, c : i32) -> i32 { |
| 2417 | return 1; |
| 2418 | } |
| 2419 | |
| 2420 | fn f() { |
| 2421 | var b = 1; |
| 2422 | var c = 1; |
| 2423 | let r = g(b, c, 3); |
| 2424 | } |
| 2425 | )"; |
| 2426 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2427 | auto* expect = src; |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2428 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2429 | DataMap data; |
| 2430 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2431 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2432 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2433 | } |
| 2434 | |
| 2435 | TEST_F(PromoteSideEffectsToDeclTest, Call_OneSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2436 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2437 | fn a(i : i32) -> i32 { |
| 2438 | return 1; |
| 2439 | } |
| 2440 | |
| 2441 | fn g(a : i32, b : i32, c : i32) -> i32 { |
| 2442 | return 1; |
| 2443 | } |
| 2444 | |
| 2445 | fn f() { |
| 2446 | var b = 1; |
| 2447 | let r = g(a(0), b, 3); |
| 2448 | } |
| 2449 | )"; |
| 2450 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2451 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2452 | fn a(i : i32) -> i32 { |
| 2453 | return 1; |
| 2454 | } |
| 2455 | |
| 2456 | fn g(a : i32, b : i32, c : i32) -> i32 { |
| 2457 | return 1; |
| 2458 | } |
| 2459 | |
| 2460 | fn f() { |
| 2461 | var b = 1; |
| 2462 | let tint_symbol = a(0); |
| 2463 | let r = g(tint_symbol, b, 3); |
| 2464 | } |
| 2465 | )"; |
| 2466 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2467 | DataMap data; |
| 2468 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2469 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2470 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2471 | } |
| 2472 | |
| 2473 | TEST_F(PromoteSideEffectsToDeclTest, Call_AllSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2474 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2475 | fn a(i : i32) -> i32 { |
| 2476 | return 1; |
| 2477 | } |
| 2478 | |
| 2479 | fn g(a : i32, b : i32, c : i32) -> i32 { |
| 2480 | return 1; |
| 2481 | } |
| 2482 | |
| 2483 | fn f() { |
| 2484 | let r = g(a(0), a(1), a(2)); |
| 2485 | } |
| 2486 | )"; |
| 2487 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2488 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2489 | fn a(i : i32) -> i32 { |
| 2490 | return 1; |
| 2491 | } |
| 2492 | |
| 2493 | fn g(a : i32, b : i32, c : i32) -> i32 { |
| 2494 | return 1; |
| 2495 | } |
| 2496 | |
| 2497 | fn f() { |
| 2498 | let tint_symbol = a(0); |
| 2499 | let tint_symbol_1 = a(1); |
| 2500 | let tint_symbol_2 = a(2); |
| 2501 | let r = g(tint_symbol, tint_symbol_1, tint_symbol_2); |
| 2502 | } |
| 2503 | )"; |
| 2504 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2505 | DataMap data; |
| 2506 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2507 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2508 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2509 | } |
| 2510 | |
| 2511 | TEST_F(PromoteSideEffectsToDeclTest, Call_MiddleNotSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2512 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2513 | fn a(i : i32) -> i32 { |
| 2514 | return 1; |
| 2515 | } |
| 2516 | |
| 2517 | fn g(a : i32, b : i32, c : i32) -> i32 { |
| 2518 | return 1; |
| 2519 | } |
| 2520 | |
| 2521 | |
| 2522 | fn f() { |
| 2523 | var b = 1; |
| 2524 | let r = g(a(0), b, a(1)); |
| 2525 | } |
| 2526 | )"; |
| 2527 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2528 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2529 | fn a(i : i32) -> i32 { |
| 2530 | return 1; |
| 2531 | } |
| 2532 | |
| 2533 | fn g(a : i32, b : i32, c : i32) -> i32 { |
| 2534 | return 1; |
| 2535 | } |
| 2536 | |
| 2537 | fn f() { |
| 2538 | var b = 1; |
| 2539 | let tint_symbol = a(0); |
| 2540 | let tint_symbol_1 = b; |
| 2541 | let tint_symbol_2 = a(1); |
| 2542 | let r = g(tint_symbol, tint_symbol_1, tint_symbol_2); |
| 2543 | } |
| 2544 | )"; |
| 2545 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2546 | DataMap data; |
| 2547 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2548 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2549 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2550 | } |
| 2551 | |
| 2552 | TEST_F(PromoteSideEffectsToDeclTest, Call_InBinary) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2553 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2554 | fn a(i : i32) -> i32 { |
| 2555 | return 1; |
| 2556 | } |
| 2557 | |
| 2558 | fn g(i : i32, j : i32, k : i32) -> i32 { |
| 2559 | return 1; |
| 2560 | } |
| 2561 | |
| 2562 | fn f() { |
| 2563 | var b = 0; |
| 2564 | var c = 0; |
| 2565 | var d = 0; |
| 2566 | let r = b + g(c, a(0), d) + a(1); |
| 2567 | } |
| 2568 | )"; |
| 2569 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2570 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2571 | fn a(i : i32) -> i32 { |
| 2572 | return 1; |
| 2573 | } |
| 2574 | |
| 2575 | fn g(i : i32, j : i32, k : i32) -> i32 { |
| 2576 | return 1; |
| 2577 | } |
| 2578 | |
| 2579 | fn f() { |
| 2580 | var b = 0; |
| 2581 | var c = 0; |
| 2582 | var d = 0; |
| 2583 | let tint_symbol = b; |
| 2584 | let tint_symbol_1 = c; |
| 2585 | let tint_symbol_2 = a(0); |
| 2586 | let tint_symbol_3 = g(tint_symbol_1, tint_symbol_2, d); |
| 2587 | let tint_symbol_4 = a(1); |
| 2588 | let r = ((tint_symbol + tint_symbol_3) + tint_symbol_4); |
| 2589 | } |
| 2590 | )"; |
| 2591 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2592 | DataMap data; |
| 2593 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2594 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2595 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2596 | } |
| 2597 | |
| 2598 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor_2D_LeftSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2599 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2600 | fn a(i : i32) -> i32 { |
| 2601 | return 1; |
| 2602 | } |
| 2603 | |
| 2604 | fn f() { |
| 2605 | var b = array<array<i32, 10>, 10>(); |
| 2606 | var c = 1; |
| 2607 | var r = b[a(0)][c]; |
| 2608 | } |
| 2609 | )"; |
| 2610 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2611 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2612 | fn a(i : i32) -> i32 { |
| 2613 | return 1; |
| 2614 | } |
| 2615 | |
| 2616 | fn f() { |
| 2617 | var b = array<array<i32, 10>, 10>(); |
| 2618 | var c = 1; |
| 2619 | let tint_symbol = a(0); |
| 2620 | var r = b[tint_symbol][c]; |
| 2621 | } |
| 2622 | )"; |
| 2623 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2624 | DataMap data; |
| 2625 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2626 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2627 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2628 | } |
| 2629 | |
| 2630 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor_2D_RightSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2631 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2632 | fn a(i : i32) -> i32 { |
| 2633 | return 1; |
| 2634 | } |
| 2635 | |
| 2636 | fn f() { |
| 2637 | var b = array<array<i32, 10>, 10>(); |
| 2638 | var c = 1; |
| 2639 | let tint_symbol = c; |
| 2640 | let tint_symbol_1 = a(0); |
| 2641 | var r = b[tint_symbol][tint_symbol_1]; |
| 2642 | } |
| 2643 | )"; |
| 2644 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2645 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2646 | fn a(i : i32) -> i32 { |
| 2647 | return 1; |
| 2648 | } |
| 2649 | |
| 2650 | fn f() { |
| 2651 | var b = array<array<i32, 10>, 10>(); |
| 2652 | var c = 1; |
| 2653 | let tint_symbol = c; |
| 2654 | let tint_symbol_1 = a(0); |
| 2655 | var r = b[tint_symbol][tint_symbol_1]; |
| 2656 | } |
| 2657 | )"; |
| 2658 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2659 | DataMap data; |
| 2660 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2661 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2662 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2663 | } |
| 2664 | |
| 2665 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor_2D_BothSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2666 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2667 | fn a(i : i32) -> i32 { |
| 2668 | return 1; |
| 2669 | } |
| 2670 | |
| 2671 | fn f() { |
| 2672 | var b = array<array<i32, 10>, 10>(); |
| 2673 | var r = b[a(0)][a(1)]; |
| 2674 | } |
| 2675 | )"; |
| 2676 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2677 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2678 | fn a(i : i32) -> i32 { |
| 2679 | return 1; |
| 2680 | } |
| 2681 | |
| 2682 | fn f() { |
| 2683 | var b = array<array<i32, 10>, 10>(); |
| 2684 | let tint_symbol = a(0); |
| 2685 | let tint_symbol_1 = a(1); |
| 2686 | var r = b[tint_symbol][tint_symbol_1]; |
| 2687 | } |
| 2688 | )"; |
| 2689 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2690 | DataMap data; |
| 2691 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2692 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2693 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2694 | } |
| 2695 | |
| 2696 | TEST_F(PromoteSideEffectsToDeclTest, Assignment_ToPhony) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2697 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2698 | fn a(i : i32) -> i32 { |
| 2699 | return 1; |
| 2700 | } |
| 2701 | |
| 2702 | fn f() { |
| 2703 | _ = a(0); |
| 2704 | } |
| 2705 | )"; |
| 2706 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2707 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2708 | fn a(i : i32) -> i32 { |
| 2709 | return 1; |
| 2710 | } |
| 2711 | |
| 2712 | fn f() { |
| 2713 | _ = a(0); |
| 2714 | } |
| 2715 | )"; |
| 2716 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2717 | DataMap data; |
| 2718 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2719 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2720 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2721 | } |
| 2722 | |
| 2723 | TEST_F(PromoteSideEffectsToDeclTest, Assignment_ToArray1D) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2724 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2725 | fn a(i : i32) -> i32 { |
| 2726 | return 1; |
| 2727 | } |
| 2728 | |
| 2729 | fn f() { |
| 2730 | var b = array<i32, 10>(); |
| 2731 | b[a(0)] = a(1); |
| 2732 | } |
| 2733 | )"; |
| 2734 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2735 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2736 | fn a(i : i32) -> i32 { |
| 2737 | return 1; |
| 2738 | } |
| 2739 | |
| 2740 | fn f() { |
| 2741 | var b = array<i32, 10>(); |
| 2742 | let tint_symbol = a(1); |
| 2743 | let tint_symbol_1 = a(0); |
| 2744 | b[tint_symbol_1] = tint_symbol; |
| 2745 | } |
| 2746 | )"; |
| 2747 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2748 | DataMap data; |
| 2749 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2750 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2751 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2752 | } |
| 2753 | |
| 2754 | TEST_F(PromoteSideEffectsToDeclTest, Assignment_ToArray2D) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2755 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2756 | fn a(i : i32) -> i32 { |
| 2757 | return 1; |
| 2758 | } |
| 2759 | |
| 2760 | fn f() { |
| 2761 | var b = array<array<i32, 10>, 10>(); |
| 2762 | b[a(0)][a(1)] = a(2); |
| 2763 | } |
| 2764 | )"; |
| 2765 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2766 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2767 | fn a(i : i32) -> i32 { |
| 2768 | return 1; |
| 2769 | } |
| 2770 | |
| 2771 | fn f() { |
| 2772 | var b = array<array<i32, 10>, 10>(); |
| 2773 | let tint_symbol = a(2); |
| 2774 | let tint_symbol_1 = a(0); |
| 2775 | let tint_symbol_2 = a(1); |
| 2776 | b[tint_symbol_1][tint_symbol_2] = tint_symbol; |
| 2777 | } |
| 2778 | )"; |
| 2779 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2780 | DataMap data; |
| 2781 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2782 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2783 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2784 | } |
| 2785 | |
| 2786 | TEST_F(PromoteSideEffectsToDeclTest, Assignment_ToArray3D) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2787 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2788 | fn a(i : i32) -> i32 { |
| 2789 | return 1; |
| 2790 | } |
| 2791 | |
| 2792 | fn f() { |
| 2793 | var b = array<array<array<i32, 10>, 10>, 10>(); |
| 2794 | b[a(0)][a(1)][a(2)] = a(3); |
| 2795 | } |
| 2796 | )"; |
| 2797 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2798 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2799 | fn a(i : i32) -> i32 { |
| 2800 | return 1; |
| 2801 | } |
| 2802 | |
| 2803 | fn f() { |
| 2804 | var b = array<array<array<i32, 10>, 10>, 10>(); |
| 2805 | let tint_symbol = a(3); |
| 2806 | let tint_symbol_1 = a(0); |
| 2807 | let tint_symbol_2 = a(1); |
| 2808 | let tint_symbol_3 = a(2); |
| 2809 | b[tint_symbol_1][tint_symbol_2][tint_symbol_3] = tint_symbol; |
| 2810 | } |
| 2811 | )"; |
| 2812 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2813 | DataMap data; |
| 2814 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2815 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2816 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2817 | } |
| 2818 | |
| 2819 | TEST_F(PromoteSideEffectsToDeclTest, Assignment_ToArray_FromArray) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2820 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2821 | fn a(i : i32) -> i32 { |
| 2822 | return 1; |
| 2823 | } |
| 2824 | |
| 2825 | fn f() { |
| 2826 | var b = array<i32, 3>(); |
| 2827 | var d = array<array<i32, 3>, 3>(); |
| 2828 | var a_1 = 0; |
| 2829 | b[a(2)] = d[a(0)][a_1]; |
| 2830 | } |
| 2831 | )"; |
| 2832 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2833 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2834 | fn a(i : i32) -> i32 { |
| 2835 | return 1; |
| 2836 | } |
| 2837 | |
| 2838 | fn f() { |
| 2839 | var b = array<i32, 3>(); |
| 2840 | var d = array<array<i32, 3>, 3>(); |
| 2841 | var a_1 = 0; |
| 2842 | let tint_symbol = a(0); |
| 2843 | let tint_symbol_1 = a_1; |
| 2844 | let tint_symbol_2 = d[tint_symbol][tint_symbol_1]; |
| 2845 | let tint_symbol_3 = a(2); |
| 2846 | b[tint_symbol_3] = tint_symbol_2; |
| 2847 | } |
| 2848 | )"; |
| 2849 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2850 | DataMap data; |
| 2851 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2852 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2853 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2854 | } |
| 2855 | |
| 2856 | TEST_F(PromoteSideEffectsToDeclTest, Assignment_ToVec_BothSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2857 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2858 | fn a(i : i32) -> i32 { |
| 2859 | return 1; |
| 2860 | } |
| 2861 | |
| 2862 | fn f() { |
| 2863 | var b = vec3<i32>(); |
| 2864 | b[a(0)] = a(1); |
| 2865 | } |
| 2866 | )"; |
| 2867 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2868 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2869 | fn a(i : i32) -> i32 { |
| 2870 | return 1; |
| 2871 | } |
| 2872 | |
| 2873 | fn f() { |
| 2874 | var b = vec3<i32>(); |
| 2875 | let tint_symbol = a(1); |
| 2876 | let tint_symbol_1 = a(0); |
| 2877 | b[tint_symbol_1] = tint_symbol; |
| 2878 | } |
| 2879 | )"; |
| 2880 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2881 | DataMap data; |
| 2882 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2883 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2884 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2885 | } |
| 2886 | |
| 2887 | TEST_F(PromoteSideEffectsToDeclTest, Assignment_ToVec_LeftSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2888 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2889 | fn a(i : i32) -> i32 { |
| 2890 | return 1; |
| 2891 | } |
| 2892 | |
| 2893 | fn f() { |
| 2894 | var b = vec3<i32>(); |
| 2895 | var c = 0; |
| 2896 | b[a(0)] = c; |
| 2897 | } |
| 2898 | )"; |
| 2899 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2900 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2901 | fn a(i : i32) -> i32 { |
| 2902 | return 1; |
| 2903 | } |
| 2904 | |
| 2905 | fn f() { |
| 2906 | var b = vec3<i32>(); |
| 2907 | var c = 0; |
| 2908 | let tint_symbol = c; |
| 2909 | let tint_symbol_1 = a(0); |
| 2910 | b[tint_symbol_1] = tint_symbol; |
| 2911 | } |
| 2912 | )"; |
| 2913 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2914 | DataMap data; |
| 2915 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2916 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2917 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2918 | } |
| 2919 | |
| 2920 | TEST_F(PromoteSideEffectsToDeclTest, Assignment_ToVec_RightSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2921 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2922 | fn a(i : i32) -> i32 { |
| 2923 | return 1; |
| 2924 | } |
| 2925 | |
| 2926 | fn f() { |
| 2927 | var b = vec3<i32>(); |
| 2928 | var c = 0; |
| 2929 | b[c] = a(0); |
| 2930 | } |
| 2931 | )"; |
| 2932 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2933 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2934 | fn a(i : i32) -> i32 { |
| 2935 | return 1; |
| 2936 | } |
| 2937 | |
| 2938 | fn f() { |
| 2939 | var b = vec3<i32>(); |
| 2940 | var c = 0; |
| 2941 | let tint_symbol = a(0); |
| 2942 | b[c] = tint_symbol; |
| 2943 | } |
| 2944 | )"; |
| 2945 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2946 | DataMap data; |
| 2947 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2948 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2949 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2950 | } |
| 2951 | |
| 2952 | TEST_F(PromoteSideEffectsToDeclTest, TypeConstructor_Struct) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2953 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2954 | fn a(i : i32) -> i32 { |
| 2955 | return 1; |
| 2956 | } |
| 2957 | |
| 2958 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 2959 | x : i32, |
| 2960 | y : i32, |
| 2961 | z : i32, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2962 | } |
| 2963 | |
| 2964 | fn f() { |
| 2965 | var r = S(a(0), a(1), a(2)); |
| 2966 | } |
| 2967 | )"; |
| 2968 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2969 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2970 | fn a(i : i32) -> i32 { |
| 2971 | return 1; |
| 2972 | } |
| 2973 | |
| 2974 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 2975 | x : i32, |
| 2976 | y : i32, |
| 2977 | z : i32, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2978 | } |
| 2979 | |
| 2980 | fn f() { |
| 2981 | let tint_symbol = a(0); |
| 2982 | let tint_symbol_1 = a(1); |
| 2983 | let tint_symbol_2 = a(2); |
| 2984 | var r = S(tint_symbol, tint_symbol_1, tint_symbol_2); |
| 2985 | } |
| 2986 | )"; |
| 2987 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2988 | DataMap data; |
| 2989 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2990 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2991 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2992 | } |
| 2993 | |
| 2994 | TEST_F(PromoteSideEffectsToDeclTest, TypeConstructor_Array1D) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 2995 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 2996 | fn a(i : i32) -> i32 { |
| 2997 | return 1; |
| 2998 | } |
| 2999 | |
| 3000 | fn f() { |
| 3001 | var r = array<i32, 3>(a(0), a(1), a(2)); |
| 3002 | } |
| 3003 | )"; |
| 3004 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3005 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3006 | fn a(i : i32) -> i32 { |
| 3007 | return 1; |
| 3008 | } |
| 3009 | |
| 3010 | fn f() { |
| 3011 | let tint_symbol = a(0); |
| 3012 | let tint_symbol_1 = a(1); |
| 3013 | let tint_symbol_2 = a(2); |
| 3014 | var r = array<i32, 3>(tint_symbol, tint_symbol_1, tint_symbol_2); |
| 3015 | } |
| 3016 | )"; |
| 3017 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3018 | DataMap data; |
| 3019 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3020 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3021 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3022 | } |
| 3023 | |
| 3024 | TEST_F(PromoteSideEffectsToDeclTest, TypeConstructor_Array2D) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3025 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3026 | fn a(i : i32) -> i32 { |
| 3027 | return 1; |
| 3028 | } |
| 3029 | |
| 3030 | fn f() { |
| 3031 | var r = array<array<i32, 2>, 2>(array<i32, 2>(a(0), a(1)), array<i32, 2>(a(2), a(3))); |
| 3032 | } |
| 3033 | )"; |
| 3034 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3035 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3036 | fn a(i : i32) -> i32 { |
| 3037 | return 1; |
| 3038 | } |
| 3039 | |
| 3040 | fn f() { |
| 3041 | let tint_symbol = a(0); |
| 3042 | let tint_symbol_1 = a(1); |
| 3043 | let tint_symbol_2 = array<i32, 2>(tint_symbol, tint_symbol_1); |
| 3044 | let tint_symbol_3 = a(2); |
| 3045 | let tint_symbol_4 = a(3); |
| 3046 | let tint_symbol_5 = array<i32, 2>(tint_symbol_3, tint_symbol_4); |
| 3047 | var r = array<array<i32, 2>, 2>(tint_symbol_2, tint_symbol_5); |
| 3048 | } |
| 3049 | )"; |
| 3050 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3051 | DataMap data; |
| 3052 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3053 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3054 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3055 | } |
| 3056 | |
| 3057 | TEST_F(PromoteSideEffectsToDeclTest, MemberAccessor_Vec) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3058 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3059 | fn a(i : i32) -> vec3<i32> { |
| 3060 | return vec3<i32>(); |
| 3061 | } |
| 3062 | |
| 3063 | fn f() { |
| 3064 | var r = a(0).x + a(1).y; |
| 3065 | } |
| 3066 | )"; |
| 3067 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3068 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3069 | fn a(i : i32) -> vec3<i32> { |
| 3070 | return vec3<i32>(); |
| 3071 | } |
| 3072 | |
| 3073 | fn f() { |
| 3074 | let tint_symbol = a(0); |
| 3075 | let tint_symbol_1 = a(1); |
| 3076 | var r = (tint_symbol.x + tint_symbol_1.y); |
| 3077 | } |
| 3078 | )"; |
| 3079 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3080 | DataMap data; |
| 3081 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3082 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3083 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3084 | } |
| 3085 | |
| 3086 | TEST_F(PromoteSideEffectsToDeclTest, MemberAccessor_Struct) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3087 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3088 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 3089 | x : i32, |
| 3090 | y : i32, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3091 | } |
| 3092 | |
| 3093 | fn a(i : i32) -> S { |
| 3094 | return S(); |
| 3095 | } |
| 3096 | |
| 3097 | fn f() { |
| 3098 | var r = a(0).x + a(1).y; |
| 3099 | } |
| 3100 | )"; |
| 3101 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3102 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3103 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 3104 | x : i32, |
| 3105 | y : i32, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3106 | } |
| 3107 | |
| 3108 | fn a(i : i32) -> S { |
| 3109 | return S(); |
| 3110 | } |
| 3111 | |
| 3112 | fn f() { |
| 3113 | let tint_symbol = a(0); |
| 3114 | let tint_symbol_1 = a(1); |
| 3115 | var r = (tint_symbol.x + tint_symbol_1.y); |
| 3116 | } |
| 3117 | )"; |
| 3118 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3119 | DataMap data; |
| 3120 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3121 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3122 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3123 | } |
| 3124 | |
| 3125 | TEST_F(PromoteSideEffectsToDeclTest, MemberAccessor_Struct_Mixed) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3126 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3127 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 3128 | x : i32, |
| 3129 | y : i32, |
| 3130 | arr : array<i32, 10>, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3131 | } |
| 3132 | |
| 3133 | fn a(i : i32) -> S { |
| 3134 | return S(); |
| 3135 | } |
| 3136 | |
| 3137 | fn b(i : i32) -> i32 { |
| 3138 | return 0; |
| 3139 | } |
| 3140 | |
| 3141 | fn f() { |
| 3142 | var i = 0; |
| 3143 | var j = 0; |
| 3144 | var k = 0; |
| 3145 | var l = 0; |
| 3146 | var m = 0; |
| 3147 | var r = a(0).x + i + a(1).y + j + a(2).arr[k + b(3) + l] + m; |
| 3148 | } |
| 3149 | )"; |
| 3150 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3151 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3152 | struct S { |
James Price | 3b671cb | 2022-03-28 14:31:22 +0000 | [diff] [blame] | 3153 | x : i32, |
| 3154 | y : i32, |
| 3155 | arr : array<i32, 10>, |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3156 | } |
| 3157 | |
| 3158 | fn a(i : i32) -> S { |
| 3159 | return S(); |
| 3160 | } |
| 3161 | |
| 3162 | fn b(i : i32) -> i32 { |
| 3163 | return 0; |
| 3164 | } |
| 3165 | |
| 3166 | fn f() { |
| 3167 | var i = 0; |
| 3168 | var j = 0; |
| 3169 | var k = 0; |
| 3170 | var l = 0; |
| 3171 | var m = 0; |
| 3172 | let tint_symbol = a(0); |
| 3173 | let tint_symbol_1 = i; |
| 3174 | let tint_symbol_2 = a(1); |
| 3175 | let tint_symbol_3 = j; |
| 3176 | let tint_symbol_4 = a(2); |
| 3177 | let tint_symbol_5 = k; |
| 3178 | let tint_symbol_6 = b(3); |
| 3179 | var r = (((((tint_symbol.x + tint_symbol_1) + tint_symbol_2.y) + tint_symbol_3) + tint_symbol_4.arr[((tint_symbol_5 + tint_symbol_6) + l)]) + m); |
| 3180 | } |
| 3181 | )"; |
| 3182 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3183 | DataMap data; |
| 3184 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3185 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3186 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3187 | } |
| 3188 | |
| 3189 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor_Plus_SE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3190 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3191 | fn a(i : i32) -> i32 { |
| 3192 | return i; |
| 3193 | } |
| 3194 | |
| 3195 | fn f() { |
| 3196 | var v = array<i32, 10>(); |
| 3197 | let r = v[0] + a(0); |
| 3198 | } |
| 3199 | )"; |
| 3200 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3201 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3202 | fn a(i : i32) -> i32 { |
| 3203 | return i; |
| 3204 | } |
| 3205 | |
| 3206 | fn f() { |
| 3207 | var v = array<i32, 10>(); |
| 3208 | let tint_symbol = v[0]; |
| 3209 | let tint_symbol_1 = a(0); |
| 3210 | let r = (tint_symbol + tint_symbol_1); |
| 3211 | } |
| 3212 | )"; |
| 3213 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3214 | DataMap data; |
| 3215 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3216 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3217 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3218 | } |
| 3219 | |
| 3220 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor_Of_SE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3221 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3222 | fn a(i : i32) -> i32 { |
| 3223 | return i; |
| 3224 | } |
| 3225 | |
| 3226 | fn f() { |
| 3227 | var v = array<i32, 10>(); |
| 3228 | let r = v[a(0)]; |
| 3229 | } |
| 3230 | )"; |
| 3231 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3232 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3233 | fn a(i : i32) -> i32 { |
| 3234 | return i; |
| 3235 | } |
| 3236 | |
| 3237 | fn f() { |
| 3238 | var v = array<i32, 10>(); |
| 3239 | let tint_symbol = a(0); |
| 3240 | let r = v[tint_symbol]; |
| 3241 | } |
| 3242 | )"; |
| 3243 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3244 | DataMap data; |
| 3245 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3246 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3247 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3248 | } |
| 3249 | |
| 3250 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor2_Of_LeftSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3251 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3252 | fn a(i : i32) -> i32 { |
| 3253 | return i; |
| 3254 | } |
| 3255 | |
| 3256 | fn f() { |
| 3257 | var v = array<array<i32, 10>, 10>(); |
| 3258 | let r = v[a(0)][0]; |
| 3259 | } |
| 3260 | )"; |
| 3261 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3262 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3263 | fn a(i : i32) -> i32 { |
| 3264 | return i; |
| 3265 | } |
| 3266 | |
| 3267 | fn f() { |
| 3268 | var v = array<array<i32, 10>, 10>(); |
| 3269 | let tint_symbol = a(0); |
| 3270 | let r = v[tint_symbol][0]; |
| 3271 | } |
| 3272 | )"; |
| 3273 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3274 | DataMap data; |
| 3275 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3276 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3277 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3278 | } |
| 3279 | |
| 3280 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor2_Of_RightSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3281 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3282 | fn a(i : i32) -> i32 { |
| 3283 | return i; |
| 3284 | } |
| 3285 | |
| 3286 | fn f() { |
| 3287 | var v = array<array<i32, 10>, 10>(); |
| 3288 | let r = v[0][a(0)]; |
| 3289 | } |
| 3290 | )"; |
| 3291 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3292 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3293 | fn a(i : i32) -> i32 { |
| 3294 | return i; |
| 3295 | } |
| 3296 | |
| 3297 | fn f() { |
| 3298 | var v = array<array<i32, 10>, 10>(); |
| 3299 | let tint_symbol = a(0); |
| 3300 | let r = v[0][tint_symbol]; |
| 3301 | } |
| 3302 | )"; |
| 3303 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3304 | DataMap data; |
| 3305 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3306 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3307 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3308 | } |
| 3309 | |
| 3310 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor2_Of_SEAndVar) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3311 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3312 | fn a(i : i32) -> i32 { |
| 3313 | return i; |
| 3314 | } |
| 3315 | |
| 3316 | fn f() { |
| 3317 | var v = array<array<i32, 10>, 10>(); |
| 3318 | var b : i32; |
| 3319 | let r = v[a(0)][b]; |
| 3320 | } |
| 3321 | )"; |
| 3322 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3323 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3324 | fn a(i : i32) -> i32 { |
| 3325 | return i; |
| 3326 | } |
| 3327 | |
| 3328 | fn f() { |
| 3329 | var v = array<array<i32, 10>, 10>(); |
| 3330 | var b : i32; |
| 3331 | let tint_symbol = a(0); |
| 3332 | let r = v[tint_symbol][b]; |
| 3333 | } |
| 3334 | )"; |
| 3335 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3336 | DataMap data; |
| 3337 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3338 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3339 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3340 | } |
| 3341 | |
| 3342 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor2_Of_VarAndSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3343 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3344 | fn a(i : i32) -> i32 { |
| 3345 | return i; |
| 3346 | } |
| 3347 | |
| 3348 | fn f() { |
| 3349 | var v = array<array<i32, 10>, 10>(); |
| 3350 | var b : i32; |
| 3351 | let r = v[b][a(0)]; |
| 3352 | } |
| 3353 | )"; |
| 3354 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3355 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3356 | fn a(i : i32) -> i32 { |
| 3357 | return i; |
| 3358 | } |
| 3359 | |
| 3360 | fn f() { |
| 3361 | var v = array<array<i32, 10>, 10>(); |
| 3362 | var b : i32; |
| 3363 | let tint_symbol = b; |
| 3364 | let tint_symbol_1 = a(0); |
| 3365 | let r = v[tint_symbol][tint_symbol_1]; |
| 3366 | } |
| 3367 | )"; |
| 3368 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3369 | DataMap data; |
| 3370 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3371 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3372 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3373 | } |
| 3374 | |
| 3375 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessorOfVar_Plus_SE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3376 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3377 | fn a(i : i32) -> i32 { |
| 3378 | return i; |
| 3379 | } |
| 3380 | |
| 3381 | fn f() { |
| 3382 | var v = array<i32, 10>(); |
| 3383 | var b = 0; |
| 3384 | let r = v[b] + a(0); |
| 3385 | } |
| 3386 | )"; |
| 3387 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3388 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3389 | fn a(i : i32) -> i32 { |
| 3390 | return i; |
| 3391 | } |
| 3392 | |
| 3393 | fn f() { |
| 3394 | var v = array<i32, 10>(); |
| 3395 | var b = 0; |
| 3396 | let tint_symbol = b; |
| 3397 | let tint_symbol_1 = v[tint_symbol]; |
| 3398 | let tint_symbol_2 = a(0); |
| 3399 | let r = (tint_symbol_1 + tint_symbol_2); |
| 3400 | } |
| 3401 | )"; |
| 3402 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3403 | DataMap data; |
| 3404 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3405 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3406 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3407 | } |
| 3408 | |
| 3409 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessor_Plus_IndexAccessorOfSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3410 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3411 | fn a(i : i32) -> i32 { |
| 3412 | return i; |
| 3413 | } |
| 3414 | |
| 3415 | fn f() { |
| 3416 | var v = array<i32, 10>(); |
| 3417 | let r = v[0] + v[a(0)]; |
| 3418 | } |
| 3419 | )"; |
| 3420 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3421 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3422 | fn a(i : i32) -> i32 { |
| 3423 | return i; |
| 3424 | } |
| 3425 | |
| 3426 | fn f() { |
| 3427 | var v = array<i32, 10>(); |
| 3428 | let tint_symbol = v[0]; |
| 3429 | let tint_symbol_1 = a(0); |
| 3430 | let r = (tint_symbol + v[tint_symbol_1]); |
| 3431 | } |
| 3432 | )"; |
| 3433 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3434 | DataMap data; |
| 3435 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3436 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3437 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3438 | } |
| 3439 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3440 | TEST_F(PromoteSideEffectsToDeclTest, AssignTo_IndexAccessorOfIndexAccessorOfSE) { |
| 3441 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3442 | fn a(i : i32) -> i32 { |
| 3443 | return i; |
| 3444 | } |
| 3445 | |
| 3446 | fn f() { |
| 3447 | var v = array<i32, 10>(); |
| 3448 | var w = array<i32, 10>(); |
| 3449 | v[w[a(0)]] = 1; |
| 3450 | } |
| 3451 | )"; |
| 3452 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3453 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3454 | fn a(i : i32) -> i32 { |
| 3455 | return i; |
| 3456 | } |
| 3457 | |
| 3458 | fn f() { |
| 3459 | var v = array<i32, 10>(); |
| 3460 | var w = array<i32, 10>(); |
| 3461 | let tint_symbol = a(0); |
| 3462 | v[w[tint_symbol]] = 1; |
| 3463 | } |
| 3464 | )"; |
| 3465 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3466 | DataMap data; |
| 3467 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3468 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3469 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3470 | } |
| 3471 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3472 | TEST_F(PromoteSideEffectsToDeclTest, AssignTo_IndexAccessorOfIndexAccessorOfLiteralPlusSE) { |
| 3473 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3474 | fn a(i : i32) -> i32 { |
| 3475 | return i; |
| 3476 | } |
| 3477 | |
| 3478 | fn f() { |
| 3479 | var v = array<i32, 10>(); |
| 3480 | var w = array<i32, 10>(); |
| 3481 | v[w[0] + a(0)] = 1; |
| 3482 | } |
| 3483 | )"; |
| 3484 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3485 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3486 | fn a(i : i32) -> i32 { |
| 3487 | return i; |
| 3488 | } |
| 3489 | |
| 3490 | fn f() { |
| 3491 | var v = array<i32, 10>(); |
| 3492 | var w = array<i32, 10>(); |
| 3493 | let tint_symbol = w[0]; |
| 3494 | let tint_symbol_1 = a(0); |
| 3495 | v[(tint_symbol + tint_symbol_1)] = 1; |
| 3496 | } |
| 3497 | )"; |
| 3498 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3499 | DataMap data; |
| 3500 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3501 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3502 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3503 | } |
| 3504 | |
| 3505 | TEST_F(PromoteSideEffectsToDeclTest, |
| 3506 | AssignTo_IndexAccessorOfIndexAccessorOfLiteralPlusIndexAccessorOfSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3507 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3508 | fn a(i : i32) -> i32 { |
| 3509 | return i; |
| 3510 | } |
| 3511 | |
| 3512 | fn f() { |
| 3513 | var v = array<i32, 10>(); |
| 3514 | var w = array<i32, 10>(); |
| 3515 | v[w[0] + w[a(0)]] = 1; |
| 3516 | } |
| 3517 | )"; |
| 3518 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3519 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3520 | fn a(i : i32) -> i32 { |
| 3521 | return i; |
| 3522 | } |
| 3523 | |
| 3524 | fn f() { |
| 3525 | var v = array<i32, 10>(); |
| 3526 | var w = array<i32, 10>(); |
| 3527 | let tint_symbol = w[0]; |
| 3528 | let tint_symbol_1 = a(0); |
| 3529 | v[(tint_symbol + w[tint_symbol_1])] = 1; |
| 3530 | } |
| 3531 | )"; |
| 3532 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3533 | DataMap data; |
| 3534 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3535 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3536 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3537 | } |
| 3538 | |
| 3539 | TEST_F(PromoteSideEffectsToDeclTest, IndexAccessorOfLhsSERhsSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3540 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3541 | fn a(i : i32) -> i32 { |
| 3542 | return i; |
| 3543 | } |
| 3544 | |
| 3545 | fn b() -> array<i32, 10> { |
| 3546 | return array<i32, 10>(); |
| 3547 | } |
| 3548 | |
| 3549 | fn f() { |
| 3550 | let r = b()[a(0)]; |
| 3551 | } |
| 3552 | )"; |
| 3553 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3554 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3555 | fn a(i : i32) -> i32 { |
| 3556 | return i; |
| 3557 | } |
| 3558 | |
| 3559 | fn b() -> array<i32, 10> { |
| 3560 | return array<i32, 10>(); |
| 3561 | } |
| 3562 | |
| 3563 | fn f() { |
| 3564 | let tint_symbol = b(); |
| 3565 | let tint_symbol_1 = a(0); |
| 3566 | let r = tint_symbol[tint_symbol_1]; |
| 3567 | } |
| 3568 | )"; |
| 3569 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3570 | DataMap data; |
| 3571 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3572 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3573 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3574 | } |
| 3575 | |
| 3576 | TEST_F(PromoteSideEffectsToDeclTest, BinaryIndexAccessorOfLhsSERhsSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3577 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3578 | fn a(i : i32) -> i32 { |
| 3579 | return i; |
| 3580 | } |
| 3581 | |
| 3582 | fn b() -> array<i32, 10> { |
| 3583 | return array<i32, 10>(); |
| 3584 | } |
| 3585 | |
| 3586 | fn f() { |
| 3587 | let r = b()[0] + a(0); |
| 3588 | } |
| 3589 | )"; |
| 3590 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3591 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3592 | fn a(i : i32) -> i32 { |
| 3593 | return i; |
| 3594 | } |
| 3595 | |
| 3596 | fn b() -> array<i32, 10> { |
| 3597 | return array<i32, 10>(); |
| 3598 | } |
| 3599 | |
| 3600 | fn f() { |
| 3601 | let tint_symbol = b(); |
| 3602 | let tint_symbol_1 = a(0); |
| 3603 | let r = (tint_symbol[0] + tint_symbol_1); |
| 3604 | } |
| 3605 | )"; |
| 3606 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3607 | DataMap data; |
| 3608 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3609 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3610 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3611 | } |
| 3612 | |
| 3613 | TEST_F(PromoteSideEffectsToDeclTest, BinaryMemberAccessorPlusSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3614 | // bclayton@'s example: |
| 3615 | // https://dawn-review.googlesource.com/c/tint/+/78620/6..8/src/transform/promote_side_effects_to_decl.cc#b490 |
| 3616 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3617 | fn modify_vec(p : ptr<function, vec4<i32>>) -> i32 { |
| 3618 | (*p).x = 42; |
| 3619 | return 0; |
| 3620 | } |
| 3621 | |
| 3622 | fn f() { |
| 3623 | var v = vec4<i32>(); |
| 3624 | let l = v.x + modify_vec(&v); |
| 3625 | // l should be 0, not 42 |
| 3626 | } |
| 3627 | )"; |
| 3628 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3629 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3630 | fn modify_vec(p : ptr<function, vec4<i32>>) -> i32 { |
| 3631 | (*(p)).x = 42; |
| 3632 | return 0; |
| 3633 | } |
| 3634 | |
| 3635 | fn f() { |
| 3636 | var v = vec4<i32>(); |
| 3637 | let tint_symbol = v.x; |
| 3638 | let tint_symbol_1 = modify_vec(&(v)); |
| 3639 | let l = (tint_symbol + tint_symbol_1); |
| 3640 | } |
| 3641 | )"; |
| 3642 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3643 | DataMap data; |
| 3644 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3645 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3646 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3647 | } |
| 3648 | |
| 3649 | TEST_F(PromoteSideEffectsToDeclTest, Call_ReadOnlyArgAndSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3650 | // Make sure that read-only args don't get hoisted (tex and samp) |
| 3651 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3652 | @group(1) @binding(1) var tex: texture_2d_array<u32>; |
| 3653 | @group(1) @binding(2) var samp: sampler; |
| 3654 | |
| 3655 | fn get_uv() -> vec2<f32> { |
| 3656 | return vec2<f32>(1.0, 2.0); |
| 3657 | } |
| 3658 | |
| 3659 | fn f() { |
| 3660 | let r = textureGather(1, tex, samp, get_uv(), 1); |
| 3661 | } |
| 3662 | )"; |
| 3663 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3664 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3665 | @group(1) @binding(1) var tex : texture_2d_array<u32>; |
| 3666 | |
| 3667 | @group(1) @binding(2) var samp : sampler; |
| 3668 | |
| 3669 | fn get_uv() -> vec2<f32> { |
| 3670 | return vec2<f32>(1.0, 2.0); |
| 3671 | } |
| 3672 | |
| 3673 | fn f() { |
| 3674 | let tint_symbol = get_uv(); |
| 3675 | let r = textureGather(1, tex, samp, tint_symbol, 1); |
| 3676 | } |
| 3677 | )"; |
| 3678 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3679 | DataMap data; |
| 3680 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3681 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3682 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3683 | } |
| 3684 | |
| 3685 | TEST_F(PromoteSideEffectsToDeclTest, Call_PtrArgAndSE) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3686 | // Make sure that read-only args don't get hoisted (tex and samp) |
| 3687 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3688 | |
| 3689 | var<private> b : i32 = 0; |
| 3690 | |
| 3691 | fn a(i : i32) -> i32 { |
| 3692 | b = 42; |
| 3693 | return 0; |
| 3694 | } |
| 3695 | |
| 3696 | fn g(i : ptr<private, i32>, j : i32) -> i32 { |
| 3697 | return *i; |
| 3698 | } |
| 3699 | |
| 3700 | fn f() { |
| 3701 | // a(0) should be hoisted, but not &b |
| 3702 | let r = g(&b, a(0)); |
| 3703 | // r should be 42 |
| 3704 | } |
| 3705 | )"; |
| 3706 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3707 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3708 | var<private> b : i32 = 0; |
| 3709 | |
| 3710 | fn a(i : i32) -> i32 { |
| 3711 | b = 42; |
| 3712 | return 0; |
| 3713 | } |
| 3714 | |
| 3715 | fn g(i : ptr<private, i32>, j : i32) -> i32 { |
| 3716 | return *(i); |
| 3717 | } |
| 3718 | |
| 3719 | fn f() { |
| 3720 | let tint_symbol = a(0); |
| 3721 | let r = g(&(b), tint_symbol); |
| 3722 | } |
| 3723 | )"; |
| 3724 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3725 | DataMap data; |
| 3726 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3727 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3728 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3729 | } |
| 3730 | |
| 3731 | TEST_F(PromoteSideEffectsToDeclTest, TypeCtor_VarPlusI32CtorPlusVar) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3732 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3733 | fn f() { |
| 3734 | var b = 0; |
| 3735 | var c = 0; |
| 3736 | var d = 0; |
| 3737 | let r = ((b + i32(c)) + d); |
| 3738 | } |
| 3739 | )"; |
| 3740 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3741 | auto* expect = src; |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3742 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3743 | DataMap data; |
| 3744 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3745 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3746 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3747 | } |
| 3748 | |
| 3749 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Mixed_ArithPlusLogical) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3750 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3751 | fn a(i : i32) -> i32 { |
| 3752 | return 0; |
| 3753 | } |
| 3754 | |
| 3755 | fn b(i : i32) -> bool { |
| 3756 | return true; |
| 3757 | } |
| 3758 | |
| 3759 | fn g(i : bool) -> i32 { |
| 3760 | return 0; |
| 3761 | } |
| 3762 | |
| 3763 | fn f() { |
| 3764 | let r = a(0) + g(b(1) && b(2)); |
| 3765 | } |
| 3766 | )"; |
| 3767 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3768 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3769 | fn a(i : i32) -> i32 { |
| 3770 | return 0; |
| 3771 | } |
| 3772 | |
| 3773 | fn b(i : i32) -> bool { |
| 3774 | return true; |
| 3775 | } |
| 3776 | |
| 3777 | fn g(i : bool) -> i32 { |
| 3778 | return 0; |
| 3779 | } |
| 3780 | |
| 3781 | fn f() { |
| 3782 | let tint_symbol = a(0); |
| 3783 | var tint_symbol_1 = b(1); |
| 3784 | if (tint_symbol_1) { |
| 3785 | tint_symbol_1 = b(2); |
| 3786 | } |
| 3787 | let tint_symbol_2 = g(tint_symbol_1); |
| 3788 | let r = (tint_symbol + tint_symbol_2); |
| 3789 | } |
| 3790 | )"; |
| 3791 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3792 | DataMap data; |
| 3793 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3794 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3795 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3796 | } |
| 3797 | |
| 3798 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Mixed_LogicalPlusArith) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3799 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3800 | fn a(i : i32) -> i32 { |
| 3801 | return 0; |
| 3802 | } |
| 3803 | |
| 3804 | fn b(i : i32) -> bool { |
| 3805 | return true; |
| 3806 | } |
| 3807 | |
| 3808 | fn g(i : bool) -> i32 { |
| 3809 | return 0; |
| 3810 | } |
| 3811 | |
| 3812 | fn f() { |
| 3813 | let r = g(b(0) && b(1)) + a(2); |
| 3814 | } |
| 3815 | )"; |
| 3816 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3817 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3818 | fn a(i : i32) -> i32 { |
| 3819 | return 0; |
| 3820 | } |
| 3821 | |
| 3822 | fn b(i : i32) -> bool { |
| 3823 | return true; |
| 3824 | } |
| 3825 | |
| 3826 | fn g(i : bool) -> i32 { |
| 3827 | return 0; |
| 3828 | } |
| 3829 | |
| 3830 | fn f() { |
| 3831 | var tint_symbol = b(0); |
| 3832 | if (tint_symbol) { |
| 3833 | tint_symbol = b(1); |
| 3834 | } |
| 3835 | let tint_symbol_1 = g(tint_symbol); |
| 3836 | let tint_symbol_2 = a(2); |
| 3837 | let r = (tint_symbol_1 + tint_symbol_2); |
| 3838 | } |
| 3839 | )"; |
| 3840 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3841 | DataMap data; |
| 3842 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3843 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3844 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3845 | } |
| 3846 | |
| 3847 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Mixed_ArithAndLogicalArgs) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3848 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3849 | fn a(i : i32) -> i32 { |
| 3850 | return 0; |
| 3851 | } |
| 3852 | |
| 3853 | fn b(i : i32) -> bool { |
| 3854 | return true; |
| 3855 | } |
| 3856 | |
| 3857 | fn g(i : i32, j : bool) -> i32 { |
| 3858 | return 0; |
| 3859 | } |
| 3860 | |
| 3861 | fn f() { |
| 3862 | let r = g(a(0), b(1) && b(2)); |
| 3863 | } |
| 3864 | )"; |
| 3865 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3866 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3867 | fn a(i : i32) -> i32 { |
| 3868 | return 0; |
| 3869 | } |
| 3870 | |
| 3871 | fn b(i : i32) -> bool { |
| 3872 | return true; |
| 3873 | } |
| 3874 | |
| 3875 | fn g(i : i32, j : bool) -> i32 { |
| 3876 | return 0; |
| 3877 | } |
| 3878 | |
| 3879 | fn f() { |
| 3880 | let tint_symbol = a(0); |
| 3881 | var tint_symbol_1 = b(1); |
| 3882 | if (tint_symbol_1) { |
| 3883 | tint_symbol_1 = b(2); |
| 3884 | } |
| 3885 | let r = g(tint_symbol, tint_symbol_1); |
| 3886 | } |
| 3887 | )"; |
| 3888 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3889 | DataMap data; |
| 3890 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3891 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3892 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3893 | } |
| 3894 | |
| 3895 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Mixed_LogicalAndArithArgs) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3896 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3897 | fn a(i : i32) -> i32 { |
| 3898 | return 0; |
| 3899 | } |
| 3900 | |
| 3901 | fn b(i : i32) -> bool { |
| 3902 | return true; |
| 3903 | } |
| 3904 | |
| 3905 | fn g(i : bool, j : i32) -> i32 { |
| 3906 | return 0; |
| 3907 | } |
| 3908 | |
| 3909 | fn f() { |
| 3910 | let r = g(b(0) && b(1), a(2)); |
| 3911 | } |
| 3912 | )"; |
| 3913 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3914 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3915 | fn a(i : i32) -> i32 { |
| 3916 | return 0; |
| 3917 | } |
| 3918 | |
| 3919 | fn b(i : i32) -> bool { |
| 3920 | return true; |
| 3921 | } |
| 3922 | |
| 3923 | fn g(i : bool, j : i32) -> i32 { |
| 3924 | return 0; |
| 3925 | } |
| 3926 | |
| 3927 | fn f() { |
| 3928 | var tint_symbol = b(0); |
| 3929 | if (tint_symbol) { |
| 3930 | tint_symbol = b(1); |
| 3931 | } |
| 3932 | let tint_symbol_1 = a(2); |
| 3933 | let r = g(tint_symbol, tint_symbol_1); |
| 3934 | } |
| 3935 | )"; |
| 3936 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3937 | DataMap data; |
| 3938 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3939 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3940 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3941 | } |
| 3942 | |
| 3943 | TEST_F(PromoteSideEffectsToDeclTest, Binary_Mixed_Complex) { |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3944 | auto* src = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3945 | fn a(i : i32) -> i32 { |
| 3946 | return 0; |
| 3947 | } |
| 3948 | |
| 3949 | fn b(i : i32) -> bool { |
| 3950 | return true; |
| 3951 | } |
| 3952 | |
| 3953 | fn c(i : bool) -> i32 { |
| 3954 | return 0; |
| 3955 | } |
| 3956 | |
| 3957 | fn g(i : bool, j : i32) -> i32 { |
| 3958 | return 0; |
| 3959 | } |
| 3960 | |
| 3961 | fn f() { |
| 3962 | let r = a(0) + g(b(1) && b(a(2) + a(3)), a(4)) + a(5); |
| 3963 | } |
| 3964 | )"; |
| 3965 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3966 | auto* expect = R"( |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 3967 | fn a(i : i32) -> i32 { |
| 3968 | return 0; |
| 3969 | } |
| 3970 | |
| 3971 | fn b(i : i32) -> bool { |
| 3972 | return true; |
| 3973 | } |
| 3974 | |
| 3975 | fn c(i : bool) -> i32 { |
| 3976 | return 0; |
| 3977 | } |
| 3978 | |
| 3979 | fn g(i : bool, j : i32) -> i32 { |
| 3980 | return 0; |
| 3981 | } |
| 3982 | |
| 3983 | fn f() { |
| 3984 | let tint_symbol = a(0); |
| 3985 | var tint_symbol_1 = b(1); |
| 3986 | if (tint_symbol_1) { |
| 3987 | let tint_symbol_2 = a(2); |
| 3988 | let tint_symbol_3 = a(3); |
| 3989 | tint_symbol_1 = b((tint_symbol_2 + tint_symbol_3)); |
| 3990 | } |
| 3991 | let tint_symbol_4 = a(4); |
| 3992 | let tint_symbol_5 = g(tint_symbol_1, tint_symbol_4); |
| 3993 | let tint_symbol_6 = a(5); |
| 3994 | let r = ((tint_symbol + tint_symbol_5) + tint_symbol_6); |
| 3995 | } |
| 3996 | )"; |
| 3997 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 3998 | DataMap data; |
| 3999 | auto got = Run<PromoteSideEffectsToDecl>(src, data); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 4000 | |
dan sinclair | 41e4d9a | 2022-05-01 14:40:55 +0000 | [diff] [blame] | 4001 | EXPECT_EQ(expect, str(got)); |
Antonio Maiorano | c25ddf4 | 2022-03-15 15:03:03 +0000 | [diff] [blame] | 4002 | } |
| 4003 | } // namespace |
dan sinclair | b5599d3 | 2022-04-07 16:55:14 +0000 | [diff] [blame] | 4004 | } // namespace tint::transform |