Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 1 | // Copyright 2021 The Tint Authors. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | #include "src/transform/calculate_array_length.h" |
| 16 | |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 17 | #include "src/transform/simplify_pointers.h" |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 18 | #include "src/transform/test_helper.h" |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 19 | #include "src/transform/unshadow.h" |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 20 | |
| 21 | namespace tint { |
| 22 | namespace transform { |
| 23 | namespace { |
| 24 | |
| 25 | using CalculateArrayLengthTest = TransformTest; |
| 26 | |
Ben Clayton | 800b8e3 | 2022-01-25 21:36:04 +0000 | [diff] [blame] | 27 | TEST_F(CalculateArrayLengthTest, ShouldRunEmptyModule) { |
| 28 | auto* src = R"()"; |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 29 | |
Ben Clayton | 800b8e3 | 2022-01-25 21:36:04 +0000 | [diff] [blame] | 30 | EXPECT_FALSE(ShouldRun<CalculateArrayLength>(src)); |
| 31 | } |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 32 | |
Ben Clayton | 800b8e3 | 2022-01-25 21:36:04 +0000 | [diff] [blame] | 33 | TEST_F(CalculateArrayLengthTest, ShouldRunNoArrayLength) { |
| 34 | auto* src = R"( |
| 35 | struct SB { |
| 36 | x : i32; |
| 37 | arr : array<i32>; |
| 38 | }; |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 39 | |
Ben Clayton | 800b8e3 | 2022-01-25 21:36:04 +0000 | [diff] [blame] | 40 | [[group(0), binding(0)]] var<storage, read> sb : SB; |
| 41 | |
| 42 | [[stage(compute), workgroup_size(1)]] |
| 43 | fn main() { |
| 44 | } |
| 45 | )"; |
| 46 | |
| 47 | EXPECT_FALSE(ShouldRun<CalculateArrayLength>(src)); |
| 48 | } |
| 49 | |
| 50 | TEST_F(CalculateArrayLengthTest, ShouldRunWithArrayLength) { |
| 51 | auto* src = R"( |
| 52 | struct SB { |
| 53 | x : i32; |
| 54 | arr : array<i32>; |
| 55 | }; |
| 56 | |
| 57 | [[group(0), binding(0)]] var<storage, read> sb : SB; |
| 58 | |
| 59 | [[stage(compute), workgroup_size(1)]] |
| 60 | fn main() { |
| 61 | var len : u32 = arrayLength(&sb.arr); |
| 62 | } |
| 63 | )"; |
| 64 | |
| 65 | EXPECT_TRUE(ShouldRun<CalculateArrayLength>(src)); |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 66 | } |
| 67 | |
Ben Clayton | 3fe1bd3 | 2022-01-28 16:49:46 +0000 | [diff] [blame] | 68 | TEST_F(CalculateArrayLengthTest, BasicArray) { |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 69 | auto* src = R"( |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 70 | @group(0) @binding(0) var<storage, read> sb : array<i32>; |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 71 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 72 | @stage(compute) @workgroup_size(1) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 73 | fn main() { |
| 74 | var len : u32 = arrayLength(&sb); |
| 75 | } |
| 76 | )"; |
| 77 | |
| 78 | auto* expect = R"( |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 79 | @internal(intrinsic_buffer_size) |
| 80 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : array<i32>, result : ptr<function, u32>) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 81 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 82 | @group(0) @binding(0) var<storage, read> sb : array<i32>; |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 83 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 84 | @stage(compute) @workgroup_size(1) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 85 | fn main() { |
| 86 | var tint_symbol_1 : u32 = 0u; |
| 87 | tint_symbol(sb, &(tint_symbol_1)); |
| 88 | let tint_symbol_2 : u32 = (tint_symbol_1 / 4u); |
| 89 | var len : u32 = tint_symbol_2; |
| 90 | } |
| 91 | )"; |
| 92 | |
| 93 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
| 94 | |
| 95 | EXPECT_EQ(expect, str(got)); |
| 96 | } |
| 97 | |
| 98 | TEST_F(CalculateArrayLengthTest, BasicInStruct) { |
| 99 | auto* src = R"( |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 100 | struct SB { |
| 101 | x : i32; |
| 102 | arr : array<i32>; |
| 103 | }; |
| 104 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 105 | @group(0) @binding(0) var<storage, read> sb : SB; |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 106 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 107 | @stage(compute) @workgroup_size(1) |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 108 | fn main() { |
| 109 | var len : u32 = arrayLength(&sb.arr); |
| 110 | } |
| 111 | )"; |
| 112 | |
| 113 | auto* expect = R"( |
Ben Clayton | 6688b0a | 2022-02-11 12:59:08 +0000 | [diff] [blame] | 114 | @internal(intrinsic_buffer_size) |
| 115 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : SB, result : ptr<function, u32>) |
| 116 | |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 117 | struct SB { |
| 118 | x : i32; |
| 119 | arr : array<i32>; |
James Price | 6b1e5f5 | 2022-01-19 18:11:17 +0000 | [diff] [blame] | 120 | } |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 121 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 122 | @group(0) @binding(0) var<storage, read> sb : SB; |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 123 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 124 | @stage(compute) @workgroup_size(1) |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 125 | fn main() { |
| 126 | var tint_symbol_1 : u32 = 0u; |
| 127 | tint_symbol(sb, &(tint_symbol_1)); |
| 128 | let tint_symbol_2 : u32 = ((tint_symbol_1 - 4u) / 4u); |
| 129 | var len : u32 = tint_symbol_2; |
| 130 | } |
| 131 | )"; |
| 132 | |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 133 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 134 | |
| 135 | EXPECT_EQ(expect, str(got)); |
| 136 | } |
| 137 | |
Ben Clayton | 3fe1bd3 | 2022-01-28 16:49:46 +0000 | [diff] [blame] | 138 | TEST_F(CalculateArrayLengthTest, ArrayOfStruct) { |
| 139 | auto* src = R"( |
| 140 | struct S { |
| 141 | f : f32; |
| 142 | } |
| 143 | |
| 144 | @group(0) @binding(0) var<storage, read> arr : array<S>; |
| 145 | |
| 146 | @stage(compute) @workgroup_size(1) |
| 147 | fn main() { |
| 148 | let len = arrayLength(&arr); |
| 149 | } |
| 150 | )"; |
| 151 | auto* expect = R"( |
Ben Clayton | 6688b0a | 2022-02-11 12:59:08 +0000 | [diff] [blame] | 152 | @internal(intrinsic_buffer_size) |
| 153 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : array<S>, result : ptr<function, u32>) |
| 154 | |
Ben Clayton | 3fe1bd3 | 2022-01-28 16:49:46 +0000 | [diff] [blame] | 155 | struct S { |
| 156 | f : f32; |
| 157 | } |
| 158 | |
Ben Clayton | 3fe1bd3 | 2022-01-28 16:49:46 +0000 | [diff] [blame] | 159 | @group(0) @binding(0) var<storage, read> arr : array<S>; |
| 160 | |
| 161 | @stage(compute) @workgroup_size(1) |
| 162 | fn main() { |
| 163 | var tint_symbol_1 : u32 = 0u; |
| 164 | tint_symbol(arr, &(tint_symbol_1)); |
| 165 | let tint_symbol_2 : u32 = (tint_symbol_1 / 4u); |
| 166 | let len = tint_symbol_2; |
| 167 | } |
| 168 | )"; |
| 169 | |
| 170 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
| 171 | |
| 172 | EXPECT_EQ(expect, str(got)); |
| 173 | } |
| 174 | |
| 175 | TEST_F(CalculateArrayLengthTest, ArrayOfArrayOfStruct) { |
| 176 | auto* src = R"( |
| 177 | struct S { |
| 178 | f : f32; |
| 179 | } |
| 180 | |
| 181 | @group(0) @binding(0) var<storage, read> arr : array<array<S, 4>>; |
| 182 | |
| 183 | @stage(compute) @workgroup_size(1) |
| 184 | fn main() { |
| 185 | let len = arrayLength(&arr); |
| 186 | } |
| 187 | )"; |
| 188 | auto* expect = R"( |
Ben Clayton | 6688b0a | 2022-02-11 12:59:08 +0000 | [diff] [blame] | 189 | @internal(intrinsic_buffer_size) |
| 190 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : array<array<S, 4u>>, result : ptr<function, u32>) |
| 191 | |
Ben Clayton | 3fe1bd3 | 2022-01-28 16:49:46 +0000 | [diff] [blame] | 192 | struct S { |
| 193 | f : f32; |
| 194 | } |
| 195 | |
Ben Clayton | 3fe1bd3 | 2022-01-28 16:49:46 +0000 | [diff] [blame] | 196 | @group(0) @binding(0) var<storage, read> arr : array<array<S, 4>>; |
| 197 | |
| 198 | @stage(compute) @workgroup_size(1) |
| 199 | fn main() { |
| 200 | var tint_symbol_1 : u32 = 0u; |
| 201 | tint_symbol(arr, &(tint_symbol_1)); |
| 202 | let tint_symbol_2 : u32 = (tint_symbol_1 / 16u); |
| 203 | let len = tint_symbol_2; |
| 204 | } |
| 205 | )"; |
| 206 | |
| 207 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
| 208 | |
| 209 | EXPECT_EQ(expect, str(got)); |
| 210 | } |
| 211 | |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 212 | TEST_F(CalculateArrayLengthTest, InSameBlock) { |
| 213 | auto* src = R"( |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 214 | @group(0) @binding(0) var<storage, read> sb : array<i32>;; |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 215 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 216 | @stage(compute) @workgroup_size(1) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 217 | fn main() { |
| 218 | var a : u32 = arrayLength(&sb); |
| 219 | var b : u32 = arrayLength(&sb); |
| 220 | var c : u32 = arrayLength(&sb); |
| 221 | } |
| 222 | )"; |
| 223 | |
| 224 | auto* expect = R"( |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 225 | @internal(intrinsic_buffer_size) |
| 226 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : array<i32>, result : ptr<function, u32>) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 227 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 228 | @group(0) @binding(0) var<storage, read> sb : array<i32>; |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 229 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 230 | @stage(compute) @workgroup_size(1) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 231 | fn main() { |
| 232 | var tint_symbol_1 : u32 = 0u; |
| 233 | tint_symbol(sb, &(tint_symbol_1)); |
| 234 | let tint_symbol_2 : u32 = (tint_symbol_1 / 4u); |
| 235 | var a : u32 = tint_symbol_2; |
| 236 | var b : u32 = tint_symbol_2; |
| 237 | var c : u32 = tint_symbol_2; |
| 238 | } |
| 239 | )"; |
| 240 | |
| 241 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
| 242 | |
| 243 | EXPECT_EQ(expect, str(got)); |
| 244 | } |
| 245 | |
| 246 | TEST_F(CalculateArrayLengthTest, InSameBlock_Struct) { |
| 247 | auto* src = R"( |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 248 | struct SB { |
| 249 | x : i32; |
| 250 | arr : array<i32>; |
| 251 | }; |
| 252 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 253 | @group(0) @binding(0) var<storage, read> sb : SB; |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 254 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 255 | @stage(compute) @workgroup_size(1) |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 256 | fn main() { |
| 257 | var a : u32 = arrayLength(&sb.arr); |
| 258 | var b : u32 = arrayLength(&sb.arr); |
| 259 | var c : u32 = arrayLength(&sb.arr); |
| 260 | } |
| 261 | )"; |
| 262 | |
| 263 | auto* expect = R"( |
Ben Clayton | 6688b0a | 2022-02-11 12:59:08 +0000 | [diff] [blame] | 264 | @internal(intrinsic_buffer_size) |
| 265 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : SB, result : ptr<function, u32>) |
| 266 | |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 267 | struct SB { |
| 268 | x : i32; |
| 269 | arr : array<i32>; |
James Price | 6b1e5f5 | 2022-01-19 18:11:17 +0000 | [diff] [blame] | 270 | } |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 271 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 272 | @group(0) @binding(0) var<storage, read> sb : SB; |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 273 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 274 | @stage(compute) @workgroup_size(1) |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 275 | fn main() { |
| 276 | var tint_symbol_1 : u32 = 0u; |
| 277 | tint_symbol(sb, &(tint_symbol_1)); |
| 278 | let tint_symbol_2 : u32 = ((tint_symbol_1 - 4u) / 4u); |
| 279 | var a : u32 = tint_symbol_2; |
| 280 | var b : u32 = tint_symbol_2; |
| 281 | var c : u32 = tint_symbol_2; |
| 282 | } |
| 283 | )"; |
| 284 | |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 285 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 286 | |
| 287 | EXPECT_EQ(expect, str(got)); |
| 288 | } |
| 289 | |
| 290 | TEST_F(CalculateArrayLengthTest, WithStride) { |
| 291 | auto* src = R"( |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 292 | @group(0) @binding(0) var<storage, read> sb : @stride(64) array<i32>; |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 293 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 294 | @stage(compute) @workgroup_size(1) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 295 | fn main() { |
| 296 | var len : u32 = arrayLength(&sb); |
| 297 | } |
| 298 | )"; |
| 299 | |
| 300 | auto* expect = R"( |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 301 | @internal(intrinsic_buffer_size) |
| 302 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : @stride(64) array<i32>, result : ptr<function, u32>) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 303 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 304 | @group(0) @binding(0) var<storage, read> sb : @stride(64) array<i32>; |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 305 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 306 | @stage(compute) @workgroup_size(1) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 307 | fn main() { |
| 308 | var tint_symbol_1 : u32 = 0u; |
| 309 | tint_symbol(sb, &(tint_symbol_1)); |
| 310 | let tint_symbol_2 : u32 = (tint_symbol_1 / 64u); |
| 311 | var len : u32 = tint_symbol_2; |
| 312 | } |
| 313 | )"; |
| 314 | |
| 315 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
| 316 | |
| 317 | EXPECT_EQ(expect, str(got)); |
| 318 | } |
| 319 | |
| 320 | TEST_F(CalculateArrayLengthTest, WithStride_InStruct) { |
| 321 | auto* src = R"( |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 322 | struct SB { |
| 323 | x : i32; |
| 324 | y : f32; |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 325 | arr : @stride(64) array<i32>; |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 326 | }; |
| 327 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 328 | @group(0) @binding(0) var<storage, read> sb : SB; |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 329 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 330 | @stage(compute) @workgroup_size(1) |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 331 | fn main() { |
| 332 | var len : u32 = arrayLength(&sb.arr); |
| 333 | } |
| 334 | )"; |
| 335 | |
| 336 | auto* expect = R"( |
Ben Clayton | 6688b0a | 2022-02-11 12:59:08 +0000 | [diff] [blame] | 337 | @internal(intrinsic_buffer_size) |
| 338 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : SB, result : ptr<function, u32>) |
| 339 | |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 340 | struct SB { |
| 341 | x : i32; |
| 342 | y : f32; |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 343 | arr : @stride(64) array<i32>; |
James Price | 6b1e5f5 | 2022-01-19 18:11:17 +0000 | [diff] [blame] | 344 | } |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 345 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 346 | @group(0) @binding(0) var<storage, read> sb : SB; |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 347 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 348 | @stage(compute) @workgroup_size(1) |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 349 | fn main() { |
| 350 | var tint_symbol_1 : u32 = 0u; |
| 351 | tint_symbol(sb, &(tint_symbol_1)); |
| 352 | let tint_symbol_2 : u32 = ((tint_symbol_1 - 8u) / 64u); |
| 353 | var len : u32 = tint_symbol_2; |
| 354 | } |
| 355 | )"; |
| 356 | |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 357 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 358 | |
| 359 | EXPECT_EQ(expect, str(got)); |
| 360 | } |
| 361 | |
| 362 | TEST_F(CalculateArrayLengthTest, Nested) { |
| 363 | auto* src = R"( |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 364 | struct SB { |
| 365 | x : i32; |
| 366 | arr : array<i32>; |
| 367 | }; |
| 368 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 369 | @group(0) @binding(0) var<storage, read> sb : SB; |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 370 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 371 | @stage(compute) @workgroup_size(1) |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 372 | fn main() { |
| 373 | if (true) { |
| 374 | var len : u32 = arrayLength(&sb.arr); |
| 375 | } else { |
| 376 | if (true) { |
| 377 | var len : u32 = arrayLength(&sb.arr); |
| 378 | } |
| 379 | } |
| 380 | } |
| 381 | )"; |
| 382 | |
| 383 | auto* expect = R"( |
Ben Clayton | 6688b0a | 2022-02-11 12:59:08 +0000 | [diff] [blame] | 384 | @internal(intrinsic_buffer_size) |
| 385 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : SB, result : ptr<function, u32>) |
| 386 | |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 387 | struct SB { |
| 388 | x : i32; |
| 389 | arr : array<i32>; |
James Price | 6b1e5f5 | 2022-01-19 18:11:17 +0000 | [diff] [blame] | 390 | } |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 391 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 392 | @group(0) @binding(0) var<storage, read> sb : SB; |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 393 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 394 | @stage(compute) @workgroup_size(1) |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 395 | fn main() { |
| 396 | if (true) { |
| 397 | var tint_symbol_1 : u32 = 0u; |
| 398 | tint_symbol(sb, &(tint_symbol_1)); |
| 399 | let tint_symbol_2 : u32 = ((tint_symbol_1 - 4u) / 4u); |
| 400 | var len : u32 = tint_symbol_2; |
| 401 | } else { |
| 402 | if (true) { |
| 403 | var tint_symbol_3 : u32 = 0u; |
| 404 | tint_symbol(sb, &(tint_symbol_3)); |
| 405 | let tint_symbol_4 : u32 = ((tint_symbol_3 - 4u) / 4u); |
| 406 | var len : u32 = tint_symbol_4; |
| 407 | } |
| 408 | } |
| 409 | } |
| 410 | )"; |
| 411 | |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 412 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 413 | |
| 414 | EXPECT_EQ(expect, str(got)); |
| 415 | } |
| 416 | |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 417 | TEST_F(CalculateArrayLengthTest, MultipleStorageBuffers) { |
| 418 | auto* src = R"( |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 419 | struct SB1 { |
| 420 | x : i32; |
| 421 | arr1 : array<i32>; |
| 422 | }; |
| 423 | |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 424 | struct SB2 { |
| 425 | x : i32; |
| 426 | arr2 : array<vec4<f32>>; |
| 427 | }; |
| 428 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 429 | @group(0) @binding(0) var<storage, read> sb1 : SB1; |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 430 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 431 | @group(0) @binding(1) var<storage, read> sb2 : SB2; |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 432 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 433 | @group(0) @binding(2) var<storage, read> sb3 : array<i32>; |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 434 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 435 | @stage(compute) @workgroup_size(1) |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 436 | fn main() { |
Ben Clayton | aba42ed | 2021-06-10 18:43:04 +0000 | [diff] [blame] | 437 | var len1 : u32 = arrayLength(&(sb1.arr1)); |
| 438 | var len2 : u32 = arrayLength(&(sb2.arr2)); |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 439 | var len3 : u32 = arrayLength(&sb3); |
| 440 | var x : u32 = (len1 + len2 + len3); |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 441 | } |
| 442 | )"; |
| 443 | |
| 444 | auto* expect = R"( |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 445 | @internal(intrinsic_buffer_size) |
Ben Clayton | 6688b0a | 2022-02-11 12:59:08 +0000 | [diff] [blame] | 446 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : SB1, result : ptr<function, u32>) |
| 447 | |
| 448 | @internal(intrinsic_buffer_size) |
| 449 | fn tint_symbol_3(@internal(disable_validation__ignore_constructible_function_parameter) buffer : SB2, result : ptr<function, u32>) |
| 450 | |
| 451 | @internal(intrinsic_buffer_size) |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 452 | fn tint_symbol_6(@internal(disable_validation__ignore_constructible_function_parameter) buffer : array<i32>, result : ptr<function, u32>) |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 453 | |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 454 | struct SB1 { |
| 455 | x : i32; |
| 456 | arr1 : array<i32>; |
James Price | 6b1e5f5 | 2022-01-19 18:11:17 +0000 | [diff] [blame] | 457 | } |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 458 | |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 459 | struct SB2 { |
| 460 | x : i32; |
| 461 | arr2 : array<vec4<f32>>; |
James Price | 6b1e5f5 | 2022-01-19 18:11:17 +0000 | [diff] [blame] | 462 | } |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 463 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 464 | @group(0) @binding(0) var<storage, read> sb1 : SB1; |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 465 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 466 | @group(0) @binding(1) var<storage, read> sb2 : SB2; |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 467 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 468 | @group(0) @binding(2) var<storage, read> sb3 : array<i32>; |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 469 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 470 | @stage(compute) @workgroup_size(1) |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 471 | fn main() { |
Ben Clayton | 363a2e2 | 2021-04-13 20:07:57 +0000 | [diff] [blame] | 472 | var tint_symbol_1 : u32 = 0u; |
Antonio Maiorano | 14b3403 | 2021-06-09 20:17:59 +0000 | [diff] [blame] | 473 | tint_symbol(sb1, &(tint_symbol_1)); |
Ben Clayton | 363a2e2 | 2021-04-13 20:07:57 +0000 | [diff] [blame] | 474 | let tint_symbol_2 : u32 = ((tint_symbol_1 - 4u) / 4u); |
| 475 | var tint_symbol_4 : u32 = 0u; |
Antonio Maiorano | 14b3403 | 2021-06-09 20:17:59 +0000 | [diff] [blame] | 476 | tint_symbol_3(sb2, &(tint_symbol_4)); |
Ben Clayton | 363a2e2 | 2021-04-13 20:07:57 +0000 | [diff] [blame] | 477 | let tint_symbol_5 : u32 = ((tint_symbol_4 - 16u) / 16u); |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 478 | var tint_symbol_7 : u32 = 0u; |
| 479 | tint_symbol_6(sb3, &(tint_symbol_7)); |
| 480 | let tint_symbol_8 : u32 = (tint_symbol_7 / 4u); |
Ben Clayton | 363a2e2 | 2021-04-13 20:07:57 +0000 | [diff] [blame] | 481 | var len1 : u32 = tint_symbol_2; |
| 482 | var len2 : u32 = tint_symbol_5; |
James Price | 51e55b2 | 2022-01-19 15:55:56 +0000 | [diff] [blame] | 483 | var len3 : u32 = tint_symbol_8; |
| 484 | var x : u32 = ((len1 + len2) + len3); |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 485 | } |
| 486 | )"; |
| 487 | |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 488 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
| 489 | |
| 490 | EXPECT_EQ(expect, str(got)); |
| 491 | } |
| 492 | |
| 493 | TEST_F(CalculateArrayLengthTest, Shadowing) { |
| 494 | auto* src = R"( |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 495 | struct SB { |
| 496 | x : i32; |
| 497 | arr : array<i32>; |
| 498 | }; |
| 499 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 500 | @group(0) @binding(0) var<storage, read> a : SB; |
| 501 | @group(0) @binding(1) var<storage, read> b : SB; |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 502 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 503 | @stage(compute) @workgroup_size(1) |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 504 | fn main() { |
| 505 | let x = &a; |
| 506 | var a : u32 = arrayLength(&a.arr); |
| 507 | { |
| 508 | var b : u32 = arrayLength(&((*x).arr)); |
| 509 | } |
| 510 | } |
| 511 | )"; |
| 512 | |
| 513 | auto* expect = |
| 514 | R"( |
Ben Clayton | 6688b0a | 2022-02-11 12:59:08 +0000 | [diff] [blame] | 515 | @internal(intrinsic_buffer_size) |
| 516 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : SB, result : ptr<function, u32>) |
| 517 | |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 518 | struct SB { |
| 519 | x : i32; |
| 520 | arr : array<i32>; |
James Price | 6b1e5f5 | 2022-01-19 18:11:17 +0000 | [diff] [blame] | 521 | } |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 522 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 523 | @group(0) @binding(0) var<storage, read> a : SB; |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 524 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 525 | @group(0) @binding(1) var<storage, read> b : SB; |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 526 | |
Ben Clayton | 01e4b6f | 2022-01-19 22:46:57 +0000 | [diff] [blame] | 527 | @stage(compute) @workgroup_size(1) |
Ben Clayton | b05e185 | 2021-11-23 20:45:51 +0000 | [diff] [blame] | 528 | fn main() { |
| 529 | var tint_symbol_1 : u32 = 0u; |
| 530 | tint_symbol(a, &(tint_symbol_1)); |
| 531 | let tint_symbol_2 : u32 = ((tint_symbol_1 - 4u) / 4u); |
| 532 | var a_1 : u32 = tint_symbol_2; |
| 533 | { |
| 534 | var tint_symbol_3 : u32 = 0u; |
| 535 | tint_symbol(a, &(tint_symbol_3)); |
| 536 | let tint_symbol_4 : u32 = ((tint_symbol_3 - 4u) / 4u); |
| 537 | var b_1 : u32 = tint_symbol_4; |
| 538 | } |
| 539 | } |
| 540 | )"; |
| 541 | |
| 542 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 543 | |
| 544 | EXPECT_EQ(expect, str(got)); |
| 545 | } |
| 546 | |
Ben Clayton | 6688b0a | 2022-02-11 12:59:08 +0000 | [diff] [blame] | 547 | TEST_F(CalculateArrayLengthTest, OutOfOrder) { |
| 548 | auto* src = R"( |
| 549 | @stage(compute) @workgroup_size(1) |
| 550 | fn main() { |
| 551 | var len1 : u32 = arrayLength(&(sb1.arr1)); |
| 552 | var len2 : u32 = arrayLength(&(sb2.arr2)); |
| 553 | var len3 : u32 = arrayLength(&sb3); |
| 554 | var x : u32 = (len1 + len2 + len3); |
| 555 | } |
| 556 | |
| 557 | @group(0) @binding(0) var<storage, read> sb1 : SB1; |
| 558 | |
| 559 | struct SB1 { |
| 560 | x : i32; |
| 561 | arr1 : array<i32>; |
| 562 | }; |
| 563 | |
| 564 | @group(0) @binding(1) var<storage, read> sb2 : SB2; |
| 565 | |
| 566 | struct SB2 { |
| 567 | x : i32; |
| 568 | arr2 : array<vec4<f32>>; |
| 569 | }; |
| 570 | |
| 571 | @group(0) @binding(2) var<storage, read> sb3 : array<i32>; |
| 572 | )"; |
| 573 | |
| 574 | auto* expect = R"( |
| 575 | @internal(intrinsic_buffer_size) |
| 576 | fn tint_symbol(@internal(disable_validation__ignore_constructible_function_parameter) buffer : SB1, result : ptr<function, u32>) |
| 577 | |
| 578 | @internal(intrinsic_buffer_size) |
| 579 | fn tint_symbol_3(@internal(disable_validation__ignore_constructible_function_parameter) buffer : SB2, result : ptr<function, u32>) |
| 580 | |
| 581 | @internal(intrinsic_buffer_size) |
| 582 | fn tint_symbol_6(@internal(disable_validation__ignore_constructible_function_parameter) buffer : array<i32>, result : ptr<function, u32>) |
| 583 | |
| 584 | @stage(compute) @workgroup_size(1) |
| 585 | fn main() { |
| 586 | var tint_symbol_1 : u32 = 0u; |
| 587 | tint_symbol(sb1, &(tint_symbol_1)); |
| 588 | let tint_symbol_2 : u32 = ((tint_symbol_1 - 4u) / 4u); |
| 589 | var tint_symbol_4 : u32 = 0u; |
| 590 | tint_symbol_3(sb2, &(tint_symbol_4)); |
| 591 | let tint_symbol_5 : u32 = ((tint_symbol_4 - 16u) / 16u); |
| 592 | var tint_symbol_7 : u32 = 0u; |
| 593 | tint_symbol_6(sb3, &(tint_symbol_7)); |
| 594 | let tint_symbol_8 : u32 = (tint_symbol_7 / 4u); |
| 595 | var len1 : u32 = tint_symbol_2; |
| 596 | var len2 : u32 = tint_symbol_5; |
| 597 | var len3 : u32 = tint_symbol_8; |
| 598 | var x : u32 = ((len1 + len2) + len3); |
| 599 | } |
| 600 | |
| 601 | @group(0) @binding(0) var<storage, read> sb1 : SB1; |
| 602 | |
| 603 | struct SB1 { |
| 604 | x : i32; |
| 605 | arr1 : array<i32>; |
| 606 | } |
| 607 | |
| 608 | @group(0) @binding(1) var<storage, read> sb2 : SB2; |
| 609 | |
| 610 | struct SB2 { |
| 611 | x : i32; |
| 612 | arr2 : array<vec4<f32>>; |
| 613 | } |
| 614 | |
| 615 | @group(0) @binding(2) var<storage, read> sb3 : array<i32>; |
| 616 | )"; |
| 617 | |
| 618 | auto got = Run<Unshadow, SimplifyPointers, CalculateArrayLength>(src); |
| 619 | |
| 620 | EXPECT_EQ(expect, str(got)); |
| 621 | } |
| 622 | |
Ben Clayton | 015b9aa | 2021-04-09 10:28:48 +0000 | [diff] [blame] | 623 | } // namespace |
| 624 | } // namespace transform |
| 625 | } // namespace tint |