Google Git
Sign in
dawn / dawn / 10cbb7e35aaefc47143c7104043545d5bd0fb9e3
commit10cbb7e35aaefc47143c7104043545d5bd0fb9e3[log] [tgz]
authordan sinclair <dsinclair@chromium.org>Wed Oct 22 08:00:50 2025 -0700
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 22 08:00:50 2025 -0700
treea05298c7bbc492e9876e97ee1806dc4435eb6466
parentb094b276cd2d01266c7da75997705f2f918c0d7b [diff]
Fix parsing of a semicolon before a break-if.

When parsing a `continuing` statement we handle the `break-if` parsing
specially so it doesn't collide with the general `break` parsing. To do
so, we check explicitly and then if it doesn't match we hand off to the
statement parsing.

In the statement parsing a `;` by itself is ignored. This means we can
accidentally jump over the `break-if` parsing with a `;`, land in the
statement parsing and mistake the `break-if` for a break and error that
the `break` is missing a `;`.

Fix this by skipping `;` in the continuing code before checking if we
have a `break-if`.

Fixed: 453961764
Change-Id: I02b209d9994df17d5f65e8432269473bd2ef60ea
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/268038
Auto-Submit: dan sinclair <dsinclair@chromium.org>
Commit-Queue: James Price <jrprice@google.com>
Reviewed-by: James Price <jrprice@google.com>
2 files changed
tree: a05298c7bbc492e9876e97ee1806dc4435eb6466
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-format-ignore
  20. .clang-tidy
  21. .git-blame-ignore-revs
  22. .gitattributes
  23. .gitignore
  24. .gitmodules
  25. .gn
  26. .style.yapf
  27. .vpython3
  28. AUTHORS
  29. BUILD.bazel
  30. BUILD.gn
  31. CMakeLists.txt
  32. CMakeSettings.json
  33. CODE_OF_CONDUCT.md
  34. codereview.settings
  35. CONTRIBUTING.md
  36. CPPLINT.cfg
  37. DEPS
  38. DIR_METADATA
  39. go.mod
  40. go.sum
  41. go_presubmit_support.py
  42. LICENSE
  43. OWNERS
  44. PRESUBMIT.py
  45. README.chromium
  46. README.md
  47. unsafe_buffers_paths.txt
  48. WATCHLISTS
  49. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.