Google Git
Sign in
dawn / dawn / 21fb99445f32855d3f3f213f2bcd1fa1baca1f59
commit21fb99445f32855d3f3f213f2bcd1fa1baca1f59[log] [tgz]
authorPeter McNeeley <petermcneeley@google.com>Mon Jan 13 10:38:11 2025 -0800
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 13 10:38:11 2025 -0800
tree05e5b4edc9b6c6ff110b45d3a463d18294ce0ff3
parent45b4e0ab199d1fc95ca523bf48e81b39755dc1c7 [diff]
[dawn] Minor fix for redundant move

Redundant move is a warning for some compilers as it can under
very specific situations cause a copy [1].

We cannot simply fix all these warnings by removing all the
redundant moves because some returns are conversions and will not
compile due to move only objects. Such move only objects must
specifically be moved on return.

An example of wholesale attempt (failed):
https://dawn-review.googlesource.com/c/dawn/+/220014?tab=checks

An example of this in dawn can be found here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/dawn/src/dawn/native/ShaderModule.cpp;l=371?q=ShaderModule.cpp:371

Godbolt attempt can be found here:
https://godbolt.org/z/sjrW77brY

[1]
https://developers.redhat.com/blog/2019/04/12/understanding-when-not-to-stdmove-in-c

Change-Id: I7757a9f5435b903645a236946c04047f1951fe8c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/220254
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Peter McNeeley <petermcneeley@google.com>
1 file changed
tree: 05e5b4edc9b6c6ff110b45d3a463d18294ce0ff3
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.