[tint][msl] ArgBufs: emit `_ =` statements unambiguously

Without argbufs, a `_ =` of a uniform/storage value results in:

  uint3((*tint_module_vars.f));

However, with argbufs, `f` becomes a function argument resulting in:

  uint3((*f));

  program_source:30:10: error: pointer type must have explicit address
  space qualifier

This is supposed to be an `expression;` but in C++ it gets parsed
incorrectly as a variable declaration, like `uint3* f;`.
Add parentheses around the expression so it can't be parsed that way:

  (uint3((*f)));

Note, this doesn't happen with bare constructor calls (see call.wgsl)
because in that case phony assignments get emitted for example as:

  int3 const v_2 = int3(z, z, z);

That would work here too, but would require changes to the IR that's
generated for (at least) this particular case, where a constructor is
generated to convert packed_uint3 to uint3. It seems more complicated to
make sure that fully covers all cases, whereas just inserting
parentheses here is simple.

Tests updated with:
  ./tools/run fix-tests out/r/tint_unittests
  ./tools/run tests --tint out/r/tint --generate-expected

Test: test/tint/statements/assign/phony
Test: ShaderTests.StorageAcrossStagesSameBindingPointCollideMixedStructDef
Test: ShaderTests.UniformAcrossStagesSameBindingPointCollideMixedStructDef
Bug: 363031535
Change-Id: I0999092a15a0ed584a39724ef342f9653478ba42
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/308297
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>
2932 files changed
tree: 8adf9f22bb0f5ef196592650bbcdd26179fd42d2
  1. .github/
  2. .vscode/
  3. agents/
  4. build_overrides/
  5. docs/
  6. generator/
  7. include/
  8. infra/
  9. scripts/
  10. src/
  11. test/
  12. third_party/
  13. tools/
  14. webgpu-cts/
  15. .bazelrc
  16. .clang-format
  17. .clang-format-ignore
  18. .clang-tidy
  19. .git-blame-ignore-revs
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. .style.yapf
  25. .vpython3
  26. AUTHORS
  27. BUILD.bazel
  28. BUILD.gn
  29. CMakeLists.txt
  30. CMakeSettings.json
  31. CODE_OF_CONDUCT.md
  32. codereview.settings
  33. CONTRIBUTING.md
  34. CPPLINT.cfg
  35. DEPS
  36. DIR_METADATA
  37. go.mod
  38. go.sum
  39. go_presubmit_support.py
  40. LICENSE
  41. OWNERS
  42. PRESUBMIT.py
  43. README.chromium
  44. README.md
  45. unsafe_buffers_paths.txt
  46. WATCHLISTS
  47. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.