commit | 31f1e527d6865cc02b1ceda203c77cb0da070b79 | [log] [tgz] |
---|---|---|
author | Corentin Wallez <cwallez@chromium.org> | Tue Feb 06 11:17:34 2024 +0000 |
committer | Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Feb 06 11:17:34 2024 +0000 |
tree | 343d065fe9c4cd9201b3832a8c984defa568de72 | |
parent | 2c09910818ca1ea4abca925b6a1d4b4804e97c37 [diff] |
vulkan: Fix synchronization with acquire swapchain images. The vkAcquireNextImageKHR method is a read operation in Vulkan which completes before the semaphore/fence out parameters are signaled. This means that future uses of the texture must performs a memory barriers that synchronizes with that semaphore/barrier. Dawn uses the ALL_COMMANDS_BIT stage for the semaphore, however such a semaphore doesn't synchronize with a subsequent BOTTOM_OF_PIPE or NONE srcStage vkPipelineBarrier because there are no common stages. Instead we also use VK_PIPELINE_STAGE_ALL_COMMANDS_BIT for srcStage for presentable images, ensuring correct ordering. The kPresentTextureUsage is split in two different usages "Acquire" and "Release". When acquiring the stage mask is set to ALL_COMMANDS_BIT and the layout to UNDEFINED (because we will initialize the texture anyway). When release the stage mask is 0 as noted in the Vulkan spec, but the layout set to PRESENT_KHR. Bug: 41497359 Change-Id: I158d3071602ee598e661fca7993865c0881d4f05 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/173463 Reviewed-by: Loko Kung <lokokung@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com>
Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h
that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h
version that Dawn implements.webgpu.h
.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with the webgpu.h docs)
BSD 3-Clause License, please see LICENSE.
This is not an officially supported Google product.