Google Git
Sign in
dawn / dawn / 43b18d23f1be9ea4e01da9f164d1dbbb510978df
commit43b18d23f1be9ea4e01da9f164d1dbbb510978df[log] [tgz]
authorKyle Charbonneau <kylechar@google.com>Sat Nov 16 00:17:54 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Nov 16 00:17:54 2024 +0000
tree2754022b7d0de7d728af3832ba5af146a858c540
parent43e7da53d189d2da034ac6ffcdb391eb8633e72f [diff]
Revert "Use mutex with DeviceVk deallocation queue"

This reverts commit ae9acbdf215860b1474735cd00abffc2ecd79f8f.

Reason for revert: Causes mutex order inversion

Original change's description:
> Use mutex with DeviceVk deallocation queue
>
> DeviceVk::mDescriptorAllocatorsPendingDeallocation can be accessed from
> an arbitrary thread without holding the device mutex. BindGroup
> destruction ends up appending values to the queue in
> Device::EnqueueDeferredDeallocation(). Add a mutex to protect
> mDescriptorAllocatorsPendingDeallocation against data races.
>
> Adding MutexProtected wouldn't work with the existing iteration through
> the queue. This is because mutex would only be held for the duration of
> IterateUpTo() function call which builds BeginEnd. BeginEnd holds
> iterators into the container and if the container is modified while
> BeginEnd exists those iterators may be invalidated. Instead, add
> SerialStorage::TakeUpTo() which makes a new container that contains all
> the elements up to specific serial and removes them from the original
> container.
>
> Bug: 372651189
> Change-Id: I125a575e8b2ee632a681685ede744ae57f790bfa
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/214734
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: Kyle Charbonneau <kylechar@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 372651189
Change-Id: I6f8a187c7dd07d8e91d93b23be9304b97dbdf465
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/215254
Commit-Queue: Kyle Charbonneau <kylechar@google.com>
Auto-Submit: Kyle Charbonneau <kylechar@google.com>
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
2 files changed
tree: 2754022b7d0de7d728af3832ba5af146a858c540
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.