Google Git
Sign in
dawn / dawn / 51765abc2eae26ded1827b1933b3dc452e1ac11a
commit51765abc2eae26ded1827b1933b3dc452e1ac11a[log] [tgz]
authorDaniel Cheng <dcheng@chromium.org>Tue Jul 02 21:41:20 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jul 02 21:41:20 2024 +0000
tree7aae9da4449345e70d94ad4e1dee47de3d767f5e
parent47ae7fb823b74ba1e9e0c9afc7b500bb26adcccf [diff]
[MSan] Fix use-after-dtor issues in generated C++ APIs.

The move assignment operator manually invokes the destructor, to ensure
any data owned by pointer fields is cleaned up instead of leaked.
However, manually invoking the destructor also ends the lifetime of
`this`, and future attempts to use the field become an error when MSan's
use-after-dtor check is enabled.

The fix is to move the cleanup logic into a private helper function and
invoke the helper from both the destructor and the move assignment
operator.

Bug: 40222690
Change-Id: I1c31a1f2c342b0768ecc02f4f84c63b7e3a9160c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/196554
Reviewed-by: Loko Kung <lokokung@google.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
3 files changed
tree: 7aae9da4449345e70d94ad4e1dee47de3d767f5e
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.