commit | 532be50b761b660e2e5e354bbffb5b020df9afef | [log] [tgz] |
---|---|---|
author | Jiawei Shao <jiawei.shao@intel.com> | Mon Mar 09 00:45:18 2020 +0000 |
committer | Commit Bot service account <commit-bot@chromium.org> | Mon Mar 09 00:45:18 2020 +0000 |
tree | beba8b0a7b01eb4099613235a4f534a92cf16b48 | |
parent | 7d20b4450182b8e25dfd315019623d7a746cc290 [diff] |
Check bindingType with shader stage when creating default pipeline layout This patch intends to fix a crash issue when creating a rendering pipeline with storage buffer declared in vertex shader and pipeline layout is not set. Without this patch, in PipelineLayoutBase::CreateDefault() the bindingSlot.visibility is always set to Fragment and Compute when it is a storage buffer, therefore a crash happens at the failure of the assertion modules->IsCompatibleWithPipelineLayout() when the storage buffer is actually declared in the vertex shader. BUG=dawn:276 TEST=dawn_unittests Change-Id: I56876a97d53ead5ed226dc1b9bbed1a77156b2b2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/16564 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
Dawn is an open-source and cross-platform implementation of the work-in-progress WebGPU standard. More precisely it implements webgpu.h
that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.
Dawn provides several WebGPU building blocks:
webgpu.h
version that Dawn implements.webgpu.h
.Helpful links:
Developer documentation:
User documentation: (TODO, figure out what overlaps with webgpu.h docs)
(TODO)
Apache 2.0 Public License, please see LICENSE.
This is not an officially supported Google product.