Google Git
Sign in
dawn / dawn / 72c5d11fbfdef1e54cc686cfb8624d352590474b
commit72c5d11fbfdef1e54cc686cfb8624d352590474b[log] [tgz]
authordan sinclair <dsinclair@chromium.org>Thu Jan 25 18:44:36 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 25 18:44:36 2024 +0000
tree26508b5fa41d0e7427f0ec7177d8086ed440d514
parent76d821975be4c780df245bffe6d187ae96b4089a [diff]
Revert "Use std::variant in ShaderBindingInfo"

This reverts commit 6ff16980d1a68a88a8e4a2a1a184f2c516868178.

Reason for revert: Breaks build with CMake on OSX. https://github.com/google/dawn/actions/runs/7653971595/job/20856970240. Seems like the lambda capture in the visit call needs to capture `&b = bindings` and the bindings usages changed inside the lambda to use the new `b`.

Original change's description:
> Use std::variant in ShaderBindingInfo
>
> This patch uses std::variant to represent 4 possible member types in
> ShaderBindingInfo (BufferBindingLayout, ShaderSamplerBindingInfo,
> ShaderTextureBindingInfo, StorageTextureBindingLayout) as logically
> at any time only one of them can be used.
>
> Bug: dawn:527
> Change-Id: Iad9eaef9706e797cd3db57761dba370047a92fc5
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/171220
> Reviewed-by: Ben Clayton <bclayton@google.com>
> Reviewed-by: Austin Eng <enga@chromium.org>
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>

TBR=cwallez@chromium.org,jiawei.shao@intel.com,enga@chromium.org,bclayton@google.com,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I65e89151be891b88db8a3bed5f63ab8fd6f58d4f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: dawn:527
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/171601
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
7 files changed
tree: 26508b5fa41d0e7427f0ec7177d8086ed440d514
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. Doxyfile
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.