commit 7bc95566d35e4786a9e25a7bcfe57c16e2948c01
author Quyen Le <lehoangquyen@chromium.org> Mon Jul 14 14:11:37 2025 -0700
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jul 14 14:11:37 2025 -0700
tree cb633d7741fab6a03b9bbc0d3bf4f59801addbc8
parent c534e5d5d6087fd4bec624da8a6a9d3b640a1090

Revert "Reland "Reland "Improve DX compiler library loading"""

This reverts commit a45d5b2b40d12d0f650e3f8cdd70a20c853ff5a0.

Reason for revert: Causing dawn_end2end_*validation_layers_tests to
time out on UHD 770 bots
https://ci.chromium.org/ui/p/chromium/builders/luci.chromium.ci/Dawn%20Win10%20x64%20Release%20%28Intel%20UHD%20770%29

Bug: 356665092
Original change's description:
> Reland "Reland "Improve DX compiler library loading""
>
> This is a reland of commit e579b628e5d5276086b6a2eaefa1718586bc7e18
>
> Add dawn_force_system_component_load for projects (like Skia) which
> require that Dawn load all compiler DLL from System32. Best security
> is to leave the default value which (now) loads compiler DLLs from the
> same directory as Dawn code.
>
> On Chromium builds (such as x86) which do not build DXC, place the
> DLLs from the SDK into the build folder to appease infra tools that
> copy the DLLs unconditionally.
>
> Improve DAWN_USE_BUILT_DXC to use the #define to skip loading the DLLs
> altogether.
>
> Original change's description:
> > Reland "Improve DX compiler library loading"
> >
> > This is a reland of commit e4d4669d79501b1acdd2bf017ba491b611d741da
> >
> > Remove build_with_chromium statements in test GN files that copy
> > DLLs. Rely on copies instructions which already exist with the D3D12
> > files.
> >
> > To appease Skia builds which do not depend on the Windows SDK,
> > fallback to system FXC if the local directory version is not found.
> >
> > Original change's description:
> > > Improve DX compiler library loading
> > >
> > > Previously, DX compiler DLLs were loaded using LoadLibrary with no path.
> > > D3D12 compiler DLLs were further sourced from the local user's SDK
> > > directory as a fallback.
> > >
> > > For better security, load DX compiler DLLs using full paths, with
> > > SEARCH_DLL_LOAD_DIR | SEARCH_DEFAULT_DIRS for better security. Scenarios
> > > such as Skia and x86 builds where we need dawn_use_built_dxc will
> > > fallback to FXC. No fallbacks to local user SDK directories.
> > >
> > > Bug:356665092
> > > Change-Id: Ib4148f9b89da694e3868b4f3c3c329a4b06ce922
> > > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/229754
> > > Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> > > Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
> > > Reviewed-by: Antonio Maiorano <amaiorano@google.com>
> >
> > Bug: 356665092
> > Change-Id: Ic05d20c47c5db3021f9e38b724bf527bfba52a5e
> > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/233216
> > Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> > Reviewed-by: Antonio Maiorano <amaiorano@google.com>
> > Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
>
> Bug: 356665092
> Change-Id: I83db06312db28123f9d5aee29617a8746768bb3d
> Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/234919
> Reviewed-by: Antonio Maiorano <amaiorano@google.com>
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 356665092
Change-Id: I1b193762bc185cf55ce8141ae9b39d33e73c204c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/252494
Commit-Queue: dan sinclair <dsinclair@chromium.org>
Auto-Submit: Quyen Le <lehoangquyen@chromium.org>
Reviewed-by: dan sinclair <dsinclair@chromium.org>