Google Git
Sign in
dawn / dawn / a7b805c0712ea6480f8dfd0f3151685aa3d10e66
commita7b805c0712ea6480f8dfd0f3151685aa3d10e66[log] [tgz]
authorRyan Harrison <rharrison@chromium.org>Fri Oct 04 18:02:16 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 04 18:02:16 2024 +0000
tree81495508f4a39867f19a0f8ab7f567ae87554100
parent71f33f2b997b836d39289e324c3a31d83552a179 [diff]
[tint][ir][val] Enforce entry point returns have location or builtin

Specifically when the return is non-void

This CL also changes some of the `CheckFunction` behaviour to not exit
early within this method for non-functional errors, i.e. if something
is null that will cause a segfault later still exit early, but if this
issue justr IR semantics like missing a decoration let the calling
code handle exiting.

This was done to make it somewhat easier to reason about what this
function was doing, since the early exit behaviour meant that the
order of checks affected the flow control in non-obvious ways.

This does introduce at least one instance of 'duplicate' errors,
i.e. a more general and specific error both being logged, but I have
filed a follow up issue (https://issues.chromium.org/issues/371219657)
about going through a proper refactoring of this function, since it is
broadly too complex as it is.

Fixes: 369813099

Change-Id: I4891db07cbad2dc0812b41ac2186ad9ba80d2648
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/209414
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: James Price <jrprice@google.com>
Reviewed-by: James Price <jrprice@google.com>
3 files changed
tree: 81495508f4a39867f19a0f8ab7f567ae87554100
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .git-blame-ignore-revs
  21. .gitattributes
  22. .gitignore
  23. .gitmodules
  24. .gn
  25. AUTHORS
  26. BUILD.bazel
  27. BUILD.gn
  28. CMakeLists.txt
  29. CMakeSettings.json
  30. CODE_OF_CONDUCT.md
  31. codereview.settings
  32. CONTRIBUTING.md
  33. CPPLINT.cfg
  34. DEPS
  35. DIR_METADATA
  36. go.mod
  37. go.sum
  38. go_presubmit_support.py
  39. LICENSE
  40. OWNERS
  41. PRESUBMIT.py
  42. README.chromium
  43. README.md
  44. WATCHLISTS
  45. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.