commit b06b89e9c2d067f99268c47958f676ab6a724192
author Ben Clayton <bclayton@google.com> Mon Apr 12 18:45:14 2021 +0000
committer Commit Bot service account <commit-bot@chromium.org> Mon Apr 12 18:45:14 2021 +0000
tree 206d7f1be0c72bb1dba7923a48a6883e31c2e4c1
parent 10ec9a706fdef5a74b8923d0011e94e9cc6afb11

Reenable D3D12 tests that failed with 'runtime array not supported yet'

Replace TODOs for those tests that now fail with another issue.

Fixed: tint:682
Change-Id: I2665f0d4f495e4efc5adef4cf46a965df7c8936c
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/46451
Auto-Submit: Ben Clayton <bclayton@google.com>
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>

src/tests/end2end/BufferZeroInitTests.cpp

diff --git a/src/tests/end2end/BufferZeroInitTests.cpp b/src/tests/end2end/BufferZeroInitTests.cpp
index f24052c..b91d029 100644
--- a/src/tests/end2end/BufferZeroInitTests.cpp
+++ b/src/tests/end2end/BufferZeroInitTests.cpp
@@ -1186,7 +1186,7 @@
 
 // Test the buffer will be lazily initialized correctly when its first use is in resolveQuerySet
 TEST_P(BufferZeroInitTest, ResolveQuerySet) {
-    // TODO(crbug.com/tint/682): error: runtime array not supported yet
+    // TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
     DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
 
     // Timestamp query is not supported on OpenGL

src/tests/end2end/ComputeCopyStorageBufferTests.cpp

diff --git a/src/tests/end2end/ComputeCopyStorageBufferTests.cpp b/src/tests/end2end/ComputeCopyStorageBufferTests.cpp
index cb346f5..bbda58f 100644
--- a/src/tests/end2end/ComputeCopyStorageBufferTests.cpp
+++ b/src/tests/end2end/ComputeCopyStorageBufferTests.cpp
@@ -141,9 +141,6 @@
 
 // Test that a trivial compute-shader memcpy implementation works.
 TEST_P(ComputeCopyStorageBufferTests, UnsizedArrayOfBasic) {
-    // TODO(crbug.com/tint/682): error: runtime array not supported yet
-    DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
-
     BasicTest(R"(
         [[block]] struct Buf1 {
             s : array<vec4<u32>>;

src/tests/end2end/CopyTextureForBrowserTests.cpp

diff --git a/src/tests/end2end/CopyTextureForBrowserTests.cpp b/src/tests/end2end/CopyTextureForBrowserTests.cpp
index 8f838fd..8689280 100644
--- a/src/tests/end2end/CopyTextureForBrowserTests.cpp
+++ b/src/tests/end2end/CopyTextureForBrowserTests.cpp
@@ -113,9 +113,6 @@
     void SetUp() override {
         DawnTest::SetUp();
 
-        // TODO(crbug.com/tint/682): error: runtime array not supported yet
-        DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
-
         testPipeline = MakeTestPipeline();
 
         uint32_t uniformBufferData[] = {

src/tests/end2end/OpArrayLengthTests.cpp

diff --git a/src/tests/end2end/OpArrayLengthTests.cpp b/src/tests/end2end/OpArrayLengthTests.cpp
index cebe3f9..a936e08 100644
--- a/src/tests/end2end/OpArrayLengthTests.cpp
+++ b/src/tests/end2end/OpArrayLengthTests.cpp
@@ -23,9 +23,6 @@
     void SetUp() {
         DawnTest::SetUp();
 
-        // TODO(crbug.com/tint/682): error: runtime array not supported yet
-        DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
-
         // Create buffers of various size to check the length() implementation
         wgpu::BufferDescriptor bufferDesc;
         bufferDesc.size = 4;

src/tests/end2end/QueryTests.cpp

diff --git a/src/tests/end2end/QueryTests.cpp b/src/tests/end2end/QueryTests.cpp
index 8537c53..daf6e4b 100644
--- a/src/tests/end2end/QueryTests.cpp
+++ b/src/tests/end2end/QueryTests.cpp
@@ -512,7 +512,7 @@
     void SetUp() override {
         DawnTest::SetUp();
 
-        // TODO(crbug.com/tint/682): error: runtime array not supported yet
+        // TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
         DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
 
         // Skip all tests if timestamp extension is not supported

src/tests/white_box/QueryInternalShaderTests.cpp

diff --git a/src/tests/white_box/QueryInternalShaderTests.cpp b/src/tests/white_box/QueryInternalShaderTests.cpp
index 5b61744..7baff77 100644
--- a/src/tests/white_box/QueryInternalShaderTests.cpp
+++ b/src/tests/white_box/QueryInternalShaderTests.cpp
@@ -86,7 +86,7 @@
 //   timestamp period (here use GPU frequency (HZ) on Intel D3D12 to calculate the period in
 //   ns for testing).
 TEST_P(QueryInternalShaderTests, TimestampComputeShader) {
-    // TODO(crbug.com/tint/682): error: runtime array not supported yet
+    // TODO(crbug.com/tint/683): internal compiler error: TINT_UNIMPLEMENTED
     DAWN_SKIP_TEST_IF(IsD3D12() && HasToggleEnabled("use_tint_generator"));
     // TODO(crbug.com/dawn/741): Test output is wrong with D3D12 + WARP.
     DAWN_SKIP_TEST_IF(IsD3D12() && IsWARP());