commit eaeded4971e330369bc740ab1b991233c1f11635
author Loko Kung <lokokung@google.com> Wed Dec 14 05:46:48 2022 +0000
committer Dawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Dec 14 05:46:48 2022 +0000
tree 2c84c69f3c4983b39b753a0482e8c89e42706d99
parent 5646acbd71d54ab8537e3ca760f628c739eec895

Enables maxColorAttachmentBytesPerSample in Dawn node.

Bug: dawn:1522
Change-Id: Iaccbffbc8ac641d407491bdd8ef0b0f2c9cba309
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/113901
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Loko Kung <lokokung@google.com>
Reviewed-by: Austin Eng <enga@chromium.org>

src/dawn/node/binding/GPUAdapter.cpp

diff --git a/src/dawn/node/binding/GPUAdapter.cpp b/src/dawn/node/binding/GPUAdapter.cpp
index 73c8c11..f47b5cd 100644
--- a/src/dawn/node/binding/GPUAdapter.cpp
+++ b/src/dawn/node/binding/GPUAdapter.cpp
@@ -80,7 +80,7 @@
     X(maxVertexBufferArrayStride)                \
     X(maxInterStageShaderComponents)             \
     X(maxColorAttachments)                       \
-    /* X(maxColorAttachmentBytesPerSample) */    \
+    X(maxColorAttachmentBytesPerSample)          \
     X(maxComputeWorkgroupStorageSize)            \
     X(maxComputeInvocationsPerWorkgroup)         \
     X(maxComputeWorkgroupSizeX)                  \

src/dawn/node/binding/GPUSupportedLimits.cpp

diff --git a/src/dawn/node/binding/GPUSupportedLimits.cpp b/src/dawn/node/binding/GPUSupportedLimits.cpp
index 31682ad..c68e98e 100644
--- a/src/dawn/node/binding/GPUSupportedLimits.cpp
+++ b/src/dawn/node/binding/GPUSupportedLimits.cpp
@@ -121,8 +121,7 @@
 }
 
 uint32_t GPUSupportedLimits::getMaxColorAttachmentBytesPerSample(Napi::Env) {
-    UNIMPLEMENTED();
-    // return limits_.limits.maxColorAttachmentBytesPerSample;
+    return limits_.limits.maxColorAttachmentBytesPerSample;
 }
 
 uint32_t GPUSupportedLimits::getMaxComputeWorkgroupStorageSize(Napi::Env) {