Google Git
Sign in
dawn / dawn / 58fc3f1cc918266ac6aa993524c4336b5dd2b2c7
commit58fc3f1cc918266ac6aa993524c4336b5dd2b2c7[log] [tgz]
authorNatalie Chouinard <chouinard@google.com>Thu Jun 13 18:39:15 2024 +0000
committerDawn LUCI CQ <dawn-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 13 18:39:15 2024 +0000
tree8bb7a49e930f3433fea1bca18d9a54fa4d1f8932
parent8f8f8d78f4ddd932a692159fed0178c0418ba9c8 [diff]
Disallow textureStore in vertex shader tests

Writable storage textures cannot be used in vertex shaders, as such, the
`textureStore` builtin should only be allowed in compute and fragment
shaders. This change fixes tests that would fail once validation
against usage of writable storage buffers and textures in vertex shaders
is added to Tint.

The manually modified file in this change is src/tint/lang/wgsl/wgsl.def.

The rest of the changes were created with:
./tools/run gen
./tools/run tests --generate-expected test/tint/builtins/gen/literal/textureStore/
./tools/run tests --generate-expected test/tint/builtins/gen/var/textureStore

A unittest in StorageTextureValidationTests.cpp was also manually fixed up to account for earlier detection of the error.

Bug: 344846829
Change-Id: I68ad65a78c853e3d50e3333d6e2b00f48c0e48e8
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/192941
Reviewed-by: James Price <jrprice@google.com>
Commit-Queue: Natalie Chouinard <chouinard@google.com>
4883 files changed
tree: 8bb7a49e930f3433fea1bca18d9a54fa4d1f8932
  1. .github/
  2. .vscode/
  3. build_overrides/
  4. docs/
  5. generator/
  6. include/
  7. infra/
  8. scripts/
  9. src/
  10. test/
  11. third_party/
  12. tools/
  13. webgpu-cts/
  14. build
  15. buildtools
  16. testing
  17. .bazelrc
  18. .clang-format
  19. .clang-tidy
  20. .gitattributes
  21. .gitignore
  22. .gitmodules
  23. .gn
  24. AUTHORS
  25. BUILD.bazel
  26. BUILD.gn
  27. CMakeLists.txt
  28. CMakeSettings.json
  29. CODE_OF_CONDUCT.md
  30. codereview.settings
  31. CONTRIBUTING.md
  32. CPPLINT.cfg
  33. DEPS
  34. DIR_METADATA
  35. go.mod
  36. go.sum
  37. go_presubmit_support.py
  38. LICENSE
  39. OWNERS
  40. PRESUBMIT.py
  41. README.chromium
  42. README.md
  43. WORKSPACE.bazel
README.md

Build Status Matrix Space

Dawn, a WebGPU implementation

Dawn is an open-source and cross-platform implementation of the WebGPU standard. More precisely it implements webgpu.h that is a one-to-one mapping with the WebGPU IDL. Dawn is meant to be integrated as part of a larger system and is the underlying implementation of WebGPU in Chromium.

Dawn provides several WebGPU building blocks:

  • WebGPU C/C++ headers that applications and other building blocks use.
    • The webgpu.h version that Dawn implements.
    • A C++ wrapper for the webgpu.h.
  • A “native” implementation of WebGPU using platforms' GPU APIs: D3D12, Metal, Vulkan and OpenGL. See per API support for more details.
  • A client-server implementation of WebGPU for applications that are in a sandbox without access to native drivers
  • Tint is a compiler for the WebGPU Shader Language (WGSL) that can be used in standalone to convert shaders from and to WGSL.

Helpful links:

Documentation table of content

Developer documentation:

User documentation: (TODO, figure out what overlaps with the webgpu.h docs)

License

BSD 3-Clause License, please see LICENSE.

Disclaimer

This is not an officially supported Google product.